diff mbox

[dpdk-dev] git: ignore build directory

Message ID 1458582978-19813-1-git-send-email-stephen@networkplumber.org (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/Intel-compilation fail apply issues

Commit Message

Stephen Hemminger March 21, 2016, 5:56 p.m. UTC 
  The mk environment in DPDK puts files in build/ directory
so it makes sense to have a .gitignore file to skip that
directory.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 .gitignore | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Matthew Hall March 21, 2016, 8:57 p.m. UTC | #1 
On Mon, Mar 21, 2016 at 10:56:18AM -0700, Stephen Hemminger wrote:
> The mk environment in DPDK puts files in build/ directory
> so it makes sense to have a .gitignore file to skip that
> directory.

The last time I proposed such a patch it was rejected. It is sad when 
community patches are second class citizens behind core committers' 
patches.

Matthew.
Thomas Monjalon May 22, 2018, 9:42 p.m. UTC | #2 
21/03/2016 18:56, Stephen Hemminger:
> The mk environment in DPDK puts files in build/ directory
> so it makes sense to have a .gitignore file to skip that
> directory.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  .gitignore | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/.gitignore b/.gitignore
> index e69de29..5dc652b 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -0,0 +1,5 @@
> +*.orig
> +*.rej
> +*~
> +
> +build


Seems I never replied to this proposal.

I think .orig, .rej and other files should appear in git status.

About the "build" directory, yes it could be ignored.
But then we could ignore the default build directory and not other
build directories with specific names? Looks not consistent.
diff mbox

Patch

diff --git a/.gitignore b/.gitignore
index e69de29..5dc652b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -0,0 +1,5 @@ 
+*.orig
+*.rej
+*~
+
+build