Message ID | 1465317632-11471-19-git-send-email-jerin.jacob@caviumnetworks.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Bruce Richardson |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 09D5F9AD6; Tue, 7 Jun 2016 18:42:40 +0200 (CEST) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0076.outbound.protection.outlook.com [157.56.111.76]) by dpdk.org (Postfix) with ESMTP id B2D6F9AC1 for <dev@dpdk.org>; Tue, 7 Jun 2016 18:42:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=onNKV4Zwt9Im6THzGMz6Q5bV7039VGELxIduug62UeY=; b=l5avfTEcAlZYqj28ldo5eFd0QcL42gkIAJ3UV4cY2boYvRuNMl4fSb0Y83Z+KutQ5tFdPsoOomxre9jUyE1qKAgSYbd4VhjM9MqoY/6sFUT4MVKxCvK6J9lGIhPds+c2g+gkoL/sZeKp31QtphyyM3Pp958gcPQLsl9UopqXvlk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@cavium.com; Received: from localhost.caveonetworks.com (111.93.218.67) by BN3PR0701MB1719.namprd07.prod.outlook.com (10.163.39.18) with Microsoft SMTP Server (TLS) id 15.1.511.8; Tue, 7 Jun 2016 16:42:30 +0000 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: <dev@dpdk.org> CC: <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>, Jerin Jacob <jerin.jacob@caviumnetworks.com> Date: Tue, 7 Jun 2016 22:10:30 +0530 Message-ID: <1465317632-11471-19-git-send-email-jerin.jacob@caviumnetworks.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1465317632-11471-1-git-send-email-jerin.jacob@caviumnetworks.com> References: <1464540424-12631-1-git-send-email-jerin.jacob@caviumnetworks.com> <1465317632-11471-1-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MAXPR01CA0054.INDPRD01.PROD.OUTLOOK.COM (10.164.146.154) To BN3PR0701MB1719.namprd07.prod.outlook.com (10.163.39.18) X-MS-Office365-Filtering-Correlation-Id: b1e419c2-8461-4f84-6f67-08d38ef2b8c2 X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 2:C460iTY4YpGcTryIPBsYEQ/fW/F8wDY3XBhlHOCLRN51C/Rv8tbMvr6a1Ajc2sm9FSe/9bOH3+nj1eQw3KztrlHSqr0obKMdBvQu7bDB8+HVuWERe4EC49iXI8Yr2pLcRQ4znNTxa3vsLcS0kCWmOylSyJY1RM4gMB6gzMb9/3v5EkrVVjNghBHh6LJQiA6i; 3:k1iYw5geHyCNe7mfRoSk3BKQZYx2zRZmqX+3KbDu1Z9QtaUKzhhujcTbl2UjSf8OYGN7ULxKIVlfy0BtYuWPy4etQt4UUEJ36Z9jC1/0+B0ZbXJq+D5JIxeQP2unbORL X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1719; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 25:QHwdDcZpVANl1hpOx7MTygMATw6qqfi/V2ccaTk9anqbiQ/tx6+n8kCCR+dZkjTzinNAw2i1nucugD2zJhjIjzLwulXfn6qOGdpPDXL+3nMG9VUkw1wKt98KTcHAvxtAjdnmIy4/Dxg0vv7GFt+fIwb6NTr8kb6y3SsMzJ6JwtJMEcqyWsIFUaWf0iFfX27T3sdgFAIXsWdvNb0rcsLZYRg4gOkTrQY06hZKD9F7cdUIz69uO7/G0UEoRz6Xf/JDyhZYvw7zGGfF6wWuSOOO12Fdjv2pmxWb2QSW3bPGBbOkG9YOohTXszjEQk5i8MWHY4MxxgP9qXFBjIwGYAY749vu++Jk1Nyg3PPo10OsMmMo2QVzEuk6Sp2wzsRKTpb4UfzYmvwWN9C4yhyrJidKLWY0nW928HEHtvN3+rBHvE+af2MBDXjzaReF2lO3KaZj1CnxpPqeX1rbjoDW/AlBuQBl1sUVgMKL5UnvC5x5nBmcbs8mkqlYBtFHBIgf2kHn7i7H38x9lvFj8Tk6En/3UY6B9WfB2ctl8zwyn9KYcSfPtl4QWUllVJJasFl2os3KVlTFGB2dzo2XpRRElw5WpEHNrp9W5obA7+WXmoAqjPerwXnyQ8+ykKeZigfMgZJBxpKXQ5kXulfEZgUDx+dDPEyuk9ZW0ukGGIRlbQayUHq0Khf1S5jbtp8qYvmaI7Kg9v1BfY4+bBuQlRyM9SjW2LnhDG60JEAMegU1V5gNSr0= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 20:H72ysrfyk4KL3zBx23UOmhawCrvwBufS21OMJkaR5Hyq6l3nxJh4fGPyIonSZFRHKwP7fDL7I/UN6qP9f3CY0UPEIBmjecncNQHSdPtXh6U3AfiLcChyd9TOskwBTg6V0Nt22jSpGPtGqcYbdkqa1Ejs1ToRukbohwwhKTT2Yy7dUEwR3I9tqaSGHPoE9SGRHmd8os5Y3+ekcqUpSHlteWUlxgE3xdr2+ml/bhFg82lxIWUpZKYY22cmaOK63+A2vxcSy67LSA5c0fp5JZdqIYOrmug4GW0jA2tr190apCGYbTKT4dhvEmZitBprstbrcY0HC+mYqVy7olA7GpX+gZyfvXbZI1UTBp/+OYWwKFmipdHQ8/CdWXCArSOTYkBUnOwYuNxLZQd9R2j2S1lXLsYydK+WG1nvMB9/4Oh2uomuHDysI4J20ctNmsNsg4hFuvhfd8qzDKHHXTXLUHrOI3+twOmWX3PQi/3HHqzoLXrXYOAvEjvEPmACI/4/2FMOt8huyP13OWnLuHdf8FuOL35NSS0GgePBESXGhlvIlnzwcvbywB/LX+eWix1D11MQm6WsVR40zmRhjaww9nQITEnRb1WSNj0XMTJIY44noXY= X-Microsoft-Antispam-PRVS: <BN3PR0701MB1719CFEA398A0CE77AB1105F815D0@BN3PR0701MB1719.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BN3PR0701MB1719; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1719; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 4:x8ba87oxeRCaQoemK3J0nfjGrgk8XYx/276Ep5Z59VTUI5JxKoC8fh2P9x61qMfpsnfq0x1WOZ+/TmqJOVhNanihf/00OLKba4xOwT5ZqFlQRfRDM0o941EwKJH+VXqzSWQ6N0XxbGhhvaiaR+U2IWHqB8Fy9/r9k0+XId8CgwS44HBMS9V/XvJdaMOIDq24XYRg6hNcDtngSDpgkSxN4SaMhtBIS2A8ymRPHWQmjjhyr0/r3xtKmNrnCOaIjDklyAH5mf2FTg7r57izcZMcGyzZuC4VNcyBkc7Ah3L09vVIujnYITcDN7FlOZBdgDjvjgqScAay0Wp/MPp6eIVrA1TNlq6i2aY6RsUMP7Mst9LdjQVjIVdPo2HUb0jzp5qH X-Forefront-PRVS: 09669DB681 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(199003)(189002)(81166006)(8676002)(81156014)(47776003)(66066001)(36756003)(92566002)(2950100001)(586003)(2351001)(48376002)(76506005)(42186005)(50466002)(4326007)(77096005)(3846002)(6116002)(5003940100001)(53416004)(5004730100002)(105586002)(4001430100002)(97736004)(107886002)(2906002)(5008740100001)(106356001)(189998001)(19580395003)(69596002)(101416001)(110136002)(19580405001)(68736007)(33646002)(76176999)(50986999)(229853001)(50226002)(5009440100003)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1719; H:localhost.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1719; 23:tPU0t5Iv8gQgQWGi0eGJAgKwrzAelR7QGGqxURO?= =?us-ascii?Q?JopDUh16Mg6NTqWigQktbEXBgmZIBHqZg/Sut1ac9XClWDUJRcd7fI/nfJNx?= =?us-ascii?Q?hE6+jsKsszNmxktmgnaqgras4NhqNRwwp1waKYhc8ldCELOXd4UMh4RULL7J?= =?us-ascii?Q?rljEK0Xtcnzleq6z8PAk74byrQqJuBxNJGJRurPqxdrDXoybmwsn40Y/AAIA?= =?us-ascii?Q?+B83nrivU7SygGJQ3knQIVuG8OqrCEjTZijU+2Q+auiHuMw5QzBLSHg5S39k?= =?us-ascii?Q?sEMtCqrn54Xio2SzjZgRMftsNv8wjQH2+1gjtz52P45CBtJivf27cBxE0Ubs?= =?us-ascii?Q?bY+AiCpbOzoUBHSLn2Rg2hqW0pYhl2AyWsoQXdqRewL1j6EU6HhjL45rMfe1?= =?us-ascii?Q?TfDsv/9b8dENq/sCo1t+WWJgYUgJwSuUrs8CDDmxPa706yQkVJG/3tV/SClN?= =?us-ascii?Q?vytlHYitIgWyJopwGdoUsNlDm3q8nioX/WXauCnRodzZ3wLZMf58g0KQDKpj?= =?us-ascii?Q?nMABNL4RrQIRCwLYBfPvjxUOESqktQzA4HKiC1cgTP0IAIgaeKQHVUqRd/qj?= =?us-ascii?Q?gD2K9+JQzvDqtbGjng8VtIaxgk2fygoV7mTYc3ZSLBH1RfdLCTbKTST6lyJr?= =?us-ascii?Q?2SSxXseTWcj7FNX7tVsLH+tg0jYMq2NgnUwFU6BRQdcB2tzpdnwJBxZxq+mO?= =?us-ascii?Q?gswagbCW8QuNW1fp66MjN4PnY0PqEMHqLyi3YDHcWVSaGrStvA4hsQaYiMSE?= =?us-ascii?Q?dNG8JLKds7o+HBk6GA72EFekZipXa+JxUdWLAhooReKzcubIBKiCLSxuHAsV?= =?us-ascii?Q?1KHCoVeZiMIAAptzdkcgHwU4dVQDNNqr1s3rCDZoYt6q9FocoA8qbaqsWZ5V?= =?us-ascii?Q?81qhtR2RozglNHssV/nb28Cr/hh7kWQkjw+qDicvI7XHCyRahtCGQSpU8d93?= =?us-ascii?Q?WukPk7E0Th70J6Psjd5Q0WM1Gq6TIZKd5XE/Jd+7viPNkKpoWCYgWFnQwbCo?= =?us-ascii?Q?qdi7+BZ01RKqY0szSoqyHRj1cOHWKg3BT6E/fcQtmoZU0gRAGOoQtyMczaCF?= =?us-ascii?Q?rUUDb7L8BUYU/5lhuFIH3X6i+pzQa4JpgL2ZwahBN21FzFiSVXv62kqAsbVk?= =?us-ascii?Q?HMOrpU1yTWax9mQYimm+mwBhmMHm9uJ+8xdrkILsYxhB05S3gudnAAUSj8fO?= =?us-ascii?Q?+buISWPvuvmzPmAY36sGiwuS1hke6YzuBARJ6CXJZD+bvtIPFihSK146xTQ?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1719; 5:PTy3h/x9KYb8sFRXlRgd8GL5u5ngPiytnijtu+fWpDfbUK3oDTaL+Kq7RcSQeoNt/fawY7GjDdH6h4VCjwRRGqv9CLjCPNM0RCK0wo4uopqbnDZLU+n43/ZLE+YHj3loO4w1GkNF39f85cS75M5OZw==; 24:DORK5E1aJA2VZ/Ztgvl9IiIM6O1b3St6FUIxFREVz497MnMdLrl3pvEqG7W7uiGeGoMSske5AE/l8G6+l90zhCH3VfUFQX2iI+3kiFThQLw=; 7:klmXLWRMtIQUrw0w+or4lMgpNBAcBFOJrJLZoX18oFiEFEOL4JH4TCcWNZVokTc5nDxYTOJIocZERiis8jfmjaXvMAtALjuxo3NLDjCjXHYuPnBx46MUQi9dws0y6IfJbKuZ4xxgATKdxYKoMxW5mMsysDpBmMxZbE1qqba6iqxpnU8WtClZoO4iEQKz4Xx/z/T4Q8CDj3WFH1MlgEisS+p4paf3JvkOQTQNmgiMebA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2016 16:42:30.6718 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1719 Subject: [dpdk-dev] [PATCH v3 18/20] thunderx/config: set max numa node to two X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Jerin Jacob
June 7, 2016, 4:40 p.m. UTC
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
config/defconfig_arm64-thunderx-linuxapp-gcc | 1 +
1 file changed, 1 insertion(+)
Comments
On 6/7/2016 5:40 PM, Jerin Jacob wrote: > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > --- > config/defconfig_arm64-thunderx-linuxapp-gcc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc > index 7940bbd..cc12cee 100644 > --- a/config/defconfig_arm64-thunderx-linuxapp-gcc > +++ b/config/defconfig_arm64-thunderx-linuxapp-gcc > @@ -34,6 +34,7 @@ > CONFIG_RTE_MACHINE="thunderx" > > CONFIG_RTE_CACHE_LINE_SIZE=128 > +CONFIG_RTE_MAX_NUMA_NODES=2 Isn't this platform level configuration? And sets max numa nodes independent from driver, right? Can you please add some more information why this is required? Also does it make sense to separate this patch from driver patchset? > > # > # Compile Cavium Thunderx NICVF PMD driver >
On Wed, Jun 08, 2016 at 06:54:43PM +0100, Ferruh Yigit wrote: > On 6/7/2016 5:40 PM, Jerin Jacob wrote: > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > --- > > config/defconfig_arm64-thunderx-linuxapp-gcc | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc > > index 7940bbd..cc12cee 100644 > > --- a/config/defconfig_arm64-thunderx-linuxapp-gcc > > +++ b/config/defconfig_arm64-thunderx-linuxapp-gcc > > @@ -34,6 +34,7 @@ > > CONFIG_RTE_MACHINE="thunderx" > > > > CONFIG_RTE_CACHE_LINE_SIZE=128 > > +CONFIG_RTE_MAX_NUMA_NODES=2 > Isn't this platform level configuration? And sets max numa nodes > independent from driver, right? > Yes > Can you please add some more information why this is required? > > Also does it make sense to separate this patch from driver patchset? Yes, I will separate this patch from the series. Thanks Ferruh for the comprehensive review of this patch series. I will send the v4, addressing all of your review comments. Jerin > > > > > # > > # Compile Cavium Thunderx NICVF PMD driver > > >
diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc index 7940bbd..cc12cee 100644 --- a/config/defconfig_arm64-thunderx-linuxapp-gcc +++ b/config/defconfig_arm64-thunderx-linuxapp-gcc @@ -34,6 +34,7 @@ CONFIG_RTE_MACHINE="thunderx" CONFIG_RTE_CACHE_LINE_SIZE=128 +CONFIG_RTE_MAX_NUMA_NODES=2 # # Compile Cavium Thunderx NICVF PMD driver