[dpdk-dev,v2] doc: add tso capabilities feature for mlx5
Checks
Commit Message
Feature implemented at:
commit b007e98ccda9 ("net/mlx5: implement TSO data path")
commit 085c4137280a ("net/mlx5: support TSO in control plane")
Signed-off-by: Elad Persiko <eladpe@mellanox.com>
---
doc/guides/nics/features/mlx4.ini | 1 +
doc/guides/nics/features/mlx5.ini | 1 +
2 files changed, 2 insertions(+)
Comments
On 1/8/2017 4:23 PM, Elad Persiko wrote:
> Feature implemented at:
> commit b007e98ccda9 ("net/mlx5: implement TSO data path")
> commit 085c4137280a ("net/mlx5: support TSO in control plane")
Hi Elad,
Instead of send this a separate patch, it is better if you can send
these updates with the patch that adds the relevant feature.
So, you won't have to reference the commit ids here..
>
> Signed-off-by: Elad Persiko <eladpe@mellanox.com>
> ---
> doc/guides/nics/features/mlx4.ini | 1 +
> doc/guides/nics/features/mlx5.ini | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/doc/guides/nics/features/mlx4.ini b/doc/guides/nics/features/mlx4.ini
> index c9828f7..d74b9dd 100644
> --- a/doc/guides/nics/features/mlx4.ini
> +++ b/doc/guides/nics/features/mlx4.ini
> @@ -10,6 +10,7 @@ Queue start/stop = Y
> MTU update = Y
> Jumbo frame = Y
> Scattered Rx = Y
> +TSO = Y
> Promiscuous mode = Y
> Allmulticast mode = Y
> Unicast MAC filter = Y
> diff --git a/doc/guides/nics/features/mlx5.ini b/doc/guides/nics/features/mlx5.ini
> index f811e3f..f8a215e 100644
> --- a/doc/guides/nics/features/mlx5.ini
> +++ b/doc/guides/nics/features/mlx5.ini
> @@ -11,6 +11,7 @@ Queue start/stop = Y
> MTU update = Y
> Jumbo frame = Y
> Scattered Rx = Y
> +TSO = Y
> Promiscuous mode = Y
> Allmulticast mode = Y
> Unicast MAC filter = Y
>
On 1/8/2017 4:23 PM, Elad Persiko wrote:
> Feature implemented at:
> commit b007e98ccda9 ("net/mlx5: implement TSO data path")
> commit 085c4137280a ("net/mlx5: support TSO in control plane")
>
> Signed-off-by: Elad Persiko <eladpe@mellanox.com>
> ---
> doc/guides/nics/features/mlx4.ini | 1 +
> doc/guides/nics/features/mlx5.ini | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/doc/guides/nics/features/mlx4.ini b/doc/guides/nics/features/mlx4.ini
> index c9828f7..d74b9dd 100644
> --- a/doc/guides/nics/features/mlx4.ini
> +++ b/doc/guides/nics/features/mlx4.ini
> @@ -10,6 +10,7 @@ Queue start/stop = Y
> MTU update = Y
> Jumbo frame = Y
> Scattered Rx = Y
> +TSO = Y
One more thing, for double check, patch updates only mlx5 files, is
enabling TSO for mlx4 correct?
> Promiscuous mode = Y
> Allmulticast mode = Y
> Unicast MAC filter = Y
<...>
Thanks,
The feature is not supported on MLX4. I will fix it on V2
-----Original Message-----
From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
Sent: Monday, January 9, 2017 2:31 PM
To: Elad Persiko <eladpe@mellanox.com>; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] doc: add tso capabilities feature for mlx5
On 1/8/2017 4:23 PM, Elad Persiko wrote:
> Feature implemented at:
> commit b007e98ccda9 ("net/mlx5: implement TSO data path") commit
> 085c4137280a ("net/mlx5: support TSO in control plane")
>
> Signed-off-by: Elad Persiko <eladpe@mellanox.com>
> ---
> doc/guides/nics/features/mlx4.ini | 1 +
> doc/guides/nics/features/mlx5.ini | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/doc/guides/nics/features/mlx4.ini
> b/doc/guides/nics/features/mlx4.ini
> index c9828f7..d74b9dd 100644
> --- a/doc/guides/nics/features/mlx4.ini
> +++ b/doc/guides/nics/features/mlx4.ini
> @@ -10,6 +10,7 @@ Queue start/stop = Y
> MTU update = Y
> Jumbo frame = Y
> Scattered Rx = Y
> +TSO = Y
One more thing, for double check, patch updates only mlx5 files, is enabling TSO for mlx4 correct?
> Promiscuous mode = Y
> Allmulticast mode = Y
> Unicast MAC filter = Y
<...>
On 1/10/2017 9:18 AM, Elad Persiko wrote:
>
> Thanks,
> The feature is not supported on MLX4. I will fix it on V2
The new version of this patch will be squashed to "net/mlx5: last WQE no
room inline" patchset, right?
>
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Monday, January 9, 2017 2:31 PM
> To: Elad Persiko <eladpe@mellanox.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] doc: add tso capabilities feature for mlx5
>
> On 1/8/2017 4:23 PM, Elad Persiko wrote:
>> Feature implemented at:
>> commit b007e98ccda9 ("net/mlx5: implement TSO data path") commit
>> 085c4137280a ("net/mlx5: support TSO in control plane")
>>
>> Signed-off-by: Elad Persiko <eladpe@mellanox.com>
>> ---
>> doc/guides/nics/features/mlx4.ini | 1 +
>> doc/guides/nics/features/mlx5.ini | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/doc/guides/nics/features/mlx4.ini
>> b/doc/guides/nics/features/mlx4.ini
>> index c9828f7..d74b9dd 100644
>> --- a/doc/guides/nics/features/mlx4.ini
>> +++ b/doc/guides/nics/features/mlx4.ini
>> @@ -10,6 +10,7 @@ Queue start/stop = Y
>> MTU update = Y
>> Jumbo frame = Y
>> Scattered Rx = Y
>> +TSO = Y
>
> One more thing, for double check, patch updates only mlx5 files, is enabling TSO for mlx4 correct?
>
>> Promiscuous mode = Y
>> Allmulticast mode = Y
>> Unicast MAC filter = Y
> <...>
>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Monday, January 23, 2017 2:30 PM
> To: Elad Persiko <eladpe@mellanox.com>; dev@dpdk.org; Adrien Mazarguil
> <adrien.mazarguil@6wind.com>
> Subject: Re: [dpdk-dev] [PATCH v2] doc: add tso capabilities feature for mlx5
>
> On 1/10/2017 9:18 AM, Elad Persiko wrote:
> >
> > Thanks,
> > The feature is not supported on MLX4. I will fix it on V2
>
> The new version of this patch will be squashed to "net/mlx5: last WQE no
> room inline" patchset, right?
Yes, you are right
Best Regards,
Olga
@@ -10,6 +10,7 @@ Queue start/stop = Y
MTU update = Y
Jumbo frame = Y
Scattered Rx = Y
+TSO = Y
Promiscuous mode = Y
Allmulticast mode = Y
Unicast MAC filter = Y
@@ -11,6 +11,7 @@ Queue start/stop = Y
MTU update = Y
Jumbo frame = Y
Scattered Rx = Y
+TSO = Y
Promiscuous mode = Y
Allmulticast mode = Y
Unicast MAC filter = Y