[dpdk-dev,v11,07/18] lib: make v20 header file private

Message ID 1490004522-183515-8-git-send-email-david.hunt@intel.com
State Accepted
Headers show

Checks

Context Check Description
checkpatch success coding style OK
Intel-compilation success Compilation OK

Commit Message

David Hunt March 20, 2017, 10:08 a.m.
Signed-off-by: David Hunt <david.hunt@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_distributor/Makefile | 1 -
 1 file changed, 1 deletion(-)

Comments

Thomas Monjalon March 27, 2017, 1:10 p.m.
2017-03-20 10:08, David Hunt:
> Signed-off-by: David Hunt <david.hunt@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
[...]
>  SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor.h
> -SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include += rte_distributor_v20.h

There is no explanation for this change.
I think it would be clearer if squashed with the previous patch,
switching to the new API.

Let me know, I can squash it myself :)
David Hunt March 28, 2017, 8:47 a.m.
On 27/3/2017 2:10 PM, Thomas Monjalon wrote:
> 2017-03-20 10:08, David Hunt:
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> [...]
>>   SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor.h
>> -SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include += rte_distributor_v20.h
> There is no explanation for this change.
> I think it would be clearer if squashed with the previous patch,
> switching to the new API.
>
> Let me know, I can squash it myself :)

Sure, makes sense to squash  this one. Please do. :)

Thanks,
Dave.

Patch hide | download patch | download mbox

diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile
index a812fe4..2b28eff 100644
--- a/lib/librte_distributor/Makefile
+++ b/lib/librte_distributor/Makefile
@@ -57,7 +57,6 @@  endif
 
 # install this header file
 SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include := rte_distributor.h
-SYMLINK-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR)-include += rte_distributor_v20.h
 
 # this lib needs eal
 DEPDIRS-$(CONFIG_RTE_LIBRTE_DISTRIBUTOR) += lib/librte_eal