From patchwork Mon Mar 20 23:04:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 22029 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 0C96769C6; Tue, 21 Mar 2017 00:05:28 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0069.outbound.protection.outlook.com [104.47.2.69]) by dpdk.org (Postfix) with ESMTP id 3BB3A377A for ; Tue, 21 Mar 2017 00:04:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xNgERxsvHxaqwwqxjhTr8xMNLn2ngfaY0dsawYp/vD4=; b=RMiB06Z8Lvb/Y6GZc3Y3g5gV3J81TTax85A+tjJms0ZlFZedzePq2aeNHPc733C+EevtHw432fhgx82TRH3FAkMIeDWMAoOvWbhrouwSaApGDd2li7ksMudW4Fbi8nPytsPY31WAbiPi2oFJdhg9qYDJGpBuf8u/HUA6EC0OsNI= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none; intel.com; dmarc=none action=none header.from=mellanox.com; Received: from mellanox.com (12.250.235.110) by VI1PR0501MB2462.eurprd05.prod.outlook.com (10.168.136.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Mon, 20 Mar 2017 23:04:53 +0000 From: Yongseok Koh To: , CC: , , , Yongseok Koh Date: Mon, 20 Mar 2017 16:04:35 -0700 Message-ID: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: <20170316224056.19685-1-yskoh@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [12.250.235.110] X-ClientProxiedBy: BN6PR1301CA0021.namprd13.prod.outlook.com (10.174.84.162) To VI1PR0501MB2462.eurprd05.prod.outlook.com (10.168.136.13) X-MS-Office365-Filtering-Correlation-Id: 75e8011a-97e7-4a55-0324-08d46fe585a6 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:VI1PR0501MB2462; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2462; 3:nveFKrSDKtf09CEF4qxbogeZKrFN7kDhvmdppEUBs7ft0lisuG1iAfkDA3AWGYOmDYH61C1iFg/rDq6meDm+G4qakd1oxlME/8mo19EQeSM3bwqCU7w15otf/wizl+KS0OXIfNXUzl4R9E6mP2YbJIigBk2WDvaV9fl4NUFIbtvq1ddUFh7qKCC+LvJA/Xd5BieNBfqzTpCtOXFxnTRkD/+O5jvQ8Z8hHsZJ+LqoKzkTtYdZ+bDps+X3SPyRN2/seeMO2MWiPxoMOA8lB6a+wJ6NoJQPsj1sRxnmkOz05g0=; 25:uKizgrAZWw070kcNieNsV2H9QKu/OpTciy8EqqClDUz8gyLJ27H/0RtT+/VQd7GjBpaB+OIoNSeWLZuoboigneV3NyFNxvRwQJqNHrvzzWd/gPgKmjXcBke4IwUsNTkIJKvPa4p6DKEFDc698jzsJFOGUhEMkamgYRLMwLDJ20+K4XOJurJAF87G+c6YqpJeeMxk0tn6MlKv8bHtbl7tzD4bTyf4VjNxDaNVyZrk4tyTpnWOQ32OjKvcfdoo3qxtf/UP59ZNmsMl2P6TDLU8mOZrE9oBmpOmTPvJ+A6qcLInvmFrBmKAZ2DG+se8Az5tF4yEz1e2cKoi5YkpYZLouWT8g4dH5aJ3UVlnIGL7aR3VbPo4mnbFYa3gbTxyrq/yYTJsyHs+5PGsSjntv5qOP08TgsPephP4zjwEUAakhmuN8vQrRU+dUMwaWB/+AqQP7EWpHig1cB1aokn7kvplcg== X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2462; 31:YGUt1jLVc9VXsv1CiQtsvdDSDDvehHv4Q+zCo8t9P3+ix/wk9jOcusSdTo8c9BoZ4VVp3+SOHkCSjpHv0Fb4WB0T7lESgO5eMzZy8wGBOg6CV+y3bUK75G4jd6HfLELWVqhVNy+Ab/J94ljHy4gX2RggccEcY2Ff4JfwMno/L+iJ5kITA6ujFkWoawd9bDkcpbn5UdgdQ6kmTpBpwsX4tevgoYKUfMu9vl9mQxh4pGw=; 20:UalpYVxNzqADd0Enu/N0bZlvkUeID1NcNdWMmLakD5CQ0OqymkzHO3IQan8AinL26gzG9lIYfcV9EyfUQKkter0R7Umlq7NfXMVJVTRxHilWKN8f0cyBqYqH5Tp4b01+GIhBm4O4uhe8eoWtpq5gDpsWoluQ34u2c0h2yoNGy9YmQ5hxQk7Q5nrBJwWxaG1Gab21ejVrcPp4jj+xWKoqnUsfAjjlMSjgPaUQKqRhTRPlLCQWNRrVSC35MYvBSP4a32vFA3IF/rgdIM5lWDXXjmPURvqL9oa/KGhVSRuCduXs4xKWL3wHHXqLtfzWD5WJtIRruI/HYh5u6INhF0N8k/w2yUltroQkRqazZ0bx8JZHyqSoPt0bLhHzDgJXva5szstxwqpkY2gPYJLBr6MkoNRQDkOCDyoaLR95c74dvCi8EsLzOi82E7F75qPBk2MVEBaoCOLL6AUHCkmV/HGco0Ve6LWlvtCulgZ6HZU3IW76uGmsi/UKHTEq1OkOPmBY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(20161123558025)(6072148); SRVR:VI1PR0501MB2462; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2462; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2462; 4:pfsQomJcf4dBVVk3NqJS5S6KLZpD1CV3wu9Ska6QOCexe0MPw9rmDPV2eHKtSdVwLfc65BSoo3XkyMg0UcQ4gG6+8Xk8nyFJuZbZUbI5JyysdLiNdvWpkBhTsmnFLysM8N9IzXWlH1cd8xddVzdrJYadWutLoLgIEuUXKn8GC22DdSrm9d5ySm4S4ysBstyOV+mlLnxwZab2tXhIyqIjZd8omIqgLSn3fY0DK29x5x6B61pDKrwwMat6f4AszyGCv5JGDgsZUVHr+GM5rqAXWTBFvJQtyGLPPlCPWaO+FHpRl4wzsAQ0WW4a76wAdEuWJjwOSoCEUrgsWet3CDP9/yQJbqnAe84jrSOj/81WEdlyYg2XKxlXsbTc1anxDSMZekKPFmVrlSSjRsYS4dv60ZJ/euXKQfofgmzUNl/gVFDxd32LnusI6BpGjU1Qxrz0DNXe5FdNNKqHexytN6rRYcDVSv8Grhx4wQpj5wUA5ts/XqXuYrbUkHjSyhI8wCR1z6ZRjjQjNth6qX7n3LoAKjcslE6nXlR3Kww1pnxO2VJMwjbdRn/FFTvukNMpAyPY+sqg2aqWL1N3MvGq3ZTcwZoPoS4pZioAw9cwTyK4VYIMlhA/SmaIzCY9cQAxkqJa X-Forefront-PRVS: 02524402D6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39840400002)(39860400002)(39410400002)(39850400002)(39450400003)(305945005)(47776003)(33026002)(7736002)(5003940100001)(118296001)(5660300001)(66066001)(86362001)(81166006)(6116002)(2906002)(8676002)(107886003)(4326008)(3846002)(50226002)(38730400002)(53936002)(189998001)(6666003)(2950100002)(36756003)(54906002)(55016002)(48376002)(50466002)(33646002)(50986999)(76176999)(42186005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2462; H:mellanox.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2462; 23:Q4YsFtGersUfLrIFedoWrEz1+Y3K4CmHb9RwdMn?= 4Zn5JczD9ZpeULFRpJwRtaE3FVNBVR1oXxx7gjkHFCIhdG5B113OAYmMNFqSpF7kXnWajjX4G8RAV2s8lYP3xgJBMbrhWR2cQm056QdE3sfHPfAKUxUZgFInj6E+HZp3bR0Bqkbf0eqPaWrus/jInMLqaIyslle3T3f+q7LZNqemD6y8ZSnU/or/SQ25weg7aAx5bAUPn1BAz21IMtTDF2Co8+kgaj8BSE0Y/R3yBT0bnTz4udnQ37IE4h7qOEKyND6GmVVHxRrf+bWJVXN3eknh6NBJ7MB6SeKPKh/NoU3hZluuJakN9bI8RxMhleNH/EjRri52dRAqbqgwDz73MCJZDfEt7ziWl5JwZyyu4HjqJpDXQftXft3kTUfItCR8DjU/qwQ/BCZFnZsFOLNx98qETNa6WZm7fe2RSXcKOgGYIV9b9nRKjH9h8qvyFK6HOvRnKAD8mPnQkxXI0StNl4mMrJJrOq82DLeqyIaoRrfjzegGYaCw2NtzGQJ25U1LImulBpi+JCdUG8J4UWu5H15jV0gN1lARt4mLFiwljDoP58KwxvnMsguDnl8L1NavE97QjDNYo0rQl3iSlLwabiGbMKz3kHxN9BCBB9kf/bWbKmJfUYEAIV7zUrDd3vDfdwo2dQ+HicEguIY6VTpLCDl5Z64Ti17s1r1GWxmN3mQn73j9uiy2xc3Kdj0eD5krZWbM3UnjlXg1SdPDVhIkaSqgXsRxSHJBnn79Vt9woTTX6rksQBmk3JZkYKUK+iLy27ssHZfpXLc8QKzmBrG2rfBtZqOfzsKQ6YISLirwm5lMTp81eDiiGrXQ7rLsqRCtuM2pfStziE99GgDQjHr0X/sjvdtWGKB63d0GqPFjhTfxDURG4lXr2opLnJI5xF5Xea/SnNA8nvHLkY++/ymlKXsvo29tZYuvyIufr51y+i+wGtgfEY3cYwgPMYy0nAzRWY6g= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2462; 6:mN7OGkAGdZi+y7IS5KtNrBd4Z4YDHr9qN5z63QNOoh+g5VSjow2mVlTuJwb97DmGVmPPofEvtvrFQpWO3YaQRl4ZgXhyD20rOzJ7TEul1riSUEKf2/SvBS9TAY27KEHQLxHZaXKlq20Fu5vk2ptnyEwdbZayPDuUtdnM9olVQ7sg5souuTI3T/msmxijMd1rsfIyifmw9hVVQWjVPKr/mnKTuyoxSxG5X8RN/+Bc5N4hgy82y4uS1xVe+CjJw+T3j3oZfZzbMHz4/ciJz0TPDfeZJALEuYD2nRbEbj2x5Stmzwkl4wf5nn/jM5a4CNOJAX4Nawxa8ExzpJQzs3+eh4fJcycoipCPsVp8X4axSJIp9Z1u836vnI/tTGPX8Oyg2wcxV2HRvGC5cfTWQVQ7MparI6GgUBs/2xC50ThKbK0=; 5:Z642oGtQH1JMjO9UsPH3wxqqHnq9ZWc+b2k4TvELonaVG1cJer7aHiBqBEPqrpoVXCaPOFTgfEZVC/RQ4zFxX/5uz783TKZ8FHxEkwVi2o7p++9jO3XxG72hF5hVtMA6uVhm3SNfJsE7X/DJ1sHqhQ==; 24:Mvez6wJb+XzPPad1sMITUCCLmGrxoKB5IWnpqy8O5UbZ5xKlO8TPifxQGP2Y1XVsy+0oXNQe8X3MIwoVISSfzAJQ4WFV8hf3ag49ZeIKndI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2462; 7:34QMg8LwrxKLe3wSWi4TziqRFmyg2a5IxTIJOOQkszrqtkFwtEHFZHqt/QQI1wP5q4Cv374nwx8kyIqcUbihohS9+sy9GiJzBPctUvPyZka7KHjOCvutTaZFt8jmXnQDhnb5pilUDaJTeC+N7F/2czt2q83CPm6Y0xgpFzwrQ85ZZOqaF1IhUjrNR12kP47xh+oCUGgQ+uBqlVcPxRQb2Dl4O29+KoxEE8xlf4LYtBKZdv6+gc6I+Dw1OF5DELYvEtEWAEIoDn+Z+WYvX+NYCtAzOW/sKE6xNQt0TBLdxQoPhMGLjzrbRzOdX0d+6xyKdKzE/4n4ZfWVOAVTRewq7g== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2017 23:04:53.2694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2462 Subject: [dpdk-dev] [PATCH v2 3/3] net/mlx5: rebuild flows on updating RETA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently mlx5_dev_rss_reta_update() just updates tables in the host, therefore it isn't immediately effective until restarting the device by calling mlx5_dev_stop()/mlx5_dev_start() to update the changes in the device side. This patch adds rebuilding the device-specific datastructure and applying it to the device right away. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rss.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c index 0702f1a63..a2dd7d17c 100644 --- a/drivers/net/mlx5/mlx5_rss.c +++ b/drivers/net/mlx5/mlx5_rss.c @@ -357,8 +357,11 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev, int ret; struct priv *priv = dev->data->dev_private; + mlx5_dev_stop(dev); priv_lock(priv); ret = priv_dev_rss_reta_update(priv, reta_conf, reta_size); priv_unlock(priv); - return -ret; + if (ret) + return -ret; + return mlx5_dev_start(dev); }