[dpdk-dev,1/3] net/qede: fix missing UDP protocol in RSS offload types

Message ID 1490341259-12320-1-git-send-email-rasesh.mody@cavium.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Mody, Rasesh March 24, 2017, 7:40 a.m. UTC
  From: Harish Patil <harish.patil@qlogic.com>

Both UDP and TCP based RSS offload types are supported by the device.
This patch adds UDP protocol which got missed out in the original patch.

Fixes: 4c98f2768eef ("net/qede: support RSS hash configuration")

Signed-off-by: Harish Patil <harish.patil@qlogic.com>
---
 drivers/net/qede/qede_ethdev.c |    2 ++
 1 file changed, 2 insertions(+)
  

Comments

Ferruh Yigit March 28, 2017, 12:18 p.m. UTC | #1
On 3/24/2017 7:40 AM, Rasesh Mody wrote:
> From: Harish Patil <harish.patil@qlogic.com>
> 
> Both UDP and TCP based RSS offload types are supported by the device.
> This patch adds UDP protocol which got missed out in the original patch.
> 
> Fixes: 4c98f2768eef ("net/qede: support RSS hash configuration")
> 
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>

This patchset looks like depends to other patchset, can you please confirm?
  
Mody, Rasesh March 28, 2017, 9:20 p.m. UTC | #2
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Tuesday, March 28, 2017 5:19 AM
> 
> On 3/24/2017 7:40 AM, Rasesh Mody wrote:
> > From: Harish Patil <harish.patil@qlogic.com>
> >
> > Both UDP and TCP based RSS offload types are supported by the device.
> > This patch adds UDP protocol which got missed out in the original patch.
> >
> > Fixes: 4c98f2768eef ("net/qede: support RSS hash configuration")
> >
> > Signed-off-by: Harish Patil <harish.patil@qlogic.com>
> 
> This patchset looks like depends to other patchset, can you please confirm?

Yes, this patch set does depend on the v4 patchset.

Thanks!
-Rasesh
  
Ferruh Yigit March 30, 2017, 2:27 p.m. UTC | #3
On 3/24/2017 7:40 AM, Rasesh Mody wrote:
> From: Harish Patil <harish.patil@qlogic.com>
> 
> Both UDP and TCP based RSS offload types are supported by the device.
> This patch adds UDP protocol which got missed out in the original patch.
> 
> Fixes: 4c98f2768eef ("net/qede: support RSS hash configuration")
> 
> Signed-off-by: Harish Patil <harish.patil@qlogic.com>

Series applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 0762111..798783b 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1497,6 +1497,8 @@  static void qede_init_rss_caps(uint8_t *rss_caps, uint64_t hf)
 	*rss_caps |= (hf & ETH_RSS_NONFRAG_IPV4_TCP)  ? ECORE_RSS_IPV4_TCP : 0;
 	*rss_caps |= (hf & ETH_RSS_NONFRAG_IPV6_TCP)  ? ECORE_RSS_IPV6_TCP : 0;
 	*rss_caps |= (hf & ETH_RSS_IPV6_TCP_EX)       ? ECORE_RSS_IPV6_TCP : 0;
+	*rss_caps |= (hf & ETH_RSS_NONFRAG_IPV4_UDP)  ? ECORE_RSS_IPV4_UDP : 0;
+	*rss_caps |= (hf & ETH_RSS_NONFRAG_IPV6_UDP)  ? ECORE_RSS_IPV6_UDP : 0;
 }
 
 static int qede_rss_hash_update(struct rte_eth_dev *eth_dev,