[dpdk-dev] app/testpmd: enable NUMA support by default
Checks
Commit Message
There is little reason for NUMA support in testpmd to be off by default, so
enable it, and add in a new commandline parameter to disable it, if that is
wanted by users.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test-pmd/parameters.c | 3 +++
app/test-pmd/testpmd.c | 2 +-
doc/guides/testpmd_app_ug/run_app.rst | 7 ++++++-
3 files changed, 10 insertions(+), 2 deletions(-)
Comments
24/03/2017 18:00, Bruce Richardson:
> There is little reason for NUMA support in testpmd to be off by default, so
> enable it, and add in a new commandline parameter to disable it, if that is
> wanted by users.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Any comment or ack?
19/04/2017 18:19, Thomas Monjalon:
> 24/03/2017 18:00, Bruce Richardson:
> > There is little reason for NUMA support in testpmd to be off by default,
> > so
> > enable it, and add in a new commandline parameter to disable it, if that
> > is
> > wanted by users.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Any comment or ack?
Applied, thanks
@@ -515,6 +515,7 @@ launch_args_parse(int argc, char** argv)
{ "coremask", 1, 0, 0 },
{ "portmask", 1, 0, 0 },
{ "numa", 0, 0, 0 },
+ { "no-numa", 0, 0, 0 },
{ "mp-anon", 0, 0, 0 },
{ "port-numa-config", 1, 0, 0 },
{ "ring-numa-config", 1, 0, 0 },
@@ -651,6 +652,8 @@ launch_args_parse(int argc, char** argv)
parse_fwd_coremask(optarg);
if (!strcmp(lgopts[opt_idx].name, "portmask"))
parse_fwd_portmask(optarg);
+ if (!strcmp(lgopts[opt_idx].name, "no-numa"))
+ numa_support = 0;
if (!strcmp(lgopts[opt_idx].name, "numa")) {
numa_support = 1;
memset(port_numa,NUMA_NO_CONFIG,RTE_MAX_ETHPORTS);
@@ -95,7 +95,7 @@ uint8_t auto_start = 0;
* probed ports among the CPU sockets 0 and 1.
* Otherwise, all memory is allocated from CPU socket 0.
*/
-uint8_t numa_support = 0; /**< No numa support by default */
+uint8_t numa_support = 1; /**< numa enabled by default */
/*
* In UMA mode,all memory is allocated from socket 0 if --socket-num is
@@ -211,7 +211,12 @@ The commandline options are:
* ``--numa``
- Enable NUMA-aware allocation of RX/TX rings and of RX memory buffers (mbufs).
+ Enable NUMA-aware allocation of RX/TX rings and of RX memory buffers
+ (mbufs). [Default setting]
+
+* ``--no-numa``
+
+ Disable NUMA-aware allocation of RX/TX rings and of RX memory buffers (mbufs).
* ``--port-numa-config=(port,socket)[,(port,socket)]``