diff mbox

[dpdk-dev,v2,3/4] devtools: remove special case build for perf thread example

Message ID 20170329163856.10932-4-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Bruce Richardson March 29, 2017, 4:38 p.m. UTC 
  Since performance-thread example app is now built as part of make examples
we don't need a special case line for it in testbuild.sh script

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 devtools/test-build.sh | 3 ---
 1 file changed, 3 deletions(-)

Comments

Doherty, Declan March 30, 2017, 7:46 a.m. UTC | #1 
On 29/03/2017 5:38 PM, Bruce Richardson wrote:
> Since performance-thread example app is now built as part of make examples
> we don't need a special case line for it in testbuild.sh script
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  devtools/test-build.sh | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index 5fed4c1..a38ffab 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -237,9 +237,6 @@ for conf in $configs ; do
>  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
>  		O=$(readlink -m $dir/examples)
>  	! echo $target | grep -q '^x86_64' || \
> -	make -j$J -sC examples/performance-thread \
> -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> -		O=$(readlink -m $dir/examples/performance-thread)
>  	unset RTE_TARGET
>  	echo "################## $dir done."
>  	unset dir
>

Acked-by: Declan Doherty <declan.doherty@intel.com>
Thomas Monjalon March 30, 2017, 2:31 p.m. UTC | #2 
2017-03-29 17:38, Bruce Richardson:
> Since performance-thread example app is now built as part of make examples
> we don't need a special case line for it in testbuild.sh script
[...]
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -237,9 +237,6 @@ for conf in $configs ; do
>  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
>  		O=$(readlink -m $dir/examples)
>  	! echo $target | grep -q '^x86_64' || \
> -	make -j$J -sC examples/performance-thread \
> -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> -		O=$(readlink -m $dir/examples/performance-thread)

You are missing the x86_64 check.

This patch should be squashed with the first one.
Bruce Richardson March 30, 2017, 3:30 p.m. UTC | #3 
On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote:
> 2017-03-29 17:38, Bruce Richardson:
> > Since performance-thread example app is now built as part of make examples
> > we don't need a special case line for it in testbuild.sh script
> [...]
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > @@ -237,9 +237,6 @@ for conf in $configs ; do
> >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> >  		O=$(readlink -m $dir/examples)
> >  	! echo $target | grep -q '^x86_64' || \
> > -	make -j$J -sC examples/performance-thread \
> > -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > -		O=$(readlink -m $dir/examples/performance-thread)
> 
> You are missing the x86_64 check.

That's in the makefile in the first patch
> 
> This patch should be squashed with the first one.
> 
Sure. Doesn't matter to me!

/Bruce
Thomas Monjalon March 30, 2017, 8:38 p.m. UTC | #4 
2017-03-30 16:30, Bruce Richardson:
> On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote:
> > 2017-03-29 17:38, Bruce Richardson:
> > > Since performance-thread example app is now built as part of make examples
> > > we don't need a special case line for it in testbuild.sh script
> > [...]
> > > --- a/devtools/test-build.sh
> > > +++ b/devtools/test-build.sh
> > > @@ -237,9 +237,6 @@ for conf in $configs ; do
> > >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > >  		O=$(readlink -m $dir/examples)
> > >  	! echo $target | grep -q '^x86_64' || \
> > > -	make -j$J -sC examples/performance-thread \
> > > -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > -		O=$(readlink -m $dir/examples/performance-thread)
> > 
> > You are missing the x86_64 check.
> 
> That's in the makefile in the first patch

Sorry, I mean you should remove the above check:
	! echo $target | grep -q '^x86_64' || \
Bruce Richardson March 31, 2017, 9:15 a.m. UTC | #5 
On Thu, Mar 30, 2017 at 10:38:02PM +0200, Thomas Monjalon wrote:
> 2017-03-30 16:30, Bruce Richardson:
> > On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote:
> > > 2017-03-29 17:38, Bruce Richardson:
> > > > Since performance-thread example app is now built as part of make examples
> > > > we don't need a special case line for it in testbuild.sh script
> > > [...]
> > > > --- a/devtools/test-build.sh
> > > > +++ b/devtools/test-build.sh
> > > > @@ -237,9 +237,6 @@ for conf in $configs ; do
> > > >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > >  		O=$(readlink -m $dir/examples)
> > > >  	! echo $target | grep -q '^x86_64' || \
> > > > -	make -j$J -sC examples/performance-thread \
> > > > -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > > -		O=$(readlink -m $dir/examples/performance-thread)
> > > 
> > > You are missing the x86_64 check.
> > 
> > That's in the makefile in the first patch
> 
> Sorry, I mean you should remove the above check:
> 	! echo $target | grep -q '^x86_64' || \
> 
Oops, yes, you are right. Do you need a V3 of this set, or can you just
fix it up as you like it on apply?

/Bruce
Thomas Monjalon March 31, 2017, 9:56 a.m. UTC | #6 
2017-03-31 10:15, Bruce Richardson:
> On Thu, Mar 30, 2017 at 10:38:02PM +0200, Thomas Monjalon wrote:
> > 2017-03-30 16:30, Bruce Richardson:
> > > On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote:
> > > > 2017-03-29 17:38, Bruce Richardson:
> > > > > Since performance-thread example app is now built as part of make examples
> > > > > we don't need a special case line for it in testbuild.sh script
> > > > [...]
> > > > > --- a/devtools/test-build.sh
> > > > > +++ b/devtools/test-build.sh
> > > > > @@ -237,9 +237,6 @@ for conf in $configs ; do
> > > > >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > > >  		O=$(readlink -m $dir/examples)
> > > > >  	! echo $target | grep -q '^x86_64' || \
> > > > > -	make -j$J -sC examples/performance-thread \
> > > > > -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > > > -		O=$(readlink -m $dir/examples/performance-thread)
> > > > 
> > > > You are missing the x86_64 check.
> > > 
> > > That's in the makefile in the first patch
> > 
> > Sorry, I mean you should remove the above check:
> > 	! echo $target | grep -q '^x86_64' || \
> > 
> Oops, yes, you are right. Do you need a V3 of this set, or can you just
> fix it up as you like it on apply?

Please send a new version for this fix and the short break in next patch.
diff mbox

Patch

diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 5fed4c1..a38ffab 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -237,9 +237,6 @@  for conf in $configs ; do
 		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
 		O=$(readlink -m $dir/examples)
 	! echo $target | grep -q '^x86_64' || \
-	make -j$J -sC examples/performance-thread \
-		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
-		O=$(readlink -m $dir/examples/performance-thread)
 	unset RTE_TARGET
 	echo "################## $dir done."
 	unset dir