diff mbox

[dpdk-dev,v2] bnx2x: Update firmware versions

Message ID 20170426080833.23944-1-aik@ozlabs.ru (mailing list archive)
State Rejected, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Alexey Kardashevskiy April 26, 2017, 8:08 a.m. UTC 
  Recent kernels/distros have updated firmware images, use them.
In order to keep support of older distros (such as Fedora 19 or
Ubuntu 14.04), this also tries fallback to an order firmware version.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
Changes:
v2:
* in addition to the very new firmware images, this adds fallback to
some older firmware present in 3yo distros
---
 drivers/net/bnx2x/bnx2x.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit April 26, 2017, 9:18 a.m. UTC | #1 
On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote:
> Recent kernels/distros have updated firmware images, use them.
> In order to keep support of older distros (such as Fedora 19 or
> Ubuntu 14.04), this also tries fallback to an order firmware version.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> Changes:
> v2:
> * in addition to the very new firmware images, this adds fallback to
> some older firmware present in 3yo distros

Hi Alexey,

CC'ing maintainers.

Thank you for the patch, please CC maintainers in your patches.

Thanks,
ferruh
Alexey Kardashevskiy April 27, 2017, 4:14 a.m. UTC | #2 
On Wed, 26 Apr 2017 10:18:29 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote:
> > Recent kernels/distros have updated firmware images, use them.
> > In order to keep support of older distros (such as Fedora 19 or
> > Ubuntu 14.04), this also tries fallback to an order firmware
> > version.
> > 
> > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> > ---
> > Changes:
> > v2:
> > * in addition to the very new firmware images, this adds fallback to
> > some older firmware present in 3yo distros  
> 
> Hi Alexey,
> 
> CC'ing maintainers.
> 
> Thank you for the patch, please CC maintainers in your patches.

Thanks,

for the future - is there anything like kernel's
scripts/get_maintainer.pl? I could not spot one.


--
Alexey
Ferruh Yigit April 27, 2017, 4:29 a.m. UTC | #3 
On 4/27/2017 5:14 AM, Alexey Kardashevskiy wrote:
> On Wed, 26 Apr 2017 10:18:29 +0100
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
>> On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote:
>>> Recent kernels/distros have updated firmware images, use them.
>>> In order to keep support of older distros (such as Fedora 19 or
>>> Ubuntu 14.04), this also tries fallback to an order firmware
>>> version.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>> ---
>>> Changes:
>>> v2:
>>> * in addition to the very new firmware images, this adds fallback to
>>> some older firmware present in 3yo distros  
>>
>> Hi Alexey,
>>
>> CC'ing maintainers.
>>
>> Thank you for the patch, please CC maintainers in your patches.
> 
> Thanks,
> 
> for the future - is there anything like kernel's
> scripts/get_maintainer.pl? I could not spot one.

Current process is manually checking MAINTAINERS file.

There is no script, but dpdk maintainers file format is compatible with
get_maintaner.pl, I did able to make one for myself as a wrapper to
Linux script.

> 
> 
> --
> Alexey
>
Mody, Rasesh April 29, 2017, 12:31 a.m. UTC | #4 
Hi Alexey,

> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]

> Sent: Wednesday, April 26, 2017 2:18 AM

> 

> On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote:

> > Recent kernels/distros have updated firmware images, use them.

> > In order to keep support of older distros (such as Fedora 19 or Ubuntu

> > 14.04), this also tries fallback to an order firmware version.

> >

> > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

> > ---

> > Changes:

> > v2:

> > * in addition to the very new firmware images, this adds fallback to

> > some older firmware present in 3yo distros


To my knowledge, latest kernel/distro have 7.2.51.0 firmware image currently being used by the BNX2X PMD.
Did you test BNX2X PMD with updated and fallback firmware images? If yes, how was it tested and did you encounter any issue? Did you try SRIOV VF with these firmware versions?

Thanks!
-Rasesh

> 

> Hi Alexey,

> 

> CC'ing maintainers.

> 

> Thank you for the patch, please CC maintainers in your patches.

> 

> Thanks,

> ferruh
Alexey Kardashevskiy April 29, 2017, 5:12 a.m. UTC | #5 
On 29/04/17 10:31, Mody, Rasesh wrote:
> Hi Alexey,
> 
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Wednesday, April 26, 2017 2:18 AM
>>
>> On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote:
>>> Recent kernels/distros have updated firmware images, use them.
>>> In order to keep support of older distros (such as Fedora 19 or Ubuntu
>>> 14.04), this also tries fallback to an order firmware version.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>> ---
>>> Changes:
>>> v2:
>>> * in addition to the very new firmware images, this adds fallback to
>>> some older firmware present in 3yo distros
> 
> To my knowledge, latest kernel/distro have 7.2.51.0 firmware image currently being used by the BNX2X PMD.

I could not find any free distro with this firmware version, what latest
distro does have this firmware?

> Did you test BNX2X PMD with updated and fallback firmware images? If yes, how was it tested and did you encounter any issue? Did you try SRIOV VF with these firmware versions?

I checked it can load the firmware and that's it, I could not proceed any
further due to other unrelated reasons.

> Thanks!
> -Rasesh
> 
>>
>> Hi Alexey,
>>
>> CC'ing maintainers.
>>
>> Thank you for the patch, please CC maintainers in your patches.
>>
>> Thanks,
>> ferruh
>
Ferruh Yigit June 28, 2017, 4:01 p.m. UTC | #6 
On 4/29/2017 6:12 AM, Alexey Kardashevskiy wrote:
> On 29/04/17 10:31, Mody, Rasesh wrote:
>> Hi Alexey,
>>
>>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>>> Sent: Wednesday, April 26, 2017 2:18 AM
>>>
>>> On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote:
>>>> Recent kernels/distros have updated firmware images, use them.
>>>> In order to keep support of older distros (such as Fedora 19 or Ubuntu
>>>> 14.04), this also tries fallback to an order firmware version.
>>>>
>>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>>> ---
>>>> Changes:
>>>> v2:
>>>> * in addition to the very new firmware images, this adds fallback to
>>>> some older firmware present in 3yo distros
>>
>> To my knowledge, latest kernel/distro have 7.2.51.0 firmware image currently being used by the BNX2X PMD.
> 
> I could not find any free distro with this firmware version, what latest
> distro does have this firmware?

I am taking Rasesh's answer as no FW update required and because of not
having any other comment updating patch status as rejected.

> 
>> Did you test BNX2X PMD with updated and fallback firmware images? If yes, how was it tested and did you encounter any issue? Did you try SRIOV VF with these firmware versions?
> 
> I checked it can load the firmware and that's it, I could not proceed any
> further due to other unrelated reasons.
> 
>> Thanks!
>> -Rasesh
>>
>>>
>>> Hi Alexey,
>>>
>>> CC'ing maintainers.
>>>
>>> Thank you for the patch, please CC maintainers in your patches.
>>>
>>> Thanks,
>>> ferruh
>>
> 
>
Mody, Rasesh June 28, 2017, 5:05 p.m. UTC | #7 
Hi Ferruh,

> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Wednesday, June 28, 2017 9:01 AM
> To: Alexey Kardashevskiy <aik@ozlabs.ru>; Mody, Rasesh
> <Rasesh.Mody@cavium.com>; dev@dpdk.org
> Cc: Patil, Harish <Harish.Patil@cavium.com>
> Subject: Re: [dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions
> 
> On 4/29/2017 6:12 AM, Alexey Kardashevskiy wrote:
> > On 29/04/17 10:31, Mody, Rasesh wrote:
> >> Hi Alexey,
> >>
> >>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> >>> Sent: Wednesday, April 26, 2017 2:18 AM
> >>>
> >>> On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote:
> >>>> Recent kernels/distros have updated firmware images, use them.
> >>>> In order to keep support of older distros (such as Fedora 19 or
> >>>> Ubuntu 14.04), this also tries fallback to an order firmware version.
> >>>>
> >>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> >>>> ---
> >>>> Changes:
> >>>> v2:
> >>>> * in addition to the very new firmware images, this adds fallback
> >>>> to some older firmware present in 3yo distros
> >>
> >> To my knowledge, latest kernel/distro have 7.2.51.0 firmware image
> currently being used by the BNX2X PMD.
> >
> > I could not find any free distro with this firmware version, what
> > latest distro does have this firmware?
> 
> I am taking Rasesh's answer as no FW update required and because of not
> having any other comment updating patch status as rejected.

We found CentOS-7, Fedora 24, RHEL 7.x as well as latest SLES 12.x have this firmware. In our PMD documentation, we mention that if the firmware image is not available in any distro, user is suggested to download it from qlogic.com website.

Note that mere loadable firmware image is insufficient testing for updating to new firmware image. It needs to be backed by full functional testing (including SRIOV VF). We think, functional testing with updated firmware would require PMD changes. Currently, we don't have any plans to change the PMD for FW update.

Thanks!
-Rasesh
> 
> >
> >> Did you test BNX2X PMD with updated and fallback firmware images? If
> yes, how was it tested and did you encounter any issue? Did you try SRIOV
> VF with these firmware versions?
> >
> > I checked it can load the firmware and that's it, I could not proceed
> > any further due to other unrelated reasons.
> >
> >> Thanks!
> >> -Rasesh
> >>
> >>>
> >>> Hi Alexey,
> >>>
> >>> CC'ing maintainers.
> >>>
> >>> Thank you for the patch, please CC maintainers in your patches.
> >>>
> >>> Thanks,
> >>> ferruh
> >>
> >
> >
diff mbox

Patch

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 1a7e1c8e1..355bb117f 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -9535,8 +9535,11 @@  static void bnx2x_init_rte(struct bnx2x_softc *sc)
 }
 
 #define FW_HEADER_LEN 104
-#define FW_NAME_57711 "/lib/firmware/bnx2x/bnx2x-e1h-7.2.51.0.fw"
-#define FW_NAME_57810 "/lib/firmware/bnx2x/bnx2x-e2-7.2.51.0.fw"
+#define FW_NAME_57711_MIN "/lib/firmware/bnx2x/bnx2x-e1h-7.8.17.0.fw"
+#define FW_NAME_57810_MIN "/lib/firmware/bnx2x/bnx2x-e2-7.8.17.0.fw"
+#define FW_NAME_57711 "/lib/firmware/bnx2x/bnx2x-e1h-7.13.1.0.fw"
+#define FW_NAME_57810 "/lib/firmware/bnx2x/bnx2x-e2-7.13.1.0.fw"
+
 
 void bnx2x_load_firmware(struct bnx2x_softc *sc)
 {
@@ -9548,6 +9551,11 @@  void bnx2x_load_firmware(struct bnx2x_softc *sc)
 		? FW_NAME_57711 : FW_NAME_57810;
 	f = open(fwname, O_RDONLY);
 	if (f < 0) {
+		fwname = sc->devinfo.device_id == CHIP_NUM_57711
+			? FW_NAME_57711_MIN : FW_NAME_57810_MIN;
+		f = open(fwname, O_RDONLY);
+	}
+	if (f < 0) {
 		PMD_DRV_LOG(NOTICE, "Can't open firmware file");
 		return;
 	}