diff mbox

[dpdk-dev,2/2] bond: use rte_eth_dev_socket_id()

Message ID 1493242208-19526-2-git-send-email-jblunck@infradead.org (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jan Blunck April 26, 2017, 9:30 p.m. UTC 
  The bonded device does not have to be a PCI device. Use the rte_ethdev
functions instead.

Signed-off-by: Wen Chiu <wchiu@brocade.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Jan Blunck <jblunck@infradead.org>
---
 drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Doherty, Declan June 28, 2017, 9:49 a.m. UTC | #1 
On 26/04/17 22:30, Jan Blunck wrote:
> The bonded device does not have to be a PCI device. Use the rte_ethdev
> functions instead.
> 
> Signed-off-by: Wen Chiu <wchiu@brocade.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Jan Blunck <jblunck@infradead.org>
> ---
>   drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index b8df536..f84553c 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -886,7 +886,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
>   
>   	RTE_ASSERT(port->rx_ring == NULL);
>   	RTE_ASSERT(port->tx_ring == NULL);
> -	socket_id = rte_eth_devices[slave_id].data->numa_node;
> +	socket_id = rte_eth_dev_socket_id(slave_id);
>   	if (socket_id == (uint8_t)LCORE_ID_ANY)
>   		socket_id = 0;
>   
> 

Acked-by: Declan Doherty <declan.doherty@intel.com>
diff mbox

Patch

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index b8df536..f84553c 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -886,7 +886,7 @@  bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
 
 	RTE_ASSERT(port->rx_ring == NULL);
 	RTE_ASSERT(port->tx_ring == NULL);
-	socket_id = rte_eth_devices[slave_id].data->numa_node;
+	socket_id = rte_eth_dev_socket_id(slave_id);
 	if (socket_id == (uint8_t)LCORE_ID_ANY)
 		socket_id = 0;