[dpdk-dev,v2] hash: add neon support for thash

Message ID 20170427123349.32554-1-ashwin.sekhar@caviumnetworks.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ashwin Sekhar T K April 27, 2017, 12:33 p.m. UTC
  Verified the changes with thash_autotest unit test case

Signed-off-by: Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com>
---
v2:
* Slightly modified the content of the commit message body
* Added prefix [dpdk-dev] to the email subject line

 lib/librte_hash/rte_thash.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
  

Comments

Jianbo Liu April 28, 2017, 3:39 a.m. UTC | #1
On 27 April 2017 at 20:33, Ashwin Sekhar T K
<ashwin.sekhar@caviumnetworks.com> wrote:
> Verified the changes with thash_autotest unit test case
>
> Signed-off-by: Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com>
> ---
> v2:
> * Slightly modified the content of the commit message body
> * Added prefix [dpdk-dev] to the email subject line
>
>  lib/librte_hash/rte_thash.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_hash/rte_thash.h b/lib/librte_hash/rte_thash.h
> index a4886a8..60d58c6 100644
> --- a/lib/librte_hash/rte_thash.h
> +++ b/lib/librte_hash/rte_thash.h
> @@ -56,7 +56,7 @@ extern "C" {
>  #include <rte_ip.h>
>  #include <rte_common.h>
>
> -#ifdef __SSE3__
> +#if defined(__SSE3__) || defined(RTE_MACHINE_CPUFLAG_NEON)
>  #include <rte_vect.h>
>  #endif
>
> @@ -176,6 +176,11 @@ rte_thash_load_v6_addrs(const struct ipv6_hdr *orig, union rte_thash_tuple *targ
>         ipv6 = _mm_loadu_si128((const __m128i *)orig->dst_addr);
>         *(__m128i *)targ->v6.dst_addr =
>                         _mm_shuffle_epi8(ipv6, rte_thash_ipv6_bswap_mask);
> +#elif defined(RTE_MACHINE_CPUFLAG_NEON)
> +       uint8x16_t ipv6 = vld1q_u8((uint8_t const *)orig->src_addr);
> +       vst1q_u8((uint8_t *)targ->v6.src_addr, vrev32q_u8(ipv6));
> +       ipv6 = vld1q_u8((uint8_t const *)orig->dst_addr);
> +       vst1q_u8((uint8_t *)targ->v6.dst_addr, vrev32q_u8(ipv6));
>  #else
>         int i;
>         for (i = 0; i < 4; i++) {
> --
> 2.7.4
>

Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
  
Thomas Monjalon July 3, 2017, 1:02 p.m. UTC | #2
28/04/2017 05:39, Jianbo Liu:
> On 27 April 2017 at 20:33, Ashwin Sekhar T K
> <ashwin.sekhar@caviumnetworks.com> wrote:
> > Verified the changes with thash_autotest unit test case
> >
> > Signed-off-by: Ashwin Sekhar T K <ashwin.sekhar@caviumnetworks.com>
> > ---
> > v2:
> > * Slightly modified the content of the commit message body
> > * Added prefix [dpdk-dev] to the email subject line
> 
> Acked-by: Jianbo Liu <jianbo.liu@linaro.org>

Applied, thanks
  

Patch

diff --git a/lib/librte_hash/rte_thash.h b/lib/librte_hash/rte_thash.h
index a4886a8..60d58c6 100644
--- a/lib/librte_hash/rte_thash.h
+++ b/lib/librte_hash/rte_thash.h
@@ -56,7 +56,7 @@  extern "C" {
 #include <rte_ip.h>
 #include <rte_common.h>
 
-#ifdef __SSE3__
+#if defined(__SSE3__) || defined(RTE_MACHINE_CPUFLAG_NEON)
 #include <rte_vect.h>
 #endif
 
@@ -176,6 +176,11 @@  rte_thash_load_v6_addrs(const struct ipv6_hdr *orig, union rte_thash_tuple *targ
 	ipv6 = _mm_loadu_si128((const __m128i *)orig->dst_addr);
 	*(__m128i *)targ->v6.dst_addr =
 			_mm_shuffle_epi8(ipv6, rte_thash_ipv6_bswap_mask);
+#elif defined(RTE_MACHINE_CPUFLAG_NEON)
+	uint8x16_t ipv6 = vld1q_u8((uint8_t const *)orig->src_addr);
+	vst1q_u8((uint8_t *)targ->v6.src_addr, vrev32q_u8(ipv6));
+	ipv6 = vld1q_u8((uint8_t const *)orig->dst_addr);
+	vst1q_u8((uint8_t *)targ->v6.dst_addr, vrev32q_u8(ipv6));
 #else
 	int i;
 	for (i = 0; i < 4; i++) {