diff mbox

[dpdk-dev] app/testpmd: fix failure of creating E-Tag and NVGRE flows

Message ID 1494573189-39405-1-git-send-email-beilei.xing@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xing, Beilei May 12, 2017, 7:13 a.m. UTC 
  Application fails to create NVGRE and E_Tag flows with
current configuration, this commit fixes the issue by
adding flow items for E_TAG and NVGRE.

Fixes: e4840ef2685d ("ethdev: fix incomplete items in flow API")
Cc: stable@dpdk.org

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 app/test-pmd/config.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Adrien Mazarguil May 12, 2017, 7:50 a.m. UTC | #1 
On Fri, May 12, 2017 at 03:13:09PM +0800, Beilei Xing wrote:
> Application fails to create NVGRE and E_Tag flows with
> current configuration, this commit fixes the issue by
> adding flow items for E_TAG and NVGRE.
> 
> Fixes: e4840ef2685d ("ethdev: fix incomplete items in flow API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Missed that obvious issue as I could only validate the command-line parsing
side of things for these items. Thanks.

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Thomas Monjalon June 8, 2017, 9:03 p.m. UTC | #2 
12/05/2017 09:50, Adrien Mazarguil:
> On Fri, May 12, 2017 at 03:13:09PM +0800, Beilei Xing wrote:
> > Application fails to create NVGRE and E_Tag flows with
> > current configuration, this commit fixes the issue by
> > adding flow items for E_TAG and NVGRE.
> > 
> > Fixes: e4840ef2685d ("ethdev: fix incomplete items in flow API")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> 
> Missed that obvious issue as I could only validate the command-line parsing
> side of things for these items. Thanks.
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied, thanks
diff mbox

Patch

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 4d873cd..83a8f52 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -968,6 +968,8 @@  static const struct {
 	MK_FLOW_ITEM(TCP, sizeof(struct rte_flow_item_tcp)),
 	MK_FLOW_ITEM(SCTP, sizeof(struct rte_flow_item_sctp)),
 	MK_FLOW_ITEM(VXLAN, sizeof(struct rte_flow_item_vxlan)),
+	MK_FLOW_ITEM(E_TAG, sizeof(struct rte_flow_item_e_tag)),
+	MK_FLOW_ITEM(NVGRE, sizeof(struct rte_flow_item_nvgre)),
 	MK_FLOW_ITEM(MPLS, sizeof(struct rte_flow_item_mpls)),
 	MK_FLOW_ITEM(GRE, sizeof(struct rte_flow_item_gre)),
 };