[dpdk-dev] net/ring: fix adding MAC addresses
Checks
Commit Message
When .mac_addr_add() was changed to allow a return code, ring was changed
to return -ENOTSUP. This changes the behavior of the rte_ring driver in
a way that does not maintain backward compatibility. Additionally, if
the intent is to return -ENOTSUP, you could simply not define the stubs.
Fixes: 6d01e580ac5d ("ethdev: fix adding invalid MAC address")
Signed-off-by: Chas Williams <ciwillia@brocade.com>
---
drivers/net/ring/rte_eth_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 5/26/2017 2:18 PM, Charles (Chas) Williams wrote:
> When .mac_addr_add() was changed to allow a return code, ring was changed
> to return -ENOTSUP. This changes the behavior of the rte_ring driver in
> a way that does not maintain backward compatibility. Additionally, if
> the intent is to return -ENOTSUP, you could simply not define the stubs.
>
> Fixes: 6d01e580ac5d ("ethdev: fix adding invalid MAC address")
>
> Signed-off-by: Chas Williams <ciwillia@brocade.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
On 5/30/2017 1:45 PM, Ferruh Yigit wrote:
> On 5/26/2017 2:18 PM, Charles (Chas) Williams wrote:
>> When .mac_addr_add() was changed to allow a return code, ring was changed
>> to return -ENOTSUP. This changes the behavior of the rte_ring driver in
>> a way that does not maintain backward compatibility. Additionally, if
>> the intent is to return -ENOTSUP, you could simply not define the stubs.
>>
>> Fixes: 6d01e580ac5d ("ethdev: fix adding invalid MAC address")
>>
>> Signed-off-by: Chas Williams <ciwillia@brocade.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
@@ -230,7 +230,7 @@ eth_mac_addr_add(struct rte_eth_dev *dev __rte_unused,
uint32_t index __rte_unused,
uint32_t vmdq __rte_unused)
{
- return -ENOTSUP;
+ return 0;
}
static void