[dpdk-dev,08/18] sched: remove check for SSE4

Message ID 20170620152313.107642-9-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Bruce Richardson June 20, 2017, 3:23 p.m. UTC
  Since SSE4 is now part of the minimum requirements for DPDK, we don't need
to check for its presence any more.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_sched/rte_sched.c | 2 +-
 lib/librte_table/rte_lru.h   | 7 +------
 2 files changed, 2 insertions(+), 7 deletions(-)
  

Comments

Thomas Monjalon July 4, 2017, 12:40 p.m. UTC | #1
20/06/2017 17:23, Bruce Richardson:
> Since SSE4 is now part of the minimum requirements for DPDK, we don't need
> to check for its presence any more.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  lib/librte_sched/rte_sched.c | 2 +-
>  lib/librte_table/rte_lru.h   | 7 +------
>  2 files changed, 2 insertions(+), 7 deletions(-)

You have squashed sched and table together.
Resurrecting commit for librte_table:

    table: remove check for SSE4
    
    Since SSE4 is now part of the minimum requirements for DPDK, we don't need
    the scalar version on x86.
  

Patch

diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index 614705d..95c24e3 100644
--- a/lib/librte_sched/rte_sched.c
+++ b/lib/librte_sched/rte_sched.c
@@ -56,7 +56,7 @@ 
 #ifdef RTE_SCHED_VECTOR
 #include <rte_vect.h>
 
-#if defined(__SSE4__)
+#ifdef RTE_ARCH_X86
 #define SCHED_VECTOR_SSE4
 #endif
 
diff --git a/lib/librte_table/rte_lru.h b/lib/librte_table/rte_lru.h
index e87e062..1090163 100644
--- a/lib/librte_table/rte_lru.h
+++ b/lib/librte_table/rte_lru.h
@@ -47,18 +47,13 @@  extern "C" {
 #endif
 
 #ifndef RTE_TABLE_HASH_LRU_STRATEGY
-#ifdef __SSE4_2__
+#ifdef RTE_ARCH_X86_64
 #define RTE_TABLE_HASH_LRU_STRATEGY                        2
 #else /* if no SSE, use simple scalar version */
 #define RTE_TABLE_HASH_LRU_STRATEGY                        1
 #endif
 #endif
 
-#ifndef RTE_ARCH_X86_64
-#undef RTE_TABLE_HASH_LRU_STRATEGY
-#define RTE_TABLE_HASH_LRU_STRATEGY                        1
-#endif
-
 #if (RTE_TABLE_HASH_LRU_STRATEGY < 0) || (RTE_TABLE_HASH_LRU_STRATEGY > 3)
 #error Invalid value for RTE_TABLE_HASH_LRU_STRATEGY
 #endif