diff mbox

[dpdk-dev,v3,4/9] bus: properly include rte_debug

Message ID 4a5ed1297b9b79329179e8aae8fd336bf98f6b97.1497999952.git.gaetan.rivet@6wind.com (mailing list archive)
State Rejected, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply patch file failure

Commit Message

Gaëtan Rivet June 20, 2017, 11:36 p.m. UTC 
  Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
 lib/librte_eal/common/eal_common_bus.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Monjalon June 21, 2017, 7:45 a.m. UTC | #1 
21/06/2017 01:36, Gaetan Rivet:
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Please add a comment to explain why this include is required now.
Gaëtan Rivet June 21, 2017, 9:26 a.m. UTC | #2 
On Wed, Jun 21, 2017 at 09:45:12AM +0200, Thomas Monjalon wrote:
> 21/06/2017 01:36, Gaetan Rivet:
> > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> 
> Please add a comment to explain why this include is required now.

This commit will have this comment in the next version:

    This include is necessary for rte_bus, but it is currently brought by
    eal_private.h including rte_pci.h, including rte_debug.h.

    rte_pci.h will move out of the EAL. All compilation units should be
    self-sufficient include-wise.

Cheers,
diff mbox

Patch

diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c
index e9fbc03..7e8d50b 100644
--- a/lib/librte_eal/common/eal_common_bus.c
+++ b/lib/librte_eal/common/eal_common_bus.c
@@ -36,6 +36,7 @@ 
 #include <sys/queue.h>
 
 #include <rte_bus.h>
+#include <rte_debug.h>
 
 #include "eal_private.h"