diff mbox

[dpdk-dev] pci: fix level of scan debug log on BSD

Message ID 20170711171046.22558-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Thomas Monjalon July 11, 2017, 5:10 p.m. UTC 
  Printing the number of scanned devices should be a debug log,
not an error.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bruce Richardson Aug. 3, 2017, 10:16 a.m. UTC | #1 
On Tue, Jul 11, 2017 at 07:10:46PM +0200, Thomas Monjalon wrote:
> Printing the number of scanned devices should be a debug log,
> not an error.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
> index e321461d8..9335247d8 100644
> --- a/lib/librte_eal/bsdapp/eal/eal_pci.c
> +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
> @@ -396,7 +396,7 @@ rte_pci_scan(void)
>  
>  	close(fd);
>  
> -	RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count);
> +	RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count);
>  	return 0;
>  
would have gone for INFO level myself, but DEBUG works too - it's
definitely not an error.
The commit title also reads a bit strange to me. How about e.g.:
"pci: log fix level of PCI scan summary message on BSD"

Otherwise:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon Aug. 3, 2017, 3:36 p.m. UTC | #2 
03/08/2017 12:16, Bruce Richardson:
> On Tue, Jul 11, 2017 at 07:10:46PM +0200, Thomas Monjalon wrote:
> > Printing the number of scanned devices should be a debug log,
> > not an error.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
[...]
> > -	RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count);
> > +	RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count);
> >  	return 0;
> >  
> would have gone for INFO level myself, but DEBUG works too - it's
> definitely not an error.
> The commit title also reads a bit strange to me. How about e.g.:
> "pci: log fix level of PCI scan summary message on BSD"
> 
> Otherwise:
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
index e321461d8..9335247d8 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -396,7 +396,7 @@  rte_pci_scan(void)
 
 	close(fd);
 
-	RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count);
+	RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count);
 	return 0;
 
 error: