[dpdk-dev] net/i40e: fix hierarchy commit check

Message ID 1501080219-68567-1-git-send-email-wenzhuo.lu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Wenzhuo Lu July 26, 2017, 2:43 p.m. UTC
  If there's no Traffic Management node added. Not
necessary to check if TM is committed.

Fixes: cac29c3c00a4 ("net/i40e: support committing TM hierarchy")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Cristian Dumitrescu July 26, 2017, 3:17 p.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Wednesday, July 26, 2017 3:44 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: [dpdk-dev] [PATCH] net/i40e: fix hierarchy commit check
> 
> If there's no Traffic Management node added. Not
> necessary to check if TM is committed.
> 
> Fixes: cac29c3c00a4 ("net/i40e: support committing TM hierarchy")
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 9fcccda..042bcc1 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -2033,7 +2033,7 @@ static inline void i40e_GLQF_reg_init(struct
> i40e_hw *hw)
> 
>  	i40e_filter_restore(pf);
> 
> -	if (!pf->tm_conf.committed)
> +	if (pf->tm_conf.root && !pf->tm_conf.committed)
>  		PMD_DRV_LOG(WARNING,
>  			    "please call hierarchy_commit() "
>  			    "before starting the port");
> --
> 1.9.3

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
  
Thomas Monjalon July 31, 2017, 5:11 p.m. UTC | #2
> > If there's no Traffic Management node added. Not
> > necessary to check if TM is committed.
> > 
> > Fixes: cac29c3c00a4 ("net/i40e: support committing TM hierarchy")
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Added TM in the title and applied, thanks
  

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 9fcccda..042bcc1 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -2033,7 +2033,7 @@  static inline void i40e_GLQF_reg_init(struct i40e_hw *hw)
 
 	i40e_filter_restore(pf);
 
-	if (!pf->tm_conf.committed)
+	if (pf->tm_conf.root && !pf->tm_conf.committed)
 		PMD_DRV_LOG(WARNING,
 			    "please call hierarchy_commit() "
 			    "before starting the port");