diff mbox

[dpdk-dev] test: fix virtual device name not set

Message ID 20170726154607.26152-1-tomaszx.kulasek@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Tomasz Kulasek July 26, 2017, 3:46 p.m. UTC 
  Device name in device structure in virtual device used in
link_bonding_autotest is not set what causes segmentation fault when
rte_eth_dev_allocated is called.

Fixes: a1e7c17555e8 ("ethdev: use device name from device structure")

Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
---
 test/test/virtual_pmd.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Doherty, Declan July 26, 2017, 5:06 p.m. UTC | #1 
On 26/07/2017 4:46 PM, Tomasz Kulasek wrote:
> Device name in device structure in virtual device used in
> link_bonding_autotest is not set what causes segmentation fault when
> rte_eth_dev_allocated is called.
>
> Fixes: a1e7c17555e8 ("ethdev: use device name from device structure")
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
>  test/test/virtual_pmd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c
> index 8e698bc..9d46ad5 100644
> --- a/test/test/virtual_pmd.c
> +++ b/test/test/virtual_pmd.c
> @@ -565,6 +565,7 @@ static void  virtual_ethdev_stop(struct rte_eth_dev *eth_dev __rte_unused)
>  		goto err;
>
>  	pci_dev->device.numa_node = socket_id;
> +	pci_dev->device.name = eth_dev->data->name;
>  	pci_drv->driver.name = virtual_ethdev_driver_name;
>  	pci_drv->id_table = id_table;
>
>

Acked-by: Declan Doherty <declan.doherty@intel.com>
Ferruh Yigit July 31, 2017, 3:18 p.m. UTC | #2 
On 7/26/2017 6:06 PM, Declan Doherty wrote:
> On 26/07/2017 4:46 PM, Tomasz Kulasek wrote:
>> Device name in device structure in virtual device used in
>> link_bonding_autotest is not set what causes segmentation fault when
>> rte_eth_dev_allocated is called.
>>
>> Fixes: a1e7c17555e8 ("ethdev: use device name from device structure")
>>
>> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>

> Acked-by: Declan Doherty <declan.doherty@intel.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/test/test/virtual_pmd.c b/test/test/virtual_pmd.c
index 8e698bc..9d46ad5 100644
--- a/test/test/virtual_pmd.c
+++ b/test/test/virtual_pmd.c
@@ -565,6 +565,7 @@  static void  virtual_ethdev_stop(struct rte_eth_dev *eth_dev __rte_unused)
 		goto err;
 
 	pci_dev->device.numa_node = socket_id;
+	pci_dev->device.name = eth_dev->data->name;
 	pci_drv->driver.name = virtual_ethdev_driver_name;
 	pci_drv->id_table = id_table;