diff mbox

[dpdk-dev,RFC] remove redundant file header note

Message ID 20170821135103.22631-1-ferruh.yigit@intel.com (mailing list archive)
State Rejected, archived
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit Aug. 21, 2017, 1:51 p.m. UTC 
  Some of the "All rights reserved." note looks like duplicate, there is
one for each copyright note in the same line, and extra one after the
copyright notes. Sample is in below patch.

Although this looks like a duplication, I am not sure if this is a legal
requirement, or legally has a meaning.

And this usage keep increasing when a new file created, because header copied
from an old file..

If there is no objection I can send a patch to clean them, there are
some number of them now:
$ git grep "[*#]\s*All rights reserved." | wc -l
1373

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 Makefile | 1 -
 1 file changed, 1 deletion(-)

Comments

Thomas Monjalon Aug. 23, 2017, 8:40 p.m. UTC | #1 
21/08/2017 15:51, Ferruh Yigit:
> Some of the "All rights reserved." note looks like duplicate, there is
> one for each copyright note in the same line, and extra one after the
> copyright notes. Sample is in below patch.
> 
> Although this looks like a duplication, I am not sure if this is a legal
> requirement, or legally has a meaning.

I think the whole sentence "All rights reserved" has no meaning
and could be removed in both lines, but I am not a lawyer :)
I'm afraid lawyers won't take the risk to change these lines.

[...]
>  #   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> -#   All rights reserved.

You could also remove "(c)" after Copyright.
Ferruh Yigit Aug. 24, 2017, 2:05 p.m. UTC | #2 
On 8/23/2017 9:40 PM, Thomas Monjalon wrote:
> 21/08/2017 15:51, Ferruh Yigit:
>> Some of the "All rights reserved." note looks like duplicate, there is
>> one for each copyright note in the same line, and extra one after the
>> copyright notes. Sample is in below patch.
>>
>> Although this looks like a duplication, I am not sure if this is a legal
>> requirement, or legally has a meaning.
> 
> I think the whole sentence "All rights reserved" has no meaning
> and could be removed in both lines, but I am not a lawyer :)
> I'm afraid lawyers won't take the risk to change these lines.

I also don't dare to take that risk :)
Let me send a patch just to remove standalone "All rights reserved." lines..

> 
> [...]
>>  #   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
>> -#   All rights reserved.
> 
> You could also remove "(c)" after Copyright.
>
diff mbox

Patch

diff --git a/Makefile b/Makefile
index f4b807ebd..795ef03b4 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,6 @@ 
 #   BSD LICENSE
 #
 #   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
-#   All rights reserved.
 #
 #   Redistribution and use in source and binary forms, with or without
 #   modification, are permitted provided that the following conditions