diff mbox

[dpdk-dev] lib/gro: fix typo in .map file

Message ID 1503410329-115574-1-git-send-email-jiayu.hu@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Hu, Jiayu Aug. 22, 2017, 1:58 p.m. UTC 
  The names of rte_gro_ctx_create() and rte_gro_ctx_destroy() in
rte_gro_version.map are incorrect. This patch is to fix this issue.

Fixes: e996506a1c07 ("lib/gro: add Generic Receive Offload API framework")

Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
---
 lib/librte_gro/rte_gro_version.map | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit Aug. 22, 2017, 2:38 p.m. UTC | #1 
On 8/22/2017 2:58 PM, Jiayu Hu wrote:
> The names of rte_gro_ctx_create() and rte_gro_ctx_destroy() in
> rte_gro_version.map are incorrect. This patch is to fix this issue.
> 
> Fixes: e996506a1c07 ("lib/gro: add Generic Receive Offload API framework")
> 
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon Aug. 31, 2017, 8:35 p.m. UTC | #2 
22/08/2017 16:38, Ferruh Yigit:
> On 8/22/2017 2:58 PM, Jiayu Hu wrote:
> > The names of rte_gro_ctx_create() and rte_gro_ctx_destroy() in
> > rte_gro_version.map are incorrect. This patch is to fix this issue.
> > 
> > Fixes: e996506a1c07 ("lib/gro: add Generic Receive Offload API framework")
> > 
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks

PS: the headline must start with gro, not lib/gro.
The reason is that everything is a lib in DPDK :)
Hu, Jiayu Sept. 1, 2017, 1:29 a.m. UTC | #3 
Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, September 1, 2017 4:35 AM
> To: Hu, Jiayu <jiayu.hu@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] lib/gro: fix typo in .map file
> 
> 22/08/2017 16:38, Ferruh Yigit:
> > On 8/22/2017 2:58 PM, Jiayu Hu wrote:
> > > The names of rte_gro_ctx_create() and rte_gro_ctx_destroy() in
> > > rte_gro_version.map are incorrect. This patch is to fix this issue.
> > >
> > > Fixes: e996506a1c07 ("lib/gro: add Generic Receive Offload API
> framework")
> > >
> > > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> >
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Applied, thanks
> 
> PS: the headline must start with gro, not lib/gro.
> The reason is that everything is a lib in DPDK :)

Thanks for your reminder.

Thanks,
Jiayu
diff mbox

Patch

diff --git a/lib/librte_gro/rte_gro_version.map b/lib/librte_gro/rte_gro_version.map
index bb40bb4..1606b6d 100644
--- a/lib/librte_gro/rte_gro_version.map
+++ b/lib/librte_gro/rte_gro_version.map
@@ -1,8 +1,8 @@ 
 DPDK_17.08 {
 	global:
 
-	rte_gro_ctrl_create;
-	rte_gro_ctrl_destroy;
+	rte_gro_ctx_create;
+	rte_gro_ctx_destroy;
 	rte_gro_get_pkt_count;
 	rte_gro_reassemble;
 	rte_gro_reassemble_burst;