[dpdk-dev] doc: announce ABI change for ring structure
Checks
Commit Message
As discussed on the mailing list, the alignment constraint of
the ring structure can be relaxed.
Link: http://dpdk.org/dev/patchwork/patch/25039
Link: http://dpdk.org/dev/patchwork/patch/26103
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
Comments
On Mon, Sep 11, 2017 at 03:39:13PM +0200, Olivier Matz wrote:
> As discussed on the mailing list, the alignment constraint of
> the ring structure can be relaxed.
>
> Link: http://dpdk.org/dev/patchwork/patch/25039
> Link: http://dpdk.org/dev/patchwork/patch/26103
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> -----Original Message-----
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> Sent: Monday, September 11, 2017 2:39 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Verkamp, Daniel <daniel.verkamp@intel.com>;
> Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Subject: [PATCH] doc: announce ABI change for ring structure
>
> As discussed on the mailing list, the alignment constraint of the ring
> structure can be relaxed.
>
> Link: http://dpdk.org/dev/patchwork/patch/25039
> Link: http://dpdk.org/dev/patchwork/patch/26103
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz
> Sent: Monday, September 11, 2017 2:39 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Verkamp, Daniel
> <daniel.verkamp@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: announce ABI change for ring structure
>
> As discussed on the mailing list, the alignment constraint of the ring structure
> can be relaxed.
>
> Link: http://dpdk.org/dev/patchwork/patch/25039
> Link: http://dpdk.org/dev/patchwork/patch/26103
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Hi,
On Mon, Sep 11, 2017 at 03:39:13PM +0200, Olivier Matz wrote:
> As discussed on the mailing list, the alignment constraint of
> the ring structure can be relaxed.
>
> Link: http://dpdk.org/dev/patchwork/patch/25039
> Link: http://dpdk.org/dev/patchwork/patch/26103
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 3362f3350..5a63c0277 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -120,3 +120,9 @@ Deprecation Notices
> The non-"do-sig" versions of the hash tables will be removed
> (including the ``signature_offset`` parameter)
> and the "do-sig" versions renamed accordingly.
> +
> +* ring: The alignment constraints on the ring structure will be relaxed
> + to one cache line instead of two, and an empty cache line padding will
> + be added between the producer and consumer structures. The size of the
> + structure and the offset of the fields will remain the same on
> + platforms with 64B cache line, but will change on other platforms.
> --
> 2.11.0
>
It looks this patch was forgotten.
It has 3 acks but was not integrated in 17.11.
Or did I miss something?
08/12/2017 15:14, Olivier MATZ:
> > +* ring: The alignment constraints on the ring structure will be relaxed
> > + to one cache line instead of two, and an empty cache line padding will
> > + be added between the producer and consumer structures. The size of the
> > + structure and the offset of the fields will remain the same on
> > + platforms with 64B cache line, but will change on other platforms.
>
> It looks this patch was forgotten.
> It has 3 acks but was not integrated in 17.11.
> Or did I miss something?
It seems I missed something. Sorry about that.
The release 18.02 should be ABI stable.
While happy to experiment such stability on one release,
it seems I forgot to notify you on this thread.
Sorry again
08/12/2017 18:01, Thomas Monjalon:
> 08/12/2017 15:14, Olivier MATZ:
> > > +* ring: The alignment constraints on the ring structure will be relaxed
> > > + to one cache line instead of two, and an empty cache line padding will
> > > + be added between the producer and consumer structures. The size of the
> > > + structure and the offset of the fields will remain the same on
> > > + platforms with 64B cache line, but will change on other platforms.
> >
> > It looks this patch was forgotten.
> > It has 3 acks but was not integrated in 17.11.
> > Or did I miss something?
>
> It seems I missed something. Sorry about that.
> The release 18.02 should be ABI stable.
> While happy to experiment such stability on one release,
> it seems I forgot to notify you on this thread.
> Sorry again
Applied for change planned in 18.05.
Sorry again for the delay.
@@ -120,3 +120,9 @@ Deprecation Notices
The non-"do-sig" versions of the hash tables will be removed
(including the ``signature_offset`` parameter)
and the "do-sig" versions renamed accordingly.
+
+* ring: The alignment constraints on the ring structure will be relaxed
+ to one cache line instead of two, and an empty cache line padding will
+ be added between the producer and consumer structures. The size of the
+ structure and the offset of the fields will remain the same on
+ platforms with 64B cache line, but will change on other platforms.