diff mbox

[dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF

Message ID 1505903043-51967-1-git-send-email-wei.dai@intel.com (mailing list archive)
State Rejected, archived
Delegated to: Helin Zhang
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Wei Dai Sept. 20, 2017, 10:24 a.m. UTC 
  When a PF port is bound to VFIO-PIC, only miscellaneous interrupt
is mapped to VFIO vector 0 in ixgbe_dev_init( ).
In ixgbe_dev_start(), if previous VFIO interrupt mapping set in
ixgbe_dev_init( ) is not cleard, it will fail when calling
rte_intr_enable( ) tries to map Rx queue interrupt to other VFIO
vectors. This patch clears the VFIO interrupt mappings before
setting both miscellaneous and Rx queue interrupt mappings again
to avoid failure.

Fixes: 0a45657a6794 ("pci: rework interrupt handling")
Cc: stable@dpdk.org

Signed-off-by: Wei Dai <wei.dai@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Wenzhuo Lu Jan. 9, 2018, 8:23 a.m. UTC | #1 
Hi Wei,

> +	rte_intr_disable(intr_handle);
TBH, confused by this patch. I see the intr already disabled at the begining
of this function, ixgbe_dev_start, why we need to disable it again?
Qiming Yang Jan. 10, 2018, 6:28 a.m. UTC | #2 
+1 why we disable interrupt in dev_start twice?

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Tuesday, January 9, 2018 4:24 PM
> To: Dai, Wei <wei.dai@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF
> 
> Hi Wei,
> 
> > +	rte_intr_disable(intr_handle);
> TBH, confused by this patch. I see the intr already disabled at the begining of this
> function, ixgbe_dev_start, why we need to disable it again?
Wei Dai Jan. 22, 2018, 7:03 a.m. UTC | #3 
I add this code line to align same style and same action taken in ixgbe VF and i40e VF.
In ixgbe VF or i40e VF,  without this line, the initialization of Rx queue interrupt mapping to VFIO-PCI vectors would fail.
I have tested it in ixgbe PF port with example/l3fwd-power and 
found the interrupt can be initialized successfully and Rx queue can be waked up by incoming packets
no matter whether this line exists or not.
So I decide to reject it now.


> -----Original Message-----
> From: Yang, Qiming
> Sent: Wednesday, January 10, 2018 2:29 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Dai, Wei <wei.dai@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF
> 
> +1 why we disable interrupt in dev_start twice?
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> > Sent: Tuesday, January 9, 2018 4:24 PM
> > To: Dai, Wei <wei.dai@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF
> >
> > Hi Wei,
> >
> > > +	rte_intr_disable(intr_handle);
> > TBH, confused by this patch. I see the intr already disabled at the
> > begining of this function, ixgbe_dev_start, why we need to disable it
> again?
diff mbox

Patch

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 9ca5cbc..5292694 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2692,6 +2692,15 @@  ixgbe_dev_start(struct rte_eth_dev *dev)
 				     " no intr multiplex");
 	}
 
+	/* When a PF port is bound to VFIO-PCI only miscellaneous interrupt
+	 * is mapped to VFIO vector 0 in ixgbe_dev_init( ).
+	 * If previous VFIO interrupt mapping set in ixgbe_dev_init( ) is
+	 * not cleared, it will fail when following rte_intr_enable( ) tries
+	 * to map Rx queue interrupt to other VFIO vectors.
+	 * So clear uio/vfio intr/evevnfd first to avoid failure.
+	 */
+	rte_intr_disable(intr_handle);
+
 	/* check if rxq interrupt is enabled */
 	if (dev->data->dev_conf.intr_conf.rxq != 0 &&
 	    rte_intr_dp_is_en(intr_handle))