[dpdk-dev] doc: add Linux flower support check in TAP guide

Message ID 20170920130313.28068-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Thomas Monjalon Sept. 20, 2017, 1:03 p.m. UTC
  The flow API is supported in TAP PMD if flower is supported in Linux.
Some commands are combined to suggest a convenient check of its support
by the running kernel.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/nics/tap.rst | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
  

Comments

Pascal Mazon Sept. 20, 2017, 1:08 p.m. UTC | #1
Acked-by: Pascal Mazon <pascal.mazon@6wind.com>

On 20/09/2017 15:03, Thomas Monjalon wrote:
> The flow API is supported in TAP PMD if flower is supported in Linux.
> Some commands are combined to suggest a convenient check of its support
> by the running kernel.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  doc/guides/nics/tap.rst | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/nics/tap.rst b/doc/guides/nics/tap.rst
> index f3ee95d28..04086b110 100644
> --- a/doc/guides/nics/tap.rst
> +++ b/doc/guides/nics/tap.rst
> @@ -113,7 +113,14 @@ Flow API support
>  ----------------
>  
>  The tap PMD supports major flow API pattern items and actions, when running on
> -linux kernels above 4.2 ("Flower" classifier required). Supported items:
> +linux kernels above 4.2 ("Flower" classifier required).
> +The kernel support can be checked with this command::
> +
> +   zcat /proc/config.gz | ( grep 'CLS_FLOWER=' || echo 'not supported' ) |
> +   tee -a /dev/stderr | grep -q '=m' &&
> +   lsmod | ( grep cls_flower || echo 'try modprobe cls_flower' )
> +
> +Supported items:
>  
>  - eth: src and dst (with variable masks), and eth_type (0xffff mask).
>  - vlan: vid, pcp, tpid, but not eid. (requires kernel 4.9)
  
John McNamara Sept. 25, 2017, 11:23 a.m. UTC | #2
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Wednesday, September 20, 2017 2:03 PM
> To: Pascal Mazon <pascal.mazon@6wind.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: add Linux flower support check in TAP
> guide
> 
> The flow API is supported in TAP PMD if flower is supported in Linux.
> Some commands are combined to suggest a convenient check of its support by
> the running kernel.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: John McNamara <john.mcnamara@intel.com>
  
Ferruh Yigit Sept. 25, 2017, 1 p.m. UTC | #3
On 9/25/2017 12:23 PM, Mcnamara, John wrote:
> 
> 
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
>> Sent: Wednesday, September 20, 2017 2:03 PM
>> To: Pascal Mazon <pascal.mazon@6wind.com>
>> Cc: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] doc: add Linux flower support check in TAP
>> guide
>>
>> The flow API is supported in TAP PMD if flower is supported in Linux.
>> Some commands are combined to suggest a convenient check of its support by
>> the running kernel.
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Pascal Mazon <pascal.mazon@6wind.com>

> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/doc/guides/nics/tap.rst b/doc/guides/nics/tap.rst
index f3ee95d28..04086b110 100644
--- a/doc/guides/nics/tap.rst
+++ b/doc/guides/nics/tap.rst
@@ -113,7 +113,14 @@  Flow API support
 ----------------
 
 The tap PMD supports major flow API pattern items and actions, when running on
-linux kernels above 4.2 ("Flower" classifier required). Supported items:
+linux kernels above 4.2 ("Flower" classifier required).
+The kernel support can be checked with this command::
+
+   zcat /proc/config.gz | ( grep 'CLS_FLOWER=' || echo 'not supported' ) |
+   tee -a /dev/stderr | grep -q '=m' &&
+   lsmod | ( grep cls_flower || echo 'try modprobe cls_flower' )
+
+Supported items:
 
 - eth: src and dst (with variable masks), and eth_type (0xffff mask).
 - vlan: vid, pcp, tpid, but not eid. (requires kernel 4.9)