diff mbox

[dpdk-dev,v2] net/i40e: improve i40evf buffer cleanup in Tx vector mode

Message ID 20171006140853.27212-1-rmelton@cisco.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Roger Melton Oct. 6, 2017, 2:08 p.m. UTC 
  Signed-off-by: Roger B Melton <rmelton@cisco.com>
---
v2 - Same content as v1, but properly signed-off.

i40evf tx vector logic frees mbufs, but it does not remove the
mbufs from software rings which leads to double frees.  This change
corrects that oversight.  I've validated this fix within our application.

 drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Ferruh Yigit Oct. 10, 2017, 5:40 p.m. UTC | #1 
On 10/6/2017 3:08 PM, Roger B Melton wrote:
> Signed-off-by: Roger B Melton <rmelton@cisco.com>
> ---
> v2 - Same content as v1, but properly signed-off.

This patch marked as Superseded in patchwork by patch:
http://dpdk.org/dev/patchwork/patch/30023/
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h
index 39a6da0..fdc6fce 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
@@ -127,6 +127,7 @@  i40e_tx_free_bufs(struct i40e_tx_queue *txq)
 	if (likely(m != NULL)) {
 		free[0] = m;
 		nb_free = 1;
+		txep[0].mbuf = NULL;
 		for (i = 1; i < n; i++) {
 			m = rte_pktmbuf_prefree_seg(txep[i].mbuf);
 			if (likely(m != NULL)) {
@@ -139,14 +140,17 @@  i40e_tx_free_bufs(struct i40e_tx_queue *txq)
 					free[0] = m;
 					nb_free = 1;
 				}
+				txep[i].mbuf = NULL;
 			}
 		}
 		rte_mempool_put_bulk(free[0]->pool, (void **)free, nb_free);
 	} else {
+		txep[0].mbuf = NULL;
 		for (i = 1; i < n; i++) {
 			m = rte_pktmbuf_prefree_seg(txep[i].mbuf);
 			if (m != NULL)
 				rte_mempool_put(m->pool, m);
+			txep[i].mbuf = NULL;
 		}
 	}