diff mbox

[dpdk-dev,v1,8/8] bus: remove redundant IOVA mode getter

Message ID 9d68b81c8073666dcf00ead1fa67516f456ee3bf.1507796085.git.gaetan.rivet@6wind.com (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply patch file failure

Commit Message

Gaëtan Rivet Oct. 12, 2017, 8:18 a.m. UTC 
  This configuration element is now accessible through the bus control
framework and can be removed from the generic bus structure.

Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
 lib/librte_eal/common/include/rte_bus.h | 33 +++++++++------------------------
 1 file changed, 9 insertions(+), 24 deletions(-)
diff mbox

Patch

diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h
index bb02d9d..1cae96e 100644
--- a/lib/librte_eal/common/include/rte_bus.h
+++ b/lib/librte_eal/common/include/rte_bus.h
@@ -227,19 +227,6 @@  typedef rte_bus_ctrl_t (*rte_bus_ctrl_get_t)(enum rte_bus_ctrl_op op,
 					     enum rte_bus_ctrl_item item);
 
 /**
- * Get common iommu class of the all the devices on the bus. The bus may
- * check that those devices are attached to iommu driver.
- * If no devices are attached to the bus. The bus may return with don't care
- * (_DC) value.
- * Otherwise, The bus will return appropriate _pa or _va iova mode.
- *
- * @return
- *      enum rte_iova_mode value.
- */
-typedef enum rte_iova_mode (*rte_bus_get_iommu_class_t)(void);
-
-
-/**
  * A structure describing a generic bus.
  */
 struct rte_bus {
@@ -251,7 +238,6 @@  struct rte_bus {
 	rte_bus_plug_t plug;         /**< Probe single device for drivers */
 	rte_bus_unplug_t unplug;     /**< Remove single device from driver */
 	rte_bus_parse_t parse;       /**< Parse a device name */
-	rte_bus_get_iommu_class_t get_iommu_class; /**< Get iommu class */
 	rte_bus_ctrl_get_t ctrl;     /**< Get control operators */
 };
 
@@ -309,6 +295,15 @@  int rte_bus_probe_mode_set(const char *busname,
 			   enum rte_bus_probe_mode mode);
 
 /**
+ * Get the common iommu class of devices bound on to buses available in the
+ * system. The default mode is PA.
+ *
+ * @return
+ *     enum rte_iova_mode value.
+ */
+enum rte_iova_mode rte_bus_get_iommu_class(void);
+
+/**
  * Dump information of all the buses registered with EAL.
  *
  * @param f
@@ -368,16 +363,6 @@  struct rte_bus *rte_bus_find_by_device(const struct rte_device *dev);
  */
 struct rte_bus *rte_bus_find_by_name(const char *busname);
 
-
-/**
- * Get the common iommu class of devices bound on to buses available in the
- * system. The default mode is PA.
- *
- * @return
- *     enum rte_iova_mode value.
- */
-enum rte_iova_mode rte_bus_get_iommu_class(void);
-
 /**
  * Helper for Bus registration.
  * The constructor has higher priority than PMD constructors.