[dpdk-dev,v5,17/20] bus/pci: do not expose PCI match function

Message ID 56eef3f6a2f72057c8e932314d39d06f247b5ba1.1507804944.git.gaetan.rivet@6wind.com (mailing list archive)
State Superseded, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply patch file failure

Commit Message

Gaëtan Rivet Oct. 12, 2017, 10:45 a.m. UTC
  This function is private to the PCI bus.

Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
 drivers/bus/pci/include/rte_bus_pci.h           | 16 ----------------
 drivers/bus/pci/private.h                       | 15 +++++++++++++++
 lib/librte_eal/bsdapp/eal/rte_eal_version.map   |  1 -
 lib/librte_eal/linuxapp/eal/rte_eal_version.map |  1 -
 4 files changed, 15 insertions(+), 18 deletions(-)
  

Patch

diff --git a/drivers/bus/pci/include/rte_bus_pci.h b/drivers/bus/pci/include/rte_bus_pci.h
index d188353..f0a3b37 100644
--- a/drivers/bus/pci/include/rte_bus_pci.h
+++ b/drivers/bus/pci/include/rte_bus_pci.h
@@ -170,22 +170,6 @@  struct rte_pci_bus {
 /** Device driver supports IOVA as VA */
 #define RTE_PCI_DRV_IOVA_AS_VA 0X0040
 
-/*
- * Match the PCI Driver and Device using the ID Table
- *
- * @param pci_drv
- *      PCI driver from which ID table would be extracted
- * @param pci_dev
- *      PCI device to match against the driver
- * @return
- *      1 for successful match
- *      0 for unsuccessful match
- */
-int
-rte_pci_match(const struct rte_pci_driver *pci_drv,
-	      const struct rte_pci_device *pci_dev);
-
-
 /**
  * Get iommu class of PCI devices on the bus.
  * And return their preferred iova mapping mode.
diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h
index 455c81d..b91217b 100644
--- a/drivers/bus/pci/private.h
+++ b/drivers/bus/pci/private.h
@@ -220,4 +220,19 @@  void pci_uio_free_resource(struct rte_pci_device *dev,
 int pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx,
 		struct mapped_pci_resource *uio_res, int map_idx);
 
+/*
+ * Match the PCI Driver and Device using the ID Table
+ *
+ * @param pci_drv
+ *      PCI driver from which ID table would be extracted
+ * @param pci_dev
+ *      PCI device to match against the driver
+ * @return
+ *      1 for successful match
+ *      0 for unsuccessful match
+ */
+int
+rte_pci_match(const struct rte_pci_driver *pci_drv,
+	      const struct rte_pci_device *pci_dev);
+
 #endif /* _PCI_PRIVATE_H_ */
diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
index 97b3918..1c18ca5 100644
--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
@@ -229,6 +229,5 @@  DPDK_17.11 {
 	rte_eal_mbuf_default_mempool_ops;
 	rte_lcore_has_role;
 	rte_pci_get_iommu_class;
-	rte_pci_match;
 
 } DPDK_17.08;
diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
index a8ea4ea..827bcd4 100644
--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
@@ -233,6 +233,5 @@  DPDK_17.11 {
 	rte_eal_mbuf_default_mempool_ops;
 	rte_lcore_has_role;
 	rte_pci_get_iommu_class;
-	rte_pci_match;
 
 } DPDK_17.08;