diff mbox

[dpdk-dev] Shared compilation issue - mempool/octeontx: add build and log infrastructure

Message ID AM2PR04MB075314916204A5B2C9AB62DF89490@AM2PR04MB0753.eurprd04.prod.outlook.com (mailing list archive)
State Not Applicable, archived
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Hemant Agrawal Oct. 14, 2017, 6:07 a.m. UTC 
  Santosh/jerin,
	Your patch "mempool/octeontx: add build and log infrastructure" is causing shared build failure for NXP's patch "event/dpaa2: support event eth adapter", which is still under review.
http://dpdk.org/dev/patchwork/patch/30248/

In your patch, you have added mempool to be dependent on event, which is not correct.

"+DEPDIRS-mempool := bus event"

Ideally, if you have common code, you should put that in bus or mempool . This way you can make event, net or sec etc dependent on bus or mempool  and not the otherway around.

With the addition of ethernet adapter in the eventdev, eventdev drivers have dependency on the net driver. 
e.g dpaa2 event dev  is  dependent on dpaa2 net driver, but your patch causes cyclic dependency. 
You may also face this issue, once you implement the ethernet adapter support in eventdev. 

Please look into this issue.  

I suggest you to move the common code to mempool itself or to bus. 


Regards,
Hemant
diff mbox

Patch

diff --git a/drivers/Makefile b/drivers/Makefile
index 7fef66d..bc2d082 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -32,13 +32,13 @@ 
 include $(RTE_SDK)/mk/rte.vars.mk

 DIRS-y += bus
+DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
+DEPDIRS-event := bus
 DIRS-y += mempool
-DEPDIRS-mempool := bus
+DEPDIRS-mempool := bus event
 DIRS-y += net
 DEPDIRS-net := bus mempool
 DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto
 DEPDIRS-crypto := mempool
-DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
-DEPDIRS-event := bus