diff mbox

[dpdk-dev,01/11] examples/ipsec-secgw: updated MAINTAINERS file

Message ID 1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il (mailing list archive)
State Changes Requested, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Aviad Yehezkel Oct. 14, 2017, 1:27 p.m. UTC 
  From: Aviad Yehezkel <aviadye@mellanox.com>

As agreed with Sergio and Pablo

Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Aviad Yehezkel Oct. 15, 2017, 12:53 p.m. UTC | #1 
On 10/14/2017 4:27 PM, aviadye@dev.mellanox.co.il wrote:
> From: Aviad Yehezkel <aviadye@mellanox.com>
>
> As agreed with Sergio and Pablo
>
> Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c00d6d8..d814ac1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -919,6 +919,7 @@ F: examples/helloworld/
>   F: doc/guides/sample_app_ug/hello_world.rst
>   
>   M: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> +M: Aviad Shaul Yehezkel <aviadye@mellanox.com>
>   F: examples/ipsec-secgw/
>   F: doc/guides/sample_app_ug/ipsec_secgw.rst
>   

Tested-by: Aviad Yehezkel <aviadye@mellanox.com>
De Lara Guarch, Pablo Oct. 16, 2017, 7:33 a.m. UTC | #2 
Hi Aviad,

> -----Original Message-----

> From: Aviad Yehezkel [mailto:aviadye@dev.mellanox.co.il]

> Sent: Sunday, October 15, 2017 1:54 PM

> To: dev@dpdk.org; Gonzalez Monroy, Sergio

> <sergio.gonzalez.monroy@intel.com>; De Lara Guarch, Pablo

> <pablo.de.lara.guarch@intel.com>; aviadye@mellanox.com

> Cc: borisp@mellanox.com; akhil.goyal@nxp.com;

> hemant.agrawal@nxp.com; Nicolau, Radu <radu.nicolau@intel.com>;

> Doherty, Declan <declan.doherty@intel.com>; liranl@mellanox.com;

> nelio.laranjeiro@6wind.com; thomas@monjalon.net

> Subject: Re: [dpdk-dev][PATCH 01/11] examples/ipsec-secgw: updated

> MAINTAINERS file

> 

> 

> 

> On 10/14/2017 4:27 PM, aviadye@dev.mellanox.co.il wrote:

> > From: Aviad Yehezkel <aviadye@mellanox.com>

> >

> > As agreed with Sergio and Pablo

> >

> > Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>

> > ---

> >   MAINTAINERS | 1 +

> >   1 file changed, 1 insertion(+)

> >

> > diff --git a/MAINTAINERS b/MAINTAINERS index c00d6d8..d814ac1

> 100644

> > --- a/MAINTAINERS

> > +++ b/MAINTAINERS

> > @@ -919,6 +919,7 @@ F: examples/helloworld/

> >   F: doc/guides/sample_app_ug/hello_world.rst

> >

> >   M: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

> > +M: Aviad Shaul Yehezkel <aviadye@mellanox.com>

> >   F: examples/ipsec-secgw/

> >   F: doc/guides/sample_app_ug/ipsec_secgw.rst

> >

> 

> Tested-by: Aviad Yehezkel <aviadye@mellanox.com>


"Tested" tag does not make sense here. Also, for patches where
you are the author, you are not expected to reply to those patches.
It is expected that, being the author, you have verified that the patch works.

So, the tags "Reviewed-by", "Acked-by" and "Tested-by" have to be used
by the rest of the community.

Thanks,
Pablo
Sergio Gonzalez Monroy Oct. 16, 2017, 9:27 a.m. UTC | #3 
Hi Aviad,

On 14/10/2017 14:27, aviadye@dev.mellanox.co.il wrote:
> From: Aviad Yehezkel <aviadye@mellanox.com>
>
> As agreed with Sergio and Pablo

I don't think the commit message is relevant.
Either me or Pablo acking the patch would have the same meaning.

Thanks,
Sergio

> Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c00d6d8..d814ac1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -919,6 +919,7 @@ F: examples/helloworld/
>   F: doc/guides/sample_app_ug/hello_world.rst
>   
>   M: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> +M: Aviad Shaul Yehezkel <aviadye@mellanox.com>
>   F: examples/ipsec-secgw/
>   F: doc/guides/sample_app_ug/ipsec_secgw.rst
>
Aviad Yehezkel Oct. 16, 2017, 10:43 a.m. UTC | #4 
On 10/16/2017 12:27 PM, Sergio Gonzalez Monroy wrote:
> Hi Aviad,
>
> On 14/10/2017 14:27, aviadye@dev.mellanox.co.il wrote:
>> From: Aviad Yehezkel <aviadye@mellanox.com>
>>
>> As agreed with Sergio and Pablo
>
> I don't think the commit message is relevant.
> Either me or Pablo acking the patch would have the same meaning.
>
> Thanks,
> Sergio

Will fix.

Thanks,
Aviad.

>> Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index c00d6d8..d814ac1 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -919,6 +919,7 @@ F: examples/helloworld/
>>   F: doc/guides/sample_app_ug/hello_world.rst
>>     M: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
>> +M: Aviad Shaul Yehezkel <aviadye@mellanox.com>
>>   F: examples/ipsec-secgw/
>>   F: doc/guides/sample_app_ug/ipsec_secgw.rst
>
>
De Lara Guarch, Pablo Oct. 16, 2017, 1:39 p.m. UTC | #5 
Hi Aviad,

> -----Original Message-----

> From: Aviad Yehezkel [mailto:aviadye@dev.mellanox.co.il]

> Sent: Monday, October 16, 2017 11:44 AM

> To: Gonzalez Monroy, Sergio <sergio.gonzalez.monroy@intel.com>;

> dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;

> aviadye@mellanox.com

> Cc: borisp@mellanox.com; akhil.goyal@nxp.com;

> hemant.agrawal@nxp.com; Nicolau, Radu <radu.nicolau@intel.com>;

> Doherty, Declan <declan.doherty@intel.com>; liranl@mellanox.com;

> nelio.laranjeiro@6wind.com; thomas@monjalon.net

> Subject: Re: [dpdk-dev][PATCH 01/11] examples/ipsec-secgw: updated

> MAINTAINERS file

> 

> 

> 

> On 10/16/2017 12:27 PM, Sergio Gonzalez Monroy wrote:

> > Hi Aviad,

> >

> > On 14/10/2017 14:27, aviadye@dev.mellanox.co.il wrote:

> >> From: Aviad Yehezkel <aviadye@mellanox.com>

> >>

> >> As agreed with Sergio and Pablo

> >

> > I don't think the commit message is relevant.

> > Either me or Pablo acking the patch would have the same meaning.

> >

> > Thanks,

> > Sergio

> 

> Will fix.


Actually, it is too early for you to take ownership on this app,
as you have recently started contributing to DPDK, so I have to NACK this patch.
Sorry for the confusion.

Said that, anyone from the rest of the developers of rte_security (with past contributions)
that would like to volunteer to maintain this app?

Thanks,
Pablo

> 

> Thanks,

> Aviad.
Hemant Agrawal Oct. 17, 2017, 12:36 p.m. UTC | #6 
On 10/16/2017 7:09 PM, De Lara Guarch, Pablo wrote:
> Hi Aviad,
>
>> -----Original Message-----
>> From: Aviad Yehezkel [mailto:aviadye@dev.mellanox.co.il]
>> Sent: Monday, October 16, 2017 11:44 AM
>> To: Gonzalez Monroy, Sergio <sergio.gonzalez.monroy@intel.com>;
>> dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
>> aviadye@mellanox.com
>> Cc: borisp@mellanox.com; akhil.goyal@nxp.com;
>> hemant.agrawal@nxp.com; Nicolau, Radu <radu.nicolau@intel.com>;
>> Doherty, Declan <declan.doherty@intel.com>; liranl@mellanox.com;
>> nelio.laranjeiro@6wind.com; thomas@monjalon.net
>> Subject: Re: [dpdk-dev][PATCH 01/11] examples/ipsec-secgw: updated
>> MAINTAINERS file
>>
>>
>>
>> On 10/16/2017 12:27 PM, Sergio Gonzalez Monroy wrote:
>>> Hi Aviad,
>>>
>>> On 14/10/2017 14:27, aviadye@dev.mellanox.co.il wrote:
>>>> From: Aviad Yehezkel <aviadye@mellanox.com>
>>>>
>>>> As agreed with Sergio and Pablo
>>>
>>> I don't think the commit message is relevant.
>>> Either me or Pablo acking the patch would have the same meaning.
>>>
>>> Thanks,
>>> Sergio
>>
>> Will fix.
>
> Actually, it is too early for you to take ownership on this app,
> as you have recently started contributing to DPDK, so I have to NACK this patch.
> Sorry for the confusion.
>
> Said that, anyone from the rest of the developers of rte_security (with past contributions)
> that would like to volunteer to maintain this app?
>

I want to ask Akhil, if he agrees to commit time to do this work?

Regards,
Hemant

> Thanks,
> Pablo
>
>>
>> Thanks,
>> Aviad.
>
De Lara Guarch, Pablo Oct. 17, 2017, 1:17 p.m. UTC | #7 
> -----Original Message-----

> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]

> Sent: Tuesday, October 17, 2017 1:37 PM

> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Aviad

> Yehezkel <aviadye@dev.mellanox.co.il>; Gonzalez Monroy, Sergio

> <sergio.gonzalez.monroy@intel.com>; dev@dpdk.org;

> aviadye@mellanox.com

> Cc: borisp@mellanox.com; akhil.goyal@nxp.com; Nicolau, Radu

> <radu.nicolau@intel.com>; Doherty, Declan <declan.doherty@intel.com>;

> liranl@mellanox.com; nelio.laranjeiro@6wind.com; thomas@monjalon.net

> Subject: Re: [PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS

> file

> 

> On 10/16/2017 7:09 PM, De Lara Guarch, Pablo wrote:

> > Hi Aviad,

> >

> >> -----Original Message-----

> >> From: Aviad Yehezkel [mailto:aviadye@dev.mellanox.co.il]

> >> Sent: Monday, October 16, 2017 11:44 AM

> >> To: Gonzalez Monroy, Sergio <sergio.gonzalez.monroy@intel.com>;

> >> dev@dpdk.org; De Lara Guarch, Pablo

> <pablo.de.lara.guarch@intel.com>;

> >> aviadye@mellanox.com

> >> Cc: borisp@mellanox.com; akhil.goyal@nxp.com;

> hemant.agrawal@nxp.com;

> >> Nicolau, Radu <radu.nicolau@intel.com>; Doherty, Declan

> >> <declan.doherty@intel.com>; liranl@mellanox.com;

> >> nelio.laranjeiro@6wind.com; thomas@monjalon.net

> >> Subject: Re: [dpdk-dev][PATCH 01/11] examples/ipsec-secgw: updated

> >> MAINTAINERS file

> >>

> >>

> >>

> >> On 10/16/2017 12:27 PM, Sergio Gonzalez Monroy wrote:

> >>> Hi Aviad,

> >>>

> >>> On 14/10/2017 14:27, aviadye@dev.mellanox.co.il wrote:

> >>>> From: Aviad Yehezkel <aviadye@mellanox.com>

> >>>>

> >>>> As agreed with Sergio and Pablo

> >>>

> >>> I don't think the commit message is relevant.

> >>> Either me or Pablo acking the patch would have the same meaning.

> >>>

> >>> Thanks,

> >>> Sergio

> >>

> >> Will fix.

> >

> > Actually, it is too early for you to take ownership on this app, as

> > you have recently started contributing to DPDK, so I have to NACK this

> patch.

> > Sorry for the confusion.

> >

> > Said that, anyone from the rest of the developers of rte_security

> > (with past contributions) that would like to volunteer to maintain this

> app?

> >

> 

> I want to ask Akhil, if he agrees to commit time to do this work?


I would support that decision :)

Thanks,
Pablo

> 

> Regards,

> Hemant

> 

> > Thanks,

> > Pablo

> >

> >>

> >> Thanks,

> >> Aviad.

> >
Akhil Goyal Oct. 21, 2017, 5:12 p.m. UTC | #8 
On 10/17/2017 6:47 PM, De Lara Guarch, Pablo wrote:
> 
> 
>> -----Original Message-----
>> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
>> Sent: Tuesday, October 17, 2017 1:37 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Aviad
>> Yehezkel <aviadye@dev.mellanox.co.il>; Gonzalez Monroy, Sergio
>> <sergio.gonzalez.monroy@intel.com>; dev@dpdk.org;
>> aviadye@mellanox.com
>> Cc: borisp@mellanox.com; akhil.goyal@nxp.com; Nicolau, Radu
>> <radu.nicolau@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
>> liranl@mellanox.com; nelio.laranjeiro@6wind.com; thomas@monjalon.net
>> Subject: Re: [PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS
>> file
>>
>> On 10/16/2017 7:09 PM, De Lara Guarch, Pablo wrote:
>>> Hi Aviad,
>>>
>>>> -----Original Message-----
>>>> From: Aviad Yehezkel [mailto:aviadye@dev.mellanox.co.il]
>>>> Sent: Monday, October 16, 2017 11:44 AM
>>>> To: Gonzalez Monroy, Sergio <sergio.gonzalez.monroy@intel.com>;
>>>> dev@dpdk.org; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>;
>>>> aviadye@mellanox.com
>>>> Cc: borisp@mellanox.com; akhil.goyal@nxp.com;
>> hemant.agrawal@nxp.com;
>>>> Nicolau, Radu <radu.nicolau@intel.com>; Doherty, Declan
>>>> <declan.doherty@intel.com>; liranl@mellanox.com;
>>>> nelio.laranjeiro@6wind.com; thomas@monjalon.net
>>>> Subject: Re: [dpdk-dev][PATCH 01/11] examples/ipsec-secgw: updated
>>>> MAINTAINERS file
>>>>
>>>>
>>>>
>>>> On 10/16/2017 12:27 PM, Sergio Gonzalez Monroy wrote:
>>>>> Hi Aviad,
>>>>>
>>>>> On 14/10/2017 14:27, aviadye@dev.mellanox.co.il wrote:
>>>>>> From: Aviad Yehezkel <aviadye@mellanox.com>
>>>>>>
>>>>>> As agreed with Sergio and Pablo
>>>>>
>>>>> I don't think the commit message is relevant.
>>>>> Either me or Pablo acking the patch would have the same meaning.
>>>>>
>>>>> Thanks,
>>>>> Sergio
>>>>
>>>> Will fix.
>>>
>>> Actually, it is too early for you to take ownership on this app, as
>>> you have recently started contributing to DPDK, so I have to NACK this
>> patch.
>>> Sorry for the confusion.
>>>
>>> Said that, anyone from the rest of the developers of rte_security
>>> (with past contributions) that would like to volunteer to maintain this
>> app?
>>>
>>
>> I want to ask Akhil, if he agrees to commit time to do this work?
I can, but I think Radu is already added as a co maintainer.

> 
> I would support that decision :)
> 
Thanks for your support Pablo.

-Akhil
Sergio Gonzalez Monroy Oct. 23, 2017, 8:32 a.m. UTC | #9 
On 21/10/2017 18:12, Akhil Goyal wrote:
> On 10/17/2017 6:47 PM, De Lara Guarch, Pablo wrote:
>>
>>
>>> -----Original Message-----
>>> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
>>> Sent: Tuesday, October 17, 2017 1:37 PM
>>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Aviad
>>> Yehezkel <aviadye@dev.mellanox.co.il>; Gonzalez Monroy, Sergio
>>> <sergio.gonzalez.monroy@intel.com>; dev@dpdk.org;
>>> aviadye@mellanox.com
>>> Cc: borisp@mellanox.com; akhil.goyal@nxp.com; Nicolau, Radu
>>> <radu.nicolau@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
>>> liranl@mellanox.com; nelio.laranjeiro@6wind.com; thomas@monjalon.net
>>> Subject: Re: [PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS
>>> file
>>>
>>> On 10/16/2017 7:09 PM, De Lara Guarch, Pablo wrote:
>>>> Hi Aviad,
>>>>
>>>>> -----Original Message-----
>>>>> From: Aviad Yehezkel [mailto:aviadye@dev.mellanox.co.il]
>>>>> Sent: Monday, October 16, 2017 11:44 AM
>>>>> To: Gonzalez Monroy, Sergio <sergio.gonzalez.monroy@intel.com>;
>>>>> dev@dpdk.org; De Lara Guarch, Pablo
>>> <pablo.de.lara.guarch@intel.com>;
>>>>> aviadye@mellanox.com
>>>>> Cc: borisp@mellanox.com; akhil.goyal@nxp.com;
>>> hemant.agrawal@nxp.com;
>>>>> Nicolau, Radu <radu.nicolau@intel.com>; Doherty, Declan
>>>>> <declan.doherty@intel.com>; liranl@mellanox.com;
>>>>> nelio.laranjeiro@6wind.com; thomas@monjalon.net
>>>>> Subject: Re: [dpdk-dev][PATCH 01/11] examples/ipsec-secgw: updated
>>>>> MAINTAINERS file
>>>>>
>>>>>
>>>>>
>>>>> On 10/16/2017 12:27 PM, Sergio Gonzalez Monroy wrote:
>>>>>> Hi Aviad,
>>>>>>
>>>>>> On 14/10/2017 14:27, aviadye@dev.mellanox.co.il wrote:
>>>>>>> From: Aviad Yehezkel <aviadye@mellanox.com>
>>>>>>>
>>>>>>> As agreed with Sergio and Pablo
>>>>>>
>>>>>> I don't think the commit message is relevant.
>>>>>> Either me or Pablo acking the patch would have the same meaning.
>>>>>>
>>>>>> Thanks,
>>>>>> Sergio
>>>>>
>>>>> Will fix.
>>>>
>>>> Actually, it is too early for you to take ownership on this app, as
>>>> you have recently started contributing to DPDK, so I have to NACK this
>>> patch.
>>>> Sorry for the confusion.
>>>>
>>>> Said that, anyone from the rest of the developers of rte_security
>>>> (with past contributions) that would like to volunteer to maintain 
>>>> this
>>> app?
>>>>
>>>
>>> I want to ask Akhil, if he agrees to commit time to do this work?
> I can, but I think Radu is already added as a co maintainer.
>

No issue with having another co-maintainer.

Thanks,
Sergio

>>
>> I would support that decision :)
>>
> Thanks for your support Pablo.
>
> -Akhil
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index c00d6d8..d814ac1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -919,6 +919,7 @@  F: examples/helloworld/
 F: doc/guides/sample_app_ug/hello_world.rst
 
 M: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
+M: Aviad Shaul Yehezkel <aviadye@mellanox.com>
 F: examples/ipsec-secgw/
 F: doc/guides/sample_app_ug/ipsec_secgw.rst