[dpdk-dev,04/11] examples/ipsec-secgw: Fix aad_len for for aes-gcm support

Message ID 1507987683-12315-4-git-send-email-aviadye@dev.mellanox.co.il (mailing list archive)
State Changes Requested, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Aviad Yehezkel Oct. 14, 2017, 1:27 p.m. UTC
  From: Aviad Yehezkel <aviadye@mellanox.com>

This cause auth failure issue
Seems like this was broken for aes-gcm for a long time

Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
---
 examples/ipsec-secgw/sa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Aviad Yehezkel Oct. 15, 2017, 12:54 p.m. UTC | #1
On 10/14/2017 4:27 PM, aviadye@dev.mellanox.co.il wrote:
> From: Aviad Yehezkel <aviadye@mellanox.com>
>
> This cause auth failure issue
> Seems like this was broken for aes-gcm for a long time
>
> Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
> ---
>   examples/ipsec-secgw/sa.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
> index 7be0e62..ef94475 100644
> --- a/examples/ipsec-secgw/sa.c
> +++ b/examples/ipsec-secgw/sa.c
> @@ -431,7 +431,7 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,
>   			rule->aead_algo = algo->algo;
>   			rule->cipher_key_len = algo->key_len;
>   			rule->digest_len = algo->digest_len;
> -			rule->aad_len = algo->key_len;
> +			rule->aad_len = algo->aad_len;
>   			rule->block_size = algo->block_size;
>   			rule->iv_len = algo->iv_len;
>   

Tested-by: Aviad Yehezkel <aviadye@mellanox.com>
  

Patch

diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index 7be0e62..ef94475 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -431,7 +431,7 @@  parse_sa_tokens(char **tokens, uint32_t n_tokens,
 			rule->aead_algo = algo->algo;
 			rule->cipher_key_len = algo->key_len;
 			rule->digest_len = algo->digest_len;
-			rule->aad_len = algo->key_len;
+			rule->aad_len = algo->aad_len;
 			rule->block_size = algo->block_size;
 			rule->iv_len = algo->iv_len;