diff mbox

[dpdk-dev,v3] doc: add virtio lsc note

Message ID 20171016054121.1031-1-zhiyong.yang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Yuanhan Liu
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Yang, Zhiyong Oct. 16, 2017, 5:41 a.m. UTC 
  Virtio PMD already has supported link status change(lsc), but VM which
must be created by qemu 2.7.0 and above can support it when vhost
user disconnects, since the capability to detect vhost user disconnection
is introduced in qemu 2.7.0. The patch updates doc to let user know that.

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Reviewed-by: John McNamara <john.mcnamara@intel.com>
---
 doc/guides/nics/virtio.rst | 7 +++++++
 1 file changed, 7 insertions(+)

Changes in v3:
Add a blank line and indent, and text is minor changed according to John's
comments.

Changes in v2:
reword the doc and commit log.

Comments

John McNamara Oct. 16, 2017, 7:10 p.m. UTC | #1 
> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Monday, October 16, 2017 6:41 AM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; yliu@fridaylinux.org;
> Mcnamara, John <john.mcnamara@intel.com>; Yang, Zhiyong
> <zhiyong.yang@intel.com>
> Subject: [PATCH v3] doc: add virtio lsc note
> 
> Virtio PMD already has supported link status change(lsc), but VM which
> must be created by qemu 2.7.0 and above can support it when vhost user
> disconnects, since the capability to detect vhost user disconnection is
> introduced in qemu 2.7.0. The patch updates doc to let user know that.
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Reviewed-by: John McNamara <john.mcnamara@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>
Yuanhan Liu Oct. 20, 2017, 11:50 a.m. UTC | #2 
On Mon, Oct 16, 2017 at 07:10:24PM +0000, Mcnamara, John wrote:
> 
> 
> > -----Original Message-----
> > From: Yang, Zhiyong
> > Sent: Monday, October 16, 2017 6:41 AM
> > To: dev@dpdk.org
> > Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; yliu@fridaylinux.org;
> > Mcnamara, John <john.mcnamara@intel.com>; Yang, Zhiyong
> > <zhiyong.yang@intel.com>
> > Subject: [PATCH v3] doc: add virtio lsc note
> > 
> > Virtio PMD already has supported link status change(lsc), but VM which
> > must be created by qemu 2.7.0 and above can support it when vhost user
> > disconnects, since the capability to detect vhost user disconnection is
> > introduced in qemu 2.7.0. The patch updates doc to let user know that.
> > 
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> > Reviewed-by: John McNamara <john.mcnamara@intel.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>
> 

Applied to dpdk-next-virtio.

Thanks.

	--yliu
diff mbox

Patch

diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
index 4d6a83768..af82f86e4 100644
--- a/doc/guides/nics/virtio.rst
+++ b/doc/guides/nics/virtio.rst
@@ -291,6 +291,13 @@  interrupt, Rx interrupts, and Tx interrupts. Config interrupt is used for
 notification of device configuration changes, especially link status (lsc).
 Interrupt mode is translated into Rx interrupts in the context of DPDK.
 
+.. Note::
+
+   Virtio PMD already has support for receiving lsc from qemu when the link
+   status changes, especially when vhost user disconnects. However, it fails
+   to do that if the VM is created by qemu 2.6.2 or below, since the
+   capability to detect vhost user disconnection is introduced in qemu 2.7.0.
+
 Prerequisites for Rx interrupts
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~