diff mbox

[dpdk-dev,v2,1/1] cryptodev: fix build with Ofast.

Message ID 1508249706-14827-1-git-send-email-ian.stokes@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ian Stokes Oct. 17, 2017, 2:15 p.m. UTC 
  When compiling with an application that includes rte_cryptodev.h with
Ofast, an error is reported regarding enumeration
RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in function
 __rte_crypto_op_reset().

Fix this by adding a case for RTE_CRYPTO_OP_TYPE_UNDEFINED.

Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op
oriented")

Signed-off-by: Ian Stokes <ian.stokes@intel.com>
---
 lib/librte_cryptodev/rte_crypto.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

De Lara Guarch, Pablo Oct. 17, 2017, 3:13 p.m. UTC | #1 
> -----Original Message-----
> From: Stokes, Ian
> Sent: Tuesday, October 17, 2017 3:15 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stokes, Ian
> <ian.stokes@intel.com>
> Subject: [PATCH v2 1/1] cryptodev: fix build with Ofast.
> 
> When compiling with an application that includes rte_cryptodev.h with
> Ofast, an error is reported regarding enumeration
> RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in function
> __rte_crypto_op_reset().
> 
> Fix this by adding a case for RTE_CRYPTO_OP_TYPE_UNDEFINED.
> 
> Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op
> oriented")
> 
> Signed-off-by: Ian Stokes <ian.stokes@intel.com>

Oh, and also CC stable :) I will do it for you.

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Ian Stokes Oct. 17, 2017, 3:16 p.m. UTC | #2 
> > -----Original Message-----
> > From: Stokes, Ian
> > Sent: Tuesday, October 17, 2017 3:15 PM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stokes,
> > Ian <ian.stokes@intel.com>
> > Subject: [PATCH v2 1/1] cryptodev: fix build with Ofast.
> >
> > When compiling with an application that includes rte_cryptodev.h with
> > Ofast, an error is reported regarding enumeration
> > RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in function
> > __rte_crypto_op_reset().
> >
> > Fix this by adding a case for RTE_CRYPTO_OP_TYPE_UNDEFINED.
> >
> > Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op
> > oriented")
> >
> > Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> 
> Oh, and also CC stable :) I will do it for you.

Apologies Pablo, thanks for this.

Ian
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
De Lara Guarch, Pablo Oct. 19, 2017, 7:11 p.m. UTC | #3 
> -----Original Message-----
> From: Stokes, Ian
> Sent: Tuesday, October 17, 2017 4:17 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH v2 1/1] cryptodev: fix build with Ofast.
> 
> > > -----Original Message-----
> > > From: Stokes, Ian
> > > Sent: Tuesday, October 17, 2017 3:15 PM
> > > To: dev@dpdk.org
> > > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Stokes,
> > > Ian <ian.stokes@intel.com>
> > > Subject: [PATCH v2 1/1] cryptodev: fix build with Ofast.
> > >
> > > When compiling with an application that includes rte_cryptodev.h
> > > with Ofast, an error is reported regarding enumeration
> > > RTE_CRYPTO_OP_TYPE_UNDEFINED not handled in switch case in
> function
> > > __rte_crypto_op_reset().
> > >
> > > Fix this by adding a case for RTE_CRYPTO_OP_TYPE_UNDEFINED.
> > >
> > > Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op
> > > oriented")
> > >
> > > Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> >
> > Oh, and also CC stable :) I will do it for you.
> 
> Apologies Pablo, thanks for this.
> 
> Ian
> >
> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto.
Thanks,

Pablo
diff mbox

Patch

diff --git a/lib/librte_cryptodev/rte_crypto.h b/lib/librte_cryptodev/rte_crypto.h
index 10fe080..3ef9e41 100644
--- a/lib/librte_cryptodev/rte_crypto.h
+++ b/lib/librte_cryptodev/rte_crypto.h
@@ -144,6 +144,7 @@  struct rte_crypto_op {
 	case RTE_CRYPTO_OP_TYPE_SYMMETRIC:
 		__rte_crypto_sym_op_reset(op->sym);
 		break;
+	case RTE_CRYPTO_OP_TYPE_UNDEFINED:
 	default:
 		break;
 	}