diff mbox

[dpdk-dev,3/8] app/eventdev: add pktmbuf pool for ethdev

Message ID 1508330348-30060-4-git-send-email-pbhagavatula@caviumnetworks.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply patch file failure

Commit Message

Pavan Nikhilesh Oct. 18, 2017, 12:39 p.m. UTC 
  Add pktmbuf pool creation used when configuring ethernet device as event
producer.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 app/test-eventdev/test_perf_common.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

Comments

Jerin Jacob Dec. 10, 2017, 12:01 p.m. UTC | #1 
-----Original Message-----
> Date: Wed, 18 Oct 2017 18:09:03 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: bruce.richardson@intel.com, harry.van.haaren@intel.com,
>  gage.eads@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com,
>  nikhil.rao@intel.com, santosh.shukla@caviumnetworks.com,
>  jerin.jacob@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [PATCH 3/8] app/eventdev: add pktmbuf pool for ethdev
> X-Mailer: git-send-email 2.7.4
> 
> Add pktmbuf pool creation used when configuring ethernet device as event
> producer.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>  app/test-eventdev/test_perf_common.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
> index f7961be..b26d694 100644
> --- a/app/test-eventdev/test_perf_common.c
> +++ b/app/test-eventdev/test_perf_common.c
> @@ -413,13 +413,24 @@ perf_mempool_setup(struct evt_test *test, struct evt_options *opt)
>  {
>  	struct test_perf *t = evt_test_priv(test);
>  
> -	t->pool = rte_mempool_create(test->name, /* mempool name */
> +	if (opt->prod_type == EVT_PROD_TYPE_SYNT) {
> +		t->pool = rte_mempool_create(test->name, /* mempool name */
>  				opt->pool_sz, /* number of elements*/
>  				sizeof(struct perf_elt), /* element size*/
>  				512, /* cache size*/
>  				0, NULL, NULL,
>  				perf_elt_init, /* obj constructor */
>  				NULL, opt->socket_id, 0); /* flags */
> +	} else {
> +		t->pool = rte_pktmbuf_pool_create(test->name, /* mempool name */
> +				opt->pool_sz, /* number of elements*/
> +				0, /* cache size*/

Please change the cache size to 512.

With above change:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> +				0,
> +				RTE_MBUF_DEFAULT_BUF_SIZE,
> +				opt->socket_id); /* flags */
> +
> +	}
> +
>  	if (t->pool == NULL) {
>  		evt_err("failed to create mempool");
>  		return -ENOMEM;
> -- 
> 2.7.4
>
diff mbox

Patch

diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
index f7961be..b26d694 100644
--- a/app/test-eventdev/test_perf_common.c
+++ b/app/test-eventdev/test_perf_common.c
@@ -413,13 +413,24 @@  perf_mempool_setup(struct evt_test *test, struct evt_options *opt)
 {
 	struct test_perf *t = evt_test_priv(test);
 
-	t->pool = rte_mempool_create(test->name, /* mempool name */
+	if (opt->prod_type == EVT_PROD_TYPE_SYNT) {
+		t->pool = rte_mempool_create(test->name, /* mempool name */
 				opt->pool_sz, /* number of elements*/
 				sizeof(struct perf_elt), /* element size*/
 				512, /* cache size*/
 				0, NULL, NULL,
 				perf_elt_init, /* obj constructor */
 				NULL, opt->socket_id, 0); /* flags */
+	} else {
+		t->pool = rte_pktmbuf_pool_create(test->name, /* mempool name */
+				opt->pool_sz, /* number of elements*/
+				0, /* cache size*/
+				0,
+				RTE_MBUF_DEFAULT_BUF_SIZE,
+				opt->socket_id); /* flags */
+
+	}
+
 	if (t->pool == NULL) {
 		evt_err("failed to create mempool");
 		return -ENOMEM;