diff mbox

[dpdk-dev] test/mempool_perf: improve default mempool ops selection

Message ID 20171119045531.25165-1-jerin.jacob@caviumnetworks.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jerin Jacob Nov. 19, 2017, 4:55 a.m. UTC 
  Use of rte_eal_mbuf_default_mempool_ops() API will
allow to override pool handler through "--mbuf-pool-ops-name"
eal command line argument.

Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
 test/test/test_mempool_perf.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

Comments

Olivier Matz Dec. 12, 2017, 2:33 p.m. UTC | #1 
On Sun, Nov 19, 2017 at 10:25:31AM +0530, Jerin Jacob wrote:
> Use of rte_eal_mbuf_default_mempool_ops() API will
> allow to override pool handler through "--mbuf-pool-ops-name"
> eal command line argument.
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
>  test/test/test_mempool_perf.c | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)

My checkpatch sees this minor issue:

WARNING:TYPO_SPELLING: 'allow to' may be misspelled -
  perhaps 'allow (without "to", see
  http://english.stackexchange.com/questions/60271/grammatical-complements-for-allow/60285#60285)'?


I don't this it's critical, and the official checkpatch did not see it, so
Acked-by: Olivier Matz <olivier.matz@6wind.com>


Thanks
Santosh Shukla Dec. 12, 2017, 3:12 p.m. UTC | #2 
On Sunday 19 November 2017 10:25 AM, Jerin Jacob wrote:
> Use of rte_eal_mbuf_default_mempool_ops() API will
> allow to override pool handler through "--mbuf-pool-ops-name"
> eal command line argument.
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---

Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Thomas Monjalon Jan. 17, 2018, 11:18 p.m. UTC | #3 
12/12/2017 16:12, santosh:
> 
> On Sunday 19 November 2017 10:25 AM, Jerin Jacob wrote:
> > Use of rte_eal_mbuf_default_mempool_ops() API will
> > allow to override pool handler through "--mbuf-pool-ops-name"
> > eal command line argument.
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> 
> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

Do you know why this patch is set as superseded in patchwork?
Jerin Jacob Jan. 18, 2018, 2:36 a.m. UTC | #4 
-----Original Message-----
> Date: Thu, 18 Jan 2018 00:18:47 +0100
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: dev@dpdk.org, santosh <santosh.shukla@caviumnetworks.com>,
>  olivier.matz@6wind.com
> Subject: Re: [dpdk-dev] [PATCH] test/mempool_perf: improve default mempool
>  ops selection
> 
> 12/12/2017 16:12, santosh:
> > 
> > On Sunday 19 November 2017 10:25 AM, Jerin Jacob wrote:
> > > Use of rte_eal_mbuf_default_mempool_ops() API will
> > > allow to override pool handler through "--mbuf-pool-ops-name"
> > > eal command line argument.
> > >
> > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > ---
> > 
> > Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> 
> Do you know why this patch is set as superseded in patchwork?

Changed back to new as it is intended to be.

It might have updated by mistake for the very similar patch heading
"test/mempool: improve default mempool ops selection"
Thomas Monjalon Jan. 18, 2018, 2:12 p.m. UTC | #5 
12/12/2017 15:33, Olivier MATZ:
> On Sun, Nov 19, 2017 at 10:25:31AM +0530, Jerin Jacob wrote:
> > Use of rte_eal_mbuf_default_mempool_ops() API will
> > allow to override pool handler through "--mbuf-pool-ops-name"
> > eal command line argument.
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >  test/test/test_mempool_perf.c | 15 +++++++--------
> >  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> My checkpatch sees this minor issue:
> 
> WARNING:TYPO_SPELLING: 'allow to' may be misspelled -
>   perhaps 'allow (without "to", see
>   http://english.stackexchange.com/questions/60271/grammatical-complements-for-allow/60285#60285)'?
> 
> 
> I don't this it's critical, and the official checkpatch did not see it, so
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks
diff mbox

Patch

diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c
index 749b364ee..85b9f782d 100644
--- a/test/test/test_mempool_perf.c
+++ b/test/test/test_mempool_perf.c
@@ -313,6 +313,7 @@  test_mempool_perf(void)
 	struct rte_mempool *mp_cache = NULL;
 	struct rte_mempool *mp_nocache = NULL;
 	struct rte_mempool *default_pool = NULL;
+	const char *default_pool_ops;
 	int ret = -1;
 
 	rte_atomic32_init(&synchro);
@@ -336,6 +337,7 @@  test_mempool_perf(void)
 	if (mp_cache == NULL)
 		goto err;
 
+	default_pool_ops = rte_eal_mbuf_default_mempool_ops();
 	/* Create a mempool based on Default handler */
 	default_pool = rte_mempool_create_empty("default_pool",
 						MEMPOOL_SIZE,
@@ -344,21 +346,18 @@  test_mempool_perf(void)
 						SOCKET_ID_ANY, 0);
 
 	if (default_pool == NULL) {
-		printf("cannot allocate %s mempool\n",
-		       RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+		printf("cannot allocate %s mempool\n", default_pool_ops);
 		goto err;
 	}
 
-	if (rte_mempool_set_ops_byname(default_pool,
-				       RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL)
+	if (rte_mempool_set_ops_byname(default_pool, default_pool_ops, NULL)
 				       < 0) {
-		printf("cannot set %s handler\n", RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+		printf("cannot set %s handler\n", default_pool_ops);
 		goto err;
 	}
 
 	if (rte_mempool_populate_default(default_pool) < 0) {
-		printf("cannot populate %s mempool\n",
-		       RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+		printf("cannot populate %s mempool\n", default_pool_ops);
 		goto err;
 	}
 
@@ -378,7 +377,7 @@  test_mempool_perf(void)
 
 	/* performance test with 1, 2 and max cores */
 	printf("start performance test for %s (without cache)\n",
-	       RTE_MBUF_DEFAULT_MEMPOOL_OPS);
+	       default_pool_ops);
 
 	if (do_one_mempool_test(default_pool, 1) < 0)
 		goto err;