[dpdk-dev,2/7] ethdev: fix port id storage
Checks
Commit Message
port_id is now 16bits, update function parameter according.
Fixes: 4c270218aa26 ("ethdev: support security APIs")
Cc: stable@dpdk.org
Cc: declan.doherty@intel.com
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Boris Pismenny <borisp@mellanox.com>
Cc: Aviad Yehezkel <aviadye@mellanox.com>
Cc: Radu Nicolau <radu.nicolau@intel.com>
Cc: Declan Doherty <declan.doherty@intel.com>
---
lib/librte_ether/rte_ethdev.c | 2 +-
lib/librte_ether/rte_ethdev.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Comments
On 12/1/2017 7:59 AM, Ferruh Yigit wrote:
> port_id is now 16bits, update function parameter according.
>
> Fixes: 4c270218aa26 ("ethdev: support security APIs")
> Cc: stable@dpdk.org
> Cc: declan.doherty@intel.com
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Boris Pismenny <borisp@mellanox.com>
> Cc: Aviad Yehezkel <aviadye@mellanox.com>
> Cc: Radu Nicolau <radu.nicolau@intel.com>
> Cc: Declan Doherty <declan.doherty@intel.com>
> ---
> lib/librte_ether/rte_ethdev.c | 2 +-
> lib/librte_ether/rte_ethdev.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 318af2869..eed3d3005 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -301,7 +301,7 @@ rte_eth_dev_socket_id(uint16_t port_id)
> }
>
> void *
> -rte_eth_dev_get_sec_ctx(uint8_t port_id)
> +rte_eth_dev_get_sec_ctx(uint16_t port_id)
> {
> RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, NULL);
> return rte_eth_devices[port_id].security_ctx;
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index e620c3706..59189096e 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -1745,7 +1745,7 @@ struct rte_eth_dev {
> } __rte_cache_aligned;
>
> void *
> -rte_eth_dev_get_sec_ctx(uint8_t port_id);
> +rte_eth_dev_get_sec_ctx(uint16_t port_id);
>
> struct rte_eth_dev_sriov {
> uint8_t active; /**< SRIOV is active with 16, 32 or 64 pools */
>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
On 11/30/2017 6:29 PM, Ferruh Yigit wrote:
> port_id is now 16bits, update function parameter according.
>
> Fixes: 4c270218aa26 ("ethdev: support security APIs")
> Cc: stable@dpdk.org
> Cc: declan.doherty@intel.com
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Boris Pismenny <borisp@mellanox.com>
> Cc: Aviad Yehezkel <aviadye@mellanox.com>
> Cc: Radu Nicolau <radu.nicolau@intel.com>
> Cc: Declan Doherty <declan.doherty@intel.com>
> ---
<...>
>
> void *
> -rte_eth_dev_get_sec_ctx(uint8_t port_id);
> +rte_eth_dev_get_sec_ctx(uint16_t port_id);
Hi Declan,
Since this is a public API, it needs API documentation. Can you please send a
patch to add doxygen comments the the API?
Thanks,
ferruh
>
> struct rte_eth_dev_sriov {
> uint8_t active; /**< SRIOV is active with 16, 32 or 64 pools */
>
@@ -301,7 +301,7 @@ rte_eth_dev_socket_id(uint16_t port_id)
}
void *
-rte_eth_dev_get_sec_ctx(uint8_t port_id)
+rte_eth_dev_get_sec_ctx(uint16_t port_id)
{
RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, NULL);
return rte_eth_devices[port_id].security_ctx;
@@ -1745,7 +1745,7 @@ struct rte_eth_dev {
} __rte_cache_aligned;
void *
-rte_eth_dev_get_sec_ctx(uint8_t port_id);
+rte_eth_dev_get_sec_ctx(uint16_t port_id);
struct rte_eth_dev_sriov {
uint8_t active; /**< SRIOV is active with 16, 32 or 64 pools */