diff mbox

[dpdk-dev,2/2] doc: Fix typo

Message ID 20171201182640.21885-2-roy.franz@cavium.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Roy Franz Dec. 1, 2017, 6:26 p.m. UTC 
  Fix trivial typo (an -> and) in description of service core masks.

Signed-off-by: Roy Franz <roy.franz@cavium.com>
---
 doc/guides/prog_guide/service_cores.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John McNamara Dec. 11, 2017, 3:20 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Roy Franz
> Sent: Friday, December 1, 2017 6:27 PM
> To: dev@dpdk.org
> Cc: Roy Franz <roy.franz@cavium.com>
> Subject: [dpdk-dev] [PATCH 2/2] doc: Fix typo
> 
> Fix trivial typo (an -> and) in description of service core masks.
> 
> Signed-off-by: Roy Franz <roy.franz@cavium.com>

Thanks. For future reference the subject line should be lowercase like:

    doc: fix typo

Or better

    doc: fix typo in service cores doc

See: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line

Apart from that,

Acked-by: John McNamara <john.mcnamara@intel.com>
Thomas Monjalon Jan. 11, 2018, 5:37 p.m. UTC | #2 
11/12/2017 16:20, Mcnamara, John:
> > Fix trivial typo (an -> and) in description of service core masks.
> > 
> > Signed-off-by: Roy Franz <roy.franz@cavium.com>
> 
> Thanks. For future reference the subject line should be lowercase like:
> 
>     doc: fix typo
> 
> Or better
> 
>     doc: fix typo in service cores doc

Better to use "guide" when fixing a guide:

	doc: fix typo in prog guide

> See: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line
> 
> Apart from that,
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Series applied, thanks
diff mbox

Patch

diff --git a/doc/guides/prog_guide/service_cores.rst b/doc/guides/prog_guide/service_cores.rst
index 3a029ba9c..5a8d8941a 100644
--- a/doc/guides/prog_guide/service_cores.rst
+++ b/doc/guides/prog_guide/service_cores.rst
@@ -55,7 +55,7 @@  Service Core Initialization
 There are two methods to having service cores in a DPDK application, either by
 using the service coremask, or by dynamically adding cores using the API.
 The simpler of the two is to pass the `-s` coremask argument to EAL, which will
-take any cores available in the main DPDK coremask, an if the bits are also set
+take any cores available in the main DPDK coremask, and if the bits are also set
 in the service coremask the cores become service-cores instead of DPDK
 application lcores.