diff mbox

[dpdk-dev,v3,01/19] crypto/ccp: add AMD ccp skeleton PMD

Message ID 1515577379-18453-1-git-send-email-Ravi1.kumar@amd.com (mailing list archive)
State Superseded, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Kumar, Ravi1 Jan. 10, 2018, 9:42 a.m. UTC 
  Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
---
 MAINTAINERS                                |  6 +++
 config/common_base                         |  5 +++
 doc/guides/rel_notes/release_18_02.rst     |  5 +++
 drivers/crypto/Makefile                    |  1 +
 drivers/crypto/ccp/Makefile                | 55 ++++++++++++++++++++++++++
 drivers/crypto/ccp/rte_ccp_pmd.c           | 62 ++++++++++++++++++++++++++++++
 drivers/crypto/ccp/rte_pmd_ccp_version.map |  4 ++
 mk/rte.app.mk                              |  2 +
 8 files changed, 140 insertions(+)
 create mode 100644 drivers/crypto/ccp/Makefile
 create mode 100644 drivers/crypto/ccp/rte_ccp_pmd.c
 create mode 100644 drivers/crypto/ccp/rte_pmd_ccp_version.map

Comments

De Lara Guarch, Pablo Jan. 10, 2018, 9:53 a.m. UTC | #1 
Hi Ravi,

> -----Original Message-----
> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
> Sent: Wednesday, January 10, 2018 9:43 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
> 
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
> ---

...

> --- /dev/null
> +++ b/drivers/crypto/ccp/Makefile
> @@ -0,0 +1,55 @@
> +#
> +#   Copyright(c) 2018 Advanced Micro Devices, Inc.
> +#   All rights reserved.
> +#

As Hemant commented, you need to change this full license with SPDX tags:

http://dpdk.org/ml/archives/dev/2018-January/085510.html

Could you submit a v4 with these changes today?

Thanks,
Pablo
Kumar, Ravi1 Jan. 10, 2018, 10:29 a.m. UTC | #2 
>Hi Ravi,
>
>> -----Original Message-----
>> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
>> Sent: Wednesday, January 10, 2018 9:43 AM
>> To: dev@dpdk.org
>> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
>> 
>> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
>> ---
>
>...
>
>> --- /dev/null
>> +++ b/drivers/crypto/ccp/Makefile
>> @@ -0,0 +1,55 @@
>> +#
>> +#   Copyright(c) 2018 Advanced Micro Devices, Inc.
>> +#   All rights reserved.
>> +#
>
>As Hemant commented, you need to change this full license with SPDX tags:
>
>http://dpdk.org/ml/archives/dev/2018-January/085510.html
>
>Could you submit a v4 with these changes today?
>
>Thanks,
>Pablo

Hi Pablo,

Our legal team is still working on the license. We want to get the code reviewed in parallel. 
I will give you and update later if we can upload the v4 patch with SPDX tags today. 

Regards,
Ravi
De Lara Guarch, Pablo Jan. 10, 2018, 1:41 p.m. UTC | #3 
> -----Original Message-----
> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
> Sent: Wednesday, January 10, 2018 10:30 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: Shippen, Greg <Greg.Shippen@amd.com>
> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
> 
> >Hi Ravi,
> >
> >> -----Original Message-----
> >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
> >> Sent: Wednesday, January 10, 2018 9:43 AM
> >> To: dev@dpdk.org
> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> >> Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
> >>
> >> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
> >> ---
> >
> >...
> >
> >> --- /dev/null
> >> +++ b/drivers/crypto/ccp/Makefile
> >> @@ -0,0 +1,55 @@
> >> +#
> >> +#   Copyright(c) 2018 Advanced Micro Devices, Inc.
> >> +#   All rights reserved.
> >> +#
> >
> >As Hemant commented, you need to change this full license with SPDX
> tags:
> >
> >http://dpdk.org/ml/archives/dev/2018-January/085510.html
> >
> >Could you submit a v4 with these changes today?
> >
> >Thanks,
> >Pablo
> 
> Hi Pablo,
> 
> Our legal team is still working on the license. We want to get the code
> reviewed in parallel.
> I will give you and update later if we can upload the v4 patch with SPDX tags
> today.
> 

Ok, I have looked at the overall patchset and it looks ok to me.
The only thing that I would change is the title of patch 7/19:
I would change it to "crypto/ccp: support sessionless operations".

Regards,
Pablo

> Regards,
> Ravi
Kumar, Ravi1 Jan. 11, 2018, 6:36 a.m. UTC | #4 
> -----Original Message-----
>> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
>> Sent: Wednesday, January 10, 2018 10:30 AM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; 
>> dev@dpdk.org
>> Cc: Shippen, Greg <Greg.Shippen@amd.com>
>> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
>> 
>> >Hi Ravi,
>> >
>> >> -----Original Message-----
>> >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
>> >> Sent: Wednesday, January 10, 2018 9:43 AM
>> >> To: dev@dpdk.org
>> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> >> Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
>> >>
>> >> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
>> >> ---
>> >
>> >...
>> >
>> >> --- /dev/null
>> >> +++ b/drivers/crypto/ccp/Makefile
>> >> @@ -0,0 +1,55 @@
>> >> +#
>> >> +#   Copyright(c) 2018 Advanced Micro Devices, Inc.
>> >> +#   All rights reserved.
>> >> +#
>> >
>> >As Hemant commented, you need to change this full license with SPDX
>> tags:
>> >
>> >http://dpdk.org/ml/archives/dev/2018-January/085510.html
>> >
>> >Could you submit a v4 with these changes today?
>> >
>> >Thanks,
>> >Pablo
>> 
>> Hi Pablo,
>> 
>> Our legal team is still working on the license. We want to get the 
>> code reviewed in parallel.
>> I will give you and update later if we can upload the v4 patch with 
>> SPDX tags today.
>> 
>
>Ok, I have looked at the overall patchset and it looks ok to me.
>The only thing that I would change is the title of patch 7/19:
>I would change it to "crypto/ccp: support sessionless operations".
>
>Regards,
>Pablo

Hi Pablo,

Thanks for going through our code. Good to know the code is fine. 

The new changes in licensing policy has introduced some delays as we work through the implications and get agreement from the third party.

We are working on it and will upload the v4 with SPDX license tags as soon as possible. 

Regards,
Ravi
>
>> Regards,
>> Ravi
De Lara Guarch, Pablo Jan. 16, 2018, 3:29 p.m. UTC | #5 
Hi Ravi,

> -----Original Message-----
> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
> Sent: Thursday, January 11, 2018 6:37 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: Shippen, Greg <Greg.Shippen@amd.com>
> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
> 
> > -----Original Message-----
> >> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
> >> Sent: Wednesday, January 10, 2018 10:30 AM
> >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> >> dev@dpdk.org
> >> Cc: Shippen, Greg <Greg.Shippen@amd.com>
> >> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
> >>
> >> >Hi Ravi,
> >> >
> >> >> -----Original Message-----
> >> >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
> >> >> Sent: Wednesday, January 10, 2018 9:43 AM
> >> >> To: dev@dpdk.org
> >> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> >> >> Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
> >> >>
> >> >> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
> >> >> ---
> >> >
> >> >...
> >> >
> >> >> --- /dev/null
> >> >> +++ b/drivers/crypto/ccp/Makefile
> >> >> @@ -0,0 +1,55 @@
> >> >> +#
> >> >> +#   Copyright(c) 2018 Advanced Micro Devices, Inc.
> >> >> +#   All rights reserved.
> >> >> +#
> >> >
> >> >As Hemant commented, you need to change this full license with SPDX
> >> tags:
> >> >
> >> >http://dpdk.org/ml/archives/dev/2018-January/085510.html
> >> >
> >> >Could you submit a v4 with these changes today?
> >> >
> >> >Thanks,
> >> >Pablo
> >>
> >> Hi Pablo,
> >>
> >> Our legal team is still working on the license. We want to get the
> >> code reviewed in parallel.
> >> I will give you and update later if we can upload the v4 patch with
> >> SPDX tags today.
> >>
> >
> >Ok, I have looked at the overall patchset and it looks ok to me.
> >The only thing that I would change is the title of patch 7/19:
> >I would change it to "crypto/ccp: support sessionless operations".
> >
> >Regards,
> >Pablo
> 
> Hi Pablo,
> 
> Thanks for going through our code. Good to know the code is fine.
> 
> The new changes in licensing policy has introduced some delays as we work
> through the implications and get agreement from the third party.
> 
> We are working on it and will upload the v4 with SPDX license tags as soon
> as possible.
> 

Any news? RC1 will be out on Friday, and the subtree should be close tomorrow evening,
and there will not be more features added after this point.

Thanks,
Pablo

> Regards,
> Ravi
> >
> >> Regards,
> >> Ravi
Kumar, Ravi1 Jan. 17, 2018, 9:08 a.m. UTC | #6 
>Hi Ravi,
>
>> -----Original Message-----
>> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
>> Sent: Thursday, January 11, 2018 6:37 AM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; 
>> dev@dpdk.org
>> Cc: Shippen, Greg <Greg.Shippen@amd.com>
>> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
>> 
>> > -----Original Message-----
>> >> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
>> >> Sent: Wednesday, January 10, 2018 10:30 AM
>> >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; 
>> >> dev@dpdk.org
>> >> Cc: Shippen, Greg <Greg.Shippen@amd.com>
>> >> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
>> >>
>> >> >Hi Ravi,
>> >> >
>> >> >> -----Original Message-----
>> >> >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
>> >> >> Sent: Wednesday, January 10, 2018 9:43 AM
>> >> >> To: dev@dpdk.org
>> >> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> >> >> Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
>> >> >>
>> >> >> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
>> >> >> ---
>> >> >
>> >> >...
>> >> >
>> >> >> --- /dev/null
>> >> >> +++ b/drivers/crypto/ccp/Makefile
>> >> >> @@ -0,0 +1,55 @@
>> >> >> +#
>> >> >> +#   Copyright(c) 2018 Advanced Micro Devices, Inc.
>> >> >> +#   All rights reserved.
>> >> >> +#
>> >> >
>> >> >As Hemant commented, you need to change this full license with 
>> >> >SPDX
>> >> tags:
>> >> >
>> >> >http://dpdk.org/ml/archives/dev/2018-January/085510.html
>> >> >
>> >> >Could you submit a v4 with these changes today?
>> >> >
>> >> >Thanks,
>> >> >Pablo
>> >>
>> >> Hi Pablo,
>> >>
>> >> Our legal team is still working on the license. We want to get the 
>> >> code reviewed in parallel.
>> >> I will give you and update later if we can upload the v4 patch with 
>> >> SPDX tags today.
>> >>
>> >
>> >Ok, I have looked at the overall patchset and it looks ok to me.
>> >The only thing that I would change is the title of patch 7/19:
>> >I would change it to "crypto/ccp: support sessionless operations".
>> >
>> >Regards,
>> >Pablo
>> 
>> Hi Pablo,
>> 
>> Thanks for going through our code. Good to know the code is fine.
>> 
>> The new changes in licensing policy has introduced some delays as we 
>> work through the implications and get agreement from the third party.
>> 
>> We are working on it and will upload the v4 with SPDX license tags as 
>> soon as possible.
>> 
>
>Any news? RC1 will be out on Friday, and the subtree should be close tomorrow evening, and there will not be more features added after this point.
>
>Thanks,
>Pablo

Hi Pablo,

We are still in the process of getting the sign off on the new SPDX license tags from the third party. We expect an answer from them by the end of the week at the earliest. 

I will get back to you as soon as I have some update.

Regards,
Ravi

>
>> Regards,
>> Ravi
>> >
>> >> Regards,
>> >> Ravi
De Lara Guarch, Pablo Jan. 24, 2018, 8:57 a.m. UTC | #7 
Hi Ravi,

> -----Original Message-----
> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
> Sent: Wednesday, January 17, 2018 9:09 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: Shippen, Greg <Greg.Shippen@amd.com>
> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
> 
> >Hi Ravi,
> >
> >> -----Original Message-----
> >> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
> >> Sent: Thursday, January 11, 2018 6:37 AM
> >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> >> dev@dpdk.org
> >> Cc: Shippen, Greg <Greg.Shippen@amd.com>
> >> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
> >>
> >> > -----Original Message-----
> >> >> From: Kumar, Ravi1 [mailto:Ravi1.Kumar@amd.com]
> >> >> Sent: Wednesday, January 10, 2018 10:30 AM
> >> >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> >> >> dev@dpdk.org
> >> >> Cc: Shippen, Greg <Greg.Shippen@amd.com>
> >> >> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton
> PMD
> >> >>
> >> >> >Hi Ravi,
> >> >> >
> >> >> >> -----Original Message-----
> >> >> >> From: Ravi Kumar [mailto:Ravi1.kumar@amd.com]
> >> >> >> Sent: Wednesday, January 10, 2018 9:43 AM
> >> >> >> To: dev@dpdk.org
> >> >> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> >> >> >> Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton
> PMD
> >> >> >>
> >> >> >> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
> >> >> >> ---
> >> >> >
> >> >> >...
> >> >> >
> >> >> >> --- /dev/null
> >> >> >> +++ b/drivers/crypto/ccp/Makefile
> >> >> >> @@ -0,0 +1,55 @@
> >> >> >> +#
> >> >> >> +#   Copyright(c) 2018 Advanced Micro Devices, Inc.
> >> >> >> +#   All rights reserved.
> >> >> >> +#
> >> >> >
> >> >> >As Hemant commented, you need to change this full license with
> >> >> >SPDX
> >> >> tags:
> >> >> >
> >> >> >http://dpdk.org/ml/archives/dev/2018-January/085510.html
> >> >> >
> >> >> >Could you submit a v4 with these changes today?
> >> >> >
> >> >> >Thanks,
> >> >> >Pablo
> >> >>
> >> >> Hi Pablo,
> >> >>
> >> >> Our legal team is still working on the license. We want to get the
> >> >> code reviewed in parallel.
> >> >> I will give you and update later if we can upload the v4 patch
> >> >> with SPDX tags today.
> >> >>
> >> >
> >> >Ok, I have looked at the overall patchset and it looks ok to me.
> >> >The only thing that I would change is the title of patch 7/19:
> >> >I would change it to "crypto/ccp: support sessionless operations".
> >> >
> >> >Regards,
> >> >Pablo
> >>
> >> Hi Pablo,
> >>
> >> Thanks for going through our code. Good to know the code is fine.
> >>
> >> The new changes in licensing policy has introduced some delays as we
> >> work through the implications and get agreement from the third party.
> >>
> >> We are working on it and will upload the v4 with SPDX license tags as
> >> soon as possible.
> >>
> >
> >Any news? RC1 will be out on Friday, and the subtree should be close
> tomorrow evening, and there will not be more features added after this
> point.
> >
> >Thanks,
> >Pablo
> 
> Hi Pablo,
> 
> We are still in the process of getting the sign off on the new SPDX license
> tags from the third party. We expect an answer from them by the end of
> the week at the earliest.
> 
> I will get back to you as soon as I have some update.

Any update? This could still be merged in RC2, but no later than that.

Thanks,
Pablo

> 
> Regards,
> Ravi
> 
> >
> >> Regards,
> >> Ravi
> >> >
> >> >> Regards,
> >> >> Ravi
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index b51c2d0..e609244 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -594,6 +594,12 @@  M: Pablo de Lara <pablo.de.lara.guarch@intel.com>
 T: git://dpdk.org/next/dpdk-next-crypto
 F: doc/guides/cryptodevs/features/default.ini
 
+AMD CCP Crypto PMD
+M: Ravi Kumar <ravi1.kumar@amd.com>
+F: drivers/crypto/ccp/
+F: doc/guides/cryptodevs/ccp.rst
+F: doc/guides/cryptodevs/features/ccp.ini
+
 ARMv8 Crypto
 M: Jerin Jacob <jerin.jacob@caviumnetworks.com>
 F: drivers/crypto/armv8/
diff --git a/config/common_base b/config/common_base
index e74febe..88826c8 100644
--- a/config/common_base
+++ b/config/common_base
@@ -557,6 +557,11 @@  CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER_DEBUG=n
 CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y
 
 #
+# Compile PMD for AMD CCP crypto device
+#
+CONFIG_RTE_LIBRTE_PMD_CCP=n
+
+#
 # Compile PMD for Marvell Crypto device
 #
 CONFIG_RTE_LIBRTE_PMD_MRVL_CRYPTO=n
diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst
index 24b67bb..42ebeeb 100644
--- a/doc/guides/rel_notes/release_18_02.rst
+++ b/doc/guides/rel_notes/release_18_02.rst
@@ -41,6 +41,11 @@  New Features
      Also, make sure to start the actual text at the margin.
      =========================================================
 
+* **Added a new crypto poll mode driver for AMD CCP devices.**
+
+  Added the new ``ccp`` crypto driver for AMD CCP devices. See the
+  :doc:`../cryptodevs/ccp` crypto driver guide for more details on
+  this new driver.
 
 API Changes
 -----------
diff --git a/drivers/crypto/Makefile b/drivers/crypto/Makefile
index 628bd14..fe41edd 100644
--- a/drivers/crypto/Makefile
+++ b/drivers/crypto/Makefile
@@ -16,5 +16,6 @@  DIRS-$(CONFIG_RTE_LIBRTE_PMD_MRVL_CRYPTO) += mrvl
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += null
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += dpaa2_sec
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_SEC) += dpaa_sec
+DIRS-$(CONFIG_RTE_LIBRTE_PMD_CCP) += ccp
 
 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/drivers/crypto/ccp/Makefile b/drivers/crypto/ccp/Makefile
new file mode 100644
index 0000000..51c5e5b
--- /dev/null
+++ b/drivers/crypto/ccp/Makefile
@@ -0,0 +1,55 @@ 
+#
+#   Copyright(c) 2018 Advanced Micro Devices, Inc.
+#   All rights reserved.
+#
+#   Redistribution and use in source and binary forms, with or without
+#   modification, are permitted provided that the following conditions
+#   are met:
+#
+# 	* Redistributions of source code must retain the above copyright
+# 	notice, this list of conditions and the following disclaimer.
+# 	* Redistributions in binary form must reproduce the above copyright
+# 	notice, this list of conditions and the following disclaimer in the
+# 	documentation and/or other materials provided with the distribution.
+# 	* Neither the name of the copyright holder nor the names of its
+# 	contributors may be used to endorse or promote products derived from
+# 	this software without specific prior written permission.
+#
+#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+#   HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+# library name
+LIB = librte_pmd_ccp.a
+
+# build flags
+CFLAGS += -O3
+CFLAGS += -I$(SRCDIR)
+CFLAGS += $(WERROR_FLAGS)
+
+# library version
+LIBABIVER := 1
+
+# external library include paths
+LDLIBS += -lcrypto
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
+LDLIBS += -lrte_cryptodev
+LDLIBS += -lrte_pci -lrte_bus_pci
+
+# versioning export map
+EXPORT_MAP := rte_pmd_ccp_version.map
+
+# library source files
+SRCS-$(CONFIG_RTE_LIBRTE_PMD_CCP) += rte_ccp_pmd.c
+
+include $(RTE_SDK)/mk/rte.lib.mk
diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c b/drivers/crypto/ccp/rte_ccp_pmd.c
new file mode 100644
index 0000000..6fa14bd
--- /dev/null
+++ b/drivers/crypto/ccp/rte_ccp_pmd.c
@@ -0,0 +1,62 @@ 
+/*-
+ *   Copyright(c) 2018 Advanced Micro Devices, Inc.
+ *   All rights reserved.
+ *
+ *   Redistribution and use in source and binary forms, with or without
+ *   modification, are permitted provided that the following conditions
+ *   are met:
+ *
+ *	* Redistributions of source code must retain the above copyright
+ *	notice, this list of conditions and the following disclaimer.
+ *	* Redistributions in binary form must reproduce the above copyright
+ *	notice, this list of conditions and the following disclaimer in the
+ *	documentation and/or other materials provided with the distribution.
+ *	* Neither the name of the copyright holder nor the names of its
+ *	contributors may be used to endorse or promote products derived from
+ *	this software without specific prior written permission.
+ *
+ *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ *   HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <rte_bus_vdev.h>
+#include <rte_cryptodev.h>
+#include <rte_cryptodev_pmd.h>
+
+uint8_t ccp_cryptodev_driver_id;
+
+/** Remove ccp pmd */
+static int
+cryptodev_ccp_remove(struct rte_vdev_device *dev __rte_unused)
+{
+	return 0;
+}
+
+/** Probe ccp pmd */
+static int
+cryptodev_ccp_probe(struct rte_vdev_device *vdev __rte_unused)
+{
+	return 0;
+}
+
+static struct rte_vdev_driver cryptodev_ccp_pmd_drv = {
+	.probe = cryptodev_ccp_probe,
+	.remove = cryptodev_ccp_remove
+};
+
+static struct cryptodev_driver ccp_crypto_drv;
+
+RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_CCP_PMD, cryptodev_ccp_pmd_drv);
+RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_CCP_PMD,
+	"max_nb_queue_pairs=<int> max_nb_sessions=<int> socket_id=<int>");
+RTE_PMD_REGISTER_CRYPTO_DRIVER(ccp_crypto_drv, cryptodev_ccp_pmd_drv,
+			       ccp_cryptodev_driver_id);
diff --git a/drivers/crypto/ccp/rte_pmd_ccp_version.map b/drivers/crypto/ccp/rte_pmd_ccp_version.map
new file mode 100644
index 0000000..179140f
--- /dev/null
+++ b/drivers/crypto/ccp/rte_pmd_ccp_version.map
@@ -0,0 +1,4 @@ 
+DPDK_18.02 {
+
+	local: *;
+};
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 6a6a745..0453b7f 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -191,6 +191,8 @@  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_SEC)   += -lrte_bus_dpaa
 _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_SEC)   += -lrte_pmd_dpaa_sec
 endif # CONFIG_RTE_LIBRTE_DPAA_BUS
 
+_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_CCP)   += -lrte_pmd_ccp -lcrypto
+
 endif # CONFIG_RTE_LIBRTE_CRYPTODEV
 
 ifeq ($(CONFIG_RTE_LIBRTE_EVENTDEV),y)