[dpdk-dev,v1] testpmd: fix incorrect port_id word size
Checks
Commit Message
The word size of port_id is now 16 bits, but there were parsing directives
that assumed it was still of type UINT8, resulting in incorrect commandline
parse results.
Fixes: f14a210a65fe ("app: fix port id type")
Signed-off-by: Remy Horton <remy.horton@intel.com>
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 1/19/2018 1:27 PM, Remy Horton wrote:
"app/testpmd: fix incorrect port id word size" ?
> The word size of port_id is now 16 bits, but there were parsing directives
> that assumed it was still of type UINT8, resulting in incorrect commandline
> parse results.
>
> Fixes: f14a210a65fe ("app: fix port id type")
Cc: stable@dpdk.org
> Signed-off-by: Remy Horton <remy.horton@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
20/01/2018 14:33, Ferruh Yigit:
> On 1/19/2018 1:27 PM, Remy Horton wrote:
>
> "app/testpmd: fix incorrect port id word size" ?
>
> > The word size of port_id is now 16 bits, but there were parsing directives
> > that assumed it was still of type UINT8, resulting in incorrect commandline
> > parse results.
> >
> > Fixes: f14a210a65fe ("app: fix port id type")
>
> Cc: stable@dpdk.org
>
> > Signed-off-by: Remy Horton <remy.horton@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
@@ -5837,7 +5837,7 @@ cmdline_parse_token_string_t cmd_setpromisc_portall =
"all");
cmdline_parse_token_num_t cmd_setpromisc_portnum =
TOKEN_NUM_INITIALIZER(struct cmd_set_promisc_mode_result, port_num,
- UINT8);
+ UINT16);
cmdline_parse_token_string_t cmd_setpromisc_mode =
TOKEN_STRING_INITIALIZER(struct cmd_set_promisc_mode_result, mode,
"on#off");