diff mbox

[dpdk-dev] examples/ip_pipeline: fix logically dead node

Message ID 20180416105820.66064-1-roy.fan.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Cristian Dumitrescu
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Fan Zhang April 16, 2018, 10:58 a.m. UTC 
  Coverity issue: 272567
Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 examples/ip_pipeline/cli.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Jasvinder Singh April 18, 2018, 2:03 p.m. UTC | #1 
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Monday, April 16, 2018 11:58 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix logically dead node
> 
> Coverity issue: 272567
> Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  examples/ip_pipeline/cli.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index
> 199a31ff8..6c07ca223 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -1890,12 +1890,6 @@ cmd_pipeline_table(char **tokens,
> 
>  		t0 += 6;
>  	} else if (strcmp(tokens[t0], "stub") == 0) {
> -		if (n_tokens < t0 + 1) {
> -			snprintf(out, out_size, MSG_ARG_MISMATCH,
> -				"pipeline table stub");
> -			return;
> -		}
> -
>  		p.match_type = TABLE_STUB;
> 
>  		t0 += 1;
> --
> 2.13.6

Reviewed-by: Jasvinder Singh <jasvindeer.singh@intel.com>
Cristian Dumitrescu May 8, 2018, 2:28 p.m. UTC | #2 
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Monday, April 16, 2018 11:58 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix logically dead node
> 
> Coverity issue: 272567
> Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  examples/ip_pipeline/cli.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
> index 199a31ff8..6c07ca223 100644
> --- a/examples/ip_pipeline/cli.c
> +++ b/examples/ip_pipeline/cli.c
> @@ -1890,12 +1890,6 @@ cmd_pipeline_table(char **tokens,
> 
>  		t0 += 6;
>  	} else if (strcmp(tokens[t0], "stub") == 0) {
> -		if (n_tokens < t0 + 1) {
> -			snprintf(out, out_size, MSG_ARG_MISMATCH,
> -				"pipeline table stub");
> -			return;
> -		}
> -
>  		p.match_type = TABLE_STUB;
> 
>  		t0 += 1;
> --
> 2.13.6

Acked-by: Cristian.Dumitrescu <cristian.dumitrescu@intel.com>

Applied to next-pipeline tree, thanks!
diff mbox

Patch

diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index 199a31ff8..6c07ca223 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -1890,12 +1890,6 @@  cmd_pipeline_table(char **tokens,
 
 		t0 += 6;
 	} else if (strcmp(tokens[t0], "stub") == 0) {
-		if (n_tokens < t0 + 1) {
-			snprintf(out, out_size, MSG_ARG_MISMATCH,
-				"pipeline table stub");
-			return;
-		}
-
 		p.match_type = TABLE_STUB;
 
 		t0 += 1;