[dpdk-dev] app/eventdev: fix gcc 4.8 compilation errors
Checks
Commit Message
test_perf_common.c: In function ‘perf_event_timer_producer’:
test_perf_common.c:99:3: error: missing initializer for
field ‘priority’ of ‘struct <anonymous>’
[-Werror=missing-field-initializers]
.ev.sched_type = t->opt->sched_type_list[0],
Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a producer")
Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
app/test-eventdev/test_perf_common.c | 36 ++++++++++++++--------------
1 file changed, 18 insertions(+), 18 deletions(-)
Comments
On 04/16/2018 04:13 PM, Pavan Nikhilesh wrote:
> test_perf_common.c: In function ‘perf_event_timer_producer’:
> test_perf_common.c:99:3: error: missing initializer for
> field ‘priority’ of ‘struct <anonymous>’
> [-Werror=missing-field-initializers]
> .ev.sched_type = t->opt->sched_type_list[0],
>
> Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a producer")
>
> Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Thanks for quick fix.
Build on RHEL 7.4:
Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>
16/04/2018 15:51, Andrew Rybchenko:
> On 04/16/2018 04:13 PM, Pavan Nikhilesh wrote:
> > test_perf_common.c: In function ‘perf_event_timer_producer’:
> > test_perf_common.c:99:3: error: missing initializer for
> > field ‘priority’ of ‘struct <anonymous>’
> > [-Werror=missing-field-initializers]
> > .ev.sched_type = t->opt->sched_type_list[0],
> >
> > Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a producer")
> >
> > Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Thanks for quick fix.
>
> Build on RHEL 7.4:
> Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied, thanks
@@ -87,21 +87,21 @@ perf_event_timer_producer(void *arg)
struct rte_mempool *pool = t->pool;
struct perf_elt *m;
struct rte_event_timer_adapter **adptr = t->timer_adptr;
+ struct rte_event_timer tim;
uint64_t timeout_ticks = opt->expiry_nsec / opt->timer_tick_nsec;
+ memset(&tim, 0, sizeof(struct rte_event_timer));
timeout_ticks = opt->optm_timer_tick_nsec ?
(timeout_ticks * opt->timer_tick_nsec)
/ opt->optm_timer_tick_nsec : timeout_ticks;
timeout_ticks += timeout_ticks ? 0 : 1;
- const struct rte_event_timer tim = {
- .ev.op = RTE_EVENT_OP_NEW,
- .ev.queue_id = p->queue_id,
- .ev.sched_type = t->opt->sched_type_list[0],
- .ev.priority = RTE_EVENT_DEV_PRIORITY_NORMAL,
- .ev.event_type = RTE_EVENT_TYPE_TIMER,
- .state = RTE_EVENT_TIMER_NOT_ARMED,
- .timeout_ticks = timeout_ticks,
- };
+ tim.ev.event_type = RTE_EVENT_TYPE_TIMER;
+ tim.ev.op = RTE_EVENT_OP_NEW;
+ tim.ev.sched_type = t->opt->sched_type_list[0];
+ tim.ev.queue_id = p->queue_id;
+ tim.ev.priority = RTE_EVENT_DEV_PRIORITY_NORMAL;
+ tim.state = RTE_EVENT_TIMER_NOT_ARMED;
+ tim.timeout_ticks = timeout_ticks;
if (opt->verbose_level > 1)
printf("%s(): lcore %d\n", __func__, rte_lcore_id());
@@ -149,21 +149,21 @@ perf_event_timer_producer_burst(void *arg)
struct rte_mempool *pool = t->pool;
struct perf_elt *m[BURST_SIZE + 1] = {NULL};
struct rte_event_timer_adapter **adptr = t->timer_adptr;
+ struct rte_event_timer tim;
uint64_t timeout_ticks = opt->expiry_nsec / opt->timer_tick_nsec;
+ memset(&tim, 0, sizeof(struct rte_event_timer));
timeout_ticks = opt->optm_timer_tick_nsec ?
(timeout_ticks * opt->timer_tick_nsec)
/ opt->optm_timer_tick_nsec : timeout_ticks;
timeout_ticks += timeout_ticks ? 0 : 1;
- const struct rte_event_timer tim = {
- .ev.op = RTE_EVENT_OP_NEW,
- .ev.queue_id = p->queue_id,
- .ev.sched_type = t->opt->sched_type_list[0],
- .ev.priority = RTE_EVENT_DEV_PRIORITY_NORMAL,
- .ev.event_type = RTE_EVENT_TYPE_TIMER,
- .state = RTE_EVENT_TIMER_NOT_ARMED,
- .timeout_ticks = timeout_ticks,
- };
+ tim.ev.event_type = RTE_EVENT_TYPE_TIMER;
+ tim.ev.op = RTE_EVENT_OP_NEW;
+ tim.ev.sched_type = t->opt->sched_type_list[0];
+ tim.ev.queue_id = p->queue_id;
+ tim.ev.priority = RTE_EVENT_DEV_PRIORITY_NORMAL;
+ tim.state = RTE_EVENT_TIMER_NOT_ARMED;
+ tim.timeout_ticks = timeout_ticks;
if (opt->verbose_level > 1)
printf("%s(): lcore %d\n", __func__, rte_lcore_id());