[dpdk-dev,v2] examples/ip_pipeline: fix buffer not null terminated
Checks
Commit Message
Coverity issue: 272572
Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects")
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
v2:
- use more generic strlcpy approach
examples/ip_pipeline/action.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
On Tue, Apr 17, 2018 at 10:52:52AM +0100, Fan Zhang wrote:
> Coverity issue: 272572
> Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> v2:
> - use more generic strlcpy approach
>
> examples/ip_pipeline/action.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c
> index 77a04fe19..1203bb892 100644
> --- a/examples/ip_pipeline/action.c
> +++ b/examples/ip_pipeline/action.c
> @@ -6,6 +6,8 @@
> #include <stdlib.h>
> #include <string.h>
>
> +#include <rte_string_fns.h>
> +
> #include "action.h"
> #include "hash_func.h"
>
> @@ -133,7 +135,7 @@ port_in_action_profile_create(const char *name,
> }
>
> /* Node fill in */
> - strncpy(profile->name, name, sizeof(profile->name));
> + strlcpy(profile->name, name, sizeof(profile->name));
> memcpy(&profile->params, params, sizeof(*params));
> profile->ap = ap;
>
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
@@ -6,6 +6,8 @@
#include <stdlib.h>
#include <string.h>
+#include <rte_string_fns.h>
+
#include "action.h"
#include "hash_func.h"
@@ -133,7 +135,7 @@ port_in_action_profile_create(const char *name,
}
/* Node fill in */
- strncpy(profile->name, name, sizeof(profile->name));
+ strlcpy(profile->name, name, sizeof(profile->name));
memcpy(&profile->params, params, sizeof(*params));
profile->ap = ap;