[dpdk-dev,v2] dpaa2: do not log messages if bus not present

Message ID 20180425231637.32642-1-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger April 25, 2018, 11:16 p.m. UTC
  A typical distribution will compile with default config and all
buses enabled. Therefore every driver should be silent and not
log anything for this normal case.

This patch gets rid of these messages when running on basic x86
environment such as bare metal or VM.

fslmc: DPAA2: DPRC not available
fslmc: FSLMC Bus Not Available. Skipping

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
v2 - typo in previous patch

 drivers/bus/fslmc/fslmc_bus.c  | 2 +-
 drivers/bus/fslmc/fslmc_vfio.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
  

Comments

Thomas Monjalon April 26, 2018, 3:48 p.m. UTC | #1
26/04/2018 01:16, Stephen Hemminger:
> A typical distribution will compile with default config and all
> buses enabled. Therefore every driver should be silent and not
> log anything for this normal case.
> 
> This patch gets rid of these messages when running on basic x86
> environment such as bare metal or VM.
> 
> fslmc: DPAA2: DPRC not available
> fslmc: FSLMC Bus Not Available. Skipping
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, thanks
  

Patch

diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index d0b32611fe08..943c01b2874d 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -255,7 +255,7 @@  rte_fslmc_scan(void)
 	/* Remove all devices in the list */
 	cleanup_fslmc_device_list();
 scan_fail:
-	DPAA2_BUS_INFO("FSLMC Bus Not Available. Skipping");
+	DPAA2_BUS_DEBUG("FSLMC Bus Not Available. Skipping");
 	/* Irrespective of failure, scan only return success */
 	return 0;
 }
diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c
index 675d160ba3a8..749d92dc3fc9 100644
--- a/drivers/bus/fslmc/fslmc_vfio.c
+++ b/drivers/bus/fslmc/fslmc_vfio.c
@@ -74,7 +74,7 @@  fslmc_get_container_group(int *groupid)
 	if (!g_container) {
 		container = getenv("DPRC");
 		if (container == NULL) {
-			DPAA2_BUS_INFO("DPAA2: DPRC not available");
+			DPAA2_BUS_DEBUG("DPAA2: DPRC not available");
 			return -EINVAL;
 		}