diff mbox

[dpdk-dev] raw/ifpga/base: fix a return error value in ifpga_fme_pr

Message ID 1526460544-148713-1-git-send-email-rosen.xu@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xu, Rosen May 16, 2018, 8:49 a.m. UTC 
  From: "Zhang, Tianfei" <tianfei.zhang@intel.com>

fix a return error value by DPDK Coverity static code analysis

Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share code")
Coverity issue: 279448
Cc: stable@dpdk.org

Signed-off-by: Zhang, Tianfei <tianfei.zhang@intel.com>
---
 drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon May 21, 2018, 2:13 p.m. UTC | #1 
16/05/2018 10:49, Xu, Rosen:
> From: "Zhang, Tianfei" <tianfei.zhang@intel.com>
> 
> fix a return error value by DPDK Coverity static code analysis
> 
> Fixes: 56bb54ea1bdf ("raw/ifpga/base: add Intel FPGA OPAE share code")
> Coverity issue: 279448
> Cc: stable@dpdk.org

Not for stable, ifpga was introduced in 18.05.

> Signed-off-by: Zhang, Tianfei <tianfei.zhang@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c b/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c
index 49d8cc5..ec0beeb 100644
--- a/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c
+++ b/drivers/raw/ifpga_rawdev/base/ifpga_fme_pr.c
@@ -139,7 +139,7 @@  static int fme_pr_write(struct ifpga_fme_hw *fme_dev,
 			pr_credit--;
 		} else {
 			WARN_ON(1);
-			return -EINVAL;
+			ret = -EINVAL;
 			goto done;
 		}
 	}