diff mbox

[dpdk-dev] drivers/raw/ifpga_rawdev: fix coverity issue

Message ID 1526478813-154172-1-git-send-email-rosen.xu@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Xu, Rosen May 16, 2018, 1:53 p.m. UTC 
  Fix coverity issue: 279449

Signed-off-by: Rosen Xu <rosen.xu@intel.com>

Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
Coverity issue: 279449
Cc: stable@dpdk.org
---
 drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon May 21, 2018, 2:22 p.m. UTC | #1 
16/05/2018 15:53, Rosen Xu:
> Fix coverity issue: 279449
> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> 
> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> Coverity issue: 279449
> Cc: stable@dpdk.org

Not for stable

> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> @@ -227,7 +227,7 @@
>  	int file_fd;
>  	int ret = 0;
>  	ssize_t buffer_size;
> -	void *buffer;
> +	void *buffer = NULL;

It is not fixing anything.
This variable cannot be read before being written.
Xu, Rosen May 22, 2018, 10:42 a.m. UTC | #2 
Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, May 21, 2018 22:23
> To: Xu, Rosen <rosen.xu@intel.com>
> Cc: dev@dpdk.org; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Doherty,
> Declan <declan.doherty@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; shreyansh.jain@nxp.com; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Zhang, Tianfei <tianfei.zhang@intel.com>;
> Liu, Song <song.liu@intel.com>; Wu, Hao <hao.wu@intel.com>;
> gaetan.rivet@6wind.com
> Subject: Re: [dpdk-stable] [PATCH] drivers/raw/ifpga_rawdev: fix coverity
> issue
> 
> 16/05/2018 15:53, Rosen Xu:
> > Fix coverity issue: 279449
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> >
> > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
> > Coverity issue: 279449
> > Cc: stable@dpdk.org
> 
> Not for stable
> 
> > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> > @@ -227,7 +227,7 @@
> >  	int file_fd;
> >  	int ret = 0;
> >  	ssize_t buffer_size;
> > -	void *buffer;
> > +	void *buffer = NULL;
> 
> It is not fixing anything.
> This variable cannot be read before being written.

Yes, it's a scripts error.
This patch can be cancelled.
diff mbox

Patch

diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
index 030ed1b..0e94861 100644
--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
@@ -227,7 +227,7 @@ 
 	int file_fd;
 	int ret = 0;
 	ssize_t buffer_size;
-	void *buffer;
+	void *buffer = NULL;
 	u64 pr_error;
 
 	if (!file_name)