[dpdk-dev] cryptodev: add missing feature string

Message ID 20180518132350.24493-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

De Lara Guarch, Pablo May 18, 2018, 1:23 p.m. UTC
  Security protocol flag string was not added
when the actual flag was added.

Fixes: eadb4fa1e1fe ("cryptodev: support security APIs")
Cc: stable@dpdk.org

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 lib/librte_cryptodev/rte_cryptodev.c | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Varghese, Vipin May 18, 2018, 2:01 p.m. UTC | #1
Thanks Pablo for the fix. I am ok with this change

Acked-by: Vipin Varghese <vipin.varghese@intel.com>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Friday, May 18, 2018 6:54 PM
> To: Doherty, Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] cryptodev: add missing feature string
> 
> Security protocol flag string was not added when the actual flag was added.
> 
> Fixes: eadb4fa1e1fe ("cryptodev: support security APIs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  lib/librte_cryptodev/rte_cryptodev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/librte_cryptodev/rte_cryptodev.c
> b/lib/librte_cryptodev/rte_cryptodev.c
> index 2a95a351f..3712caf73 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.c
> +++ b/lib/librte_cryptodev/rte_cryptodev.c
> @@ -346,6 +346,8 @@ rte_cryptodev_get_feature_name(uint64_t flag)
>  		return "CPU_NEON";
>  	case RTE_CRYPTODEV_FF_CPU_ARM_CE:
>  		return "CPU_ARM_CE";
> +	case RTE_CRYPTODEV_FF_SECURITY:
> +		return "SECURITY_PROTOCOL";
>  	default:
>  		return NULL;
>  	}
> --
> 2.17.0
  
De Lara Guarch, Pablo May 21, 2018, 9:46 p.m. UTC | #2
> -----Original Message-----
> From: Varghese, Vipin
> Sent: Friday, May 18, 2018 3:01 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] cryptodev: add missing feature string
> 
> Thanks Pablo for the fix. I am ok with this change
> 
> Acked-by: Vipin Varghese <vipin.varghese@intel.com>
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Friday, May 18, 2018 6:54 PM
> > To: Doherty, Declan <declan.doherty@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] cryptodev: add missing feature string
> >
> > Security protocol flag string was not added when the actual flag was added.
> >
> > Fixes: eadb4fa1e1fe ("cryptodev: support security APIs")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied to dpdk-next-crypto.

Pablo
  

Patch

diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c
index 2a95a351f..3712caf73 100644
--- a/lib/librte_cryptodev/rte_cryptodev.c
+++ b/lib/librte_cryptodev/rte_cryptodev.c
@@ -346,6 +346,8 @@  rte_cryptodev_get_feature_name(uint64_t flag)
 		return "CPU_NEON";
 	case RTE_CRYPTODEV_FF_CPU_ARM_CE:
 		return "CPU_ARM_CE";
+	case RTE_CRYPTODEV_FF_SECURITY:
+		return "SECURITY_PROTOCOL";
 	default:
 		return NULL;
 	}