[dpdk-dev,v2] cryptodev: extend feature flags description

Message ID 20180518164018.2576-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Pablo de Lara Guarch
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

De Lara Guarch, Pablo May 18, 2018, 4:40 p.m. UTC
  Extend the description of cryptodev feature flags,
adding extra information.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---

Changes in v2:
- Rephrased the comment as per Vipin's comments
- Added comment in cryptodev structure

 lib/librte_cryptodev/rte_cryptodev.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
  

Comments

Varghese, Vipin May 21, 2018, 10:13 a.m. UTC | #1
Acked-by: Vipin Varghese <vipin.varghese@intel.com>

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, May 18, 2018 10:10 PM
> To: Varghese, Vipin <vipin.varghese@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH v2] cryptodev: extend feature flags description
> 
> Extend the description of cryptodev feature flags, adding extra information.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> 
> Changes in v2:
> - Rephrased the comment as per Vipin's comments
> - Added comment in cryptodev structure
> 
>  lib/librte_cryptodev/rte_cryptodev.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> b/lib/librte_cryptodev/rte_cryptodev.h
> index 261a359dc..2fb65638d 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -373,7 +373,8 @@ struct rte_cryptodev_info {
>  	uint8_t driver_id;			/**< Driver identifier */
>  	struct rte_pci_device *pci_dev;		/**< PCI information. */
> 
> -	uint64_t feature_flags;			/**< Feature flags */
> +	uint64_t feature_flags;
> +	/**< Feature flags exposes HW/SW features for the given device */
> 
>  	const struct rte_cryptodev_capabilities *capabilities;
>  	/**< Array of devices supported capabilities */ @@ -749,7 +750,7 @@
> struct rte_cryptodev {
>  	struct rte_cryptodev_ops *dev_ops;
>  	/**< Functions exported by PMD */
>  	uint64_t feature_flags;
> -	/**< Supported features */
> +	/**< Feature flags exposes HW/SW features for the given device */
>  	struct rte_device *device;
>  	/**< Backing device */
> 
> --
> 2.17.0
  
Akhil Goyal May 21, 2018, 11:35 a.m. UTC | #2
On 5/18/2018 10:10 PM, Pablo de Lara wrote:
> Extend the description of cryptodev feature flags,
> adding extra information.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
  
De Lara Guarch, Pablo May 21, 2018, 9:45 p.m. UTC | #3
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Monday, May 21, 2018 12:36 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Varghese, Vipin
> <vipin.varghese@intel.com>; Doherty, Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: extend feature flags description
> 
> On 5/18/2018 10:10 PM, Pablo de Lara wrote:
> > Extend the description of cryptodev feature flags, adding extra
> > information.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> 
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied to dpdk-next-crypto.

Pablo
  

Patch

diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index 261a359dc..2fb65638d 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -373,7 +373,8 @@  struct rte_cryptodev_info {
 	uint8_t driver_id;			/**< Driver identifier */
 	struct rte_pci_device *pci_dev;		/**< PCI information. */
 
-	uint64_t feature_flags;			/**< Feature flags */
+	uint64_t feature_flags;
+	/**< Feature flags exposes HW/SW features for the given device */
 
 	const struct rte_cryptodev_capabilities *capabilities;
 	/**< Array of devices supported capabilities */
@@ -749,7 +750,7 @@  struct rte_cryptodev {
 	struct rte_cryptodev_ops *dev_ops;
 	/**< Functions exported by PMD */
 	uint64_t feature_flags;
-	/**< Supported features */
+	/**< Feature flags exposes HW/SW features for the given device */
 	struct rte_device *device;
 	/**< Backing device */