[dpdk-dev] pci: remove unused function
Checks
Commit Message
The function rte_pci_detach() is private to PCI and is
not used anywhere in current code base. Remove dead code.
Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
drivers/bus/pci/pci_common.c | 36 ------------------------------------
drivers/bus/pci/private.h | 14 --------------
2 files changed, 50 deletions(-)
Comments
20/05/2018 21:52, Rami Rosen:
> The function rte_pci_detach() is private to PCI and is
> not used anywhere in current code base. Remove dead code.
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
Applied, thanks
@@ -292,42 +292,6 @@ static struct rte_devargs *pci_devargs_lookup(struct rte_pci_device *dev)
return -1;
}
-/*
- * Detach device specified by its pci address.
- */
-int
-rte_pci_detach(const struct rte_pci_addr *addr)
-{
- struct rte_pci_device *dev = NULL;
- int ret = 0;
-
- if (addr == NULL)
- return -1;
-
- FOREACH_DEVICE_ON_PCIBUS(dev) {
- if (rte_pci_addr_cmp(&dev->addr, addr))
- continue;
-
- ret = rte_pci_detach_dev(dev);
- if (ret < 0)
- /* negative value is an error */
- goto err_return;
- if (ret > 0)
- /* positive value means driver doesn't support it */
- continue;
-
- rte_pci_remove_device(dev);
- free(dev);
- return 0;
- }
- return -1;
-
-err_return:
- RTE_LOG(WARNING, EAL, "Requested device " PCI_PRI_FMT
- " cannot be used\n", dev->addr.domain, dev->addr.bus,
- dev->addr.devid, dev->addr.function);
- return -1;
-}
/*
* Scan the content of the PCI bus, and call the probe() function for
@@ -47,20 +47,6 @@
*/
int rte_pci_probe_one(const struct rte_pci_addr *addr);
-/**
- * Close the single PCI device.
- *
- * Scan the content of the PCI bus, and find the pci device specified by pci
- * address, then call the remove() function for registered driver that has a
- * matching entry in its id_table for discovered device.
- *
- * @param addr
- * The PCI Bus-Device-Function address to close.
- * @return
- * - 0 on success.
- * - Negative on error.
- */
-int rte_pci_detach(const struct rte_pci_addr *addr);
/**
* Find the name of a PCI device.