[dpdk-dev,1/3] net liquidio fix Unable to update lio_dev->linfo.link var

Message ID 1526865655-59863-1-git-send-email-ych@panath.cn (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

chuhong yao May 21, 2018, 1:20 a.m. UTC
  Signed-off-by: yaochuhong <ych@panath.cn>
---
 drivers/net/liquidio/lio_ethdev.c | 6 ++++++
 1 file changed, 6 insertions(+)
 mode change 100644 => 100755 drivers/net/liquidio/lio_ethdev.c
  

Comments

Stephen Hemminger May 21, 2018, 6:55 a.m. UTC | #1
On Mon, 21 May 2018 09:20:53 +0800
yaochuhong <ych@panath.cn> wrote:

> Signed-off-by: yaochuhong <ych@panath.cn>
> ---
>  drivers/net/liquidio/lio_ethdev.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>  mode change 100644 => 100755 drivers/net/liquidio/lio_ethdev.c
> 
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> old mode 100644
> new mode 100755
> index 0e0b5d8..bd47911
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -1405,6 +1405,12 @@ struct rte_lio_xstats_name_off {
>  	/* Configure RSS if device configured with multiple RX queues. */
>  	lio_dev_mq_rx_configure(eth_dev);
>  
> +    /* Before update the link info, set link_status64 to 0,
> +     * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, 
> +     * and lio_dev->intf_open will be set to 0.
> +     */
> +    lio_dev->linfo.link.link_status64 = 0;
> +    
>  	/* start polling for lsc */
>  	ret = rte_eal_alarm_set(LIO_LSC_TIMEOUT,
>  				lio_sync_link_state_check,

Your mail system or editor is converting tabs to spaces.
Please run checkpatch on your submissions.


### [dpdk-dev] [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var

ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files
#88: FILE: drivers/net/liquidio/lio_ethdev.c

ERROR:TRAILING_WHITESPACE: trailing whitespace
#97: FILE: drivers/net/liquidio/lio_ethdev.c:1409:
+     * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, $

WARNING:LONG_LINE_COMMENT: line over 80 characters
#97: FILE: drivers/net/liquidio/lio_ethdev.c:1409:
+     * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, 

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#100: FILE: drivers/net/liquidio/lio_ethdev.c:1412:
+    lio_dev->linfo.link.link_status64 = 0;$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#101: FILE: drivers/net/liquidio/lio_ethdev.c:1413:
+    $

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#101: FILE: drivers/net/liquidio/lio_ethdev.c:1413:
+    $

total: 3 errors, 3 warnings, 0 checks, 12 lines checked
  

Patch

diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
old mode 100644
new mode 100755
index 0e0b5d8..bd47911
--- a/drivers/net/liquidio/lio_ethdev.c
+++ b/drivers/net/liquidio/lio_ethdev.c
@@ -1405,6 +1405,12 @@  struct rte_lio_xstats_name_off {
 	/* Configure RSS if device configured with multiple RX queues. */
 	lio_dev_mq_rx_configure(eth_dev);
 
+    /* Before update the link info, set link_status64 to 0,
+     * Otherwise, when eth_dev->data->mtu != mtu, the link state information cannot be obtained, 
+     * and lio_dev->intf_open will be set to 0.
+     */
+    lio_dev->linfo.link.link_status64 = 0;
+    
 	/* start polling for lsc */
 	ret = rte_eal_alarm_set(LIO_LSC_TIMEOUT,
 				lio_sync_link_state_check,