[dpdk-dev,3/3] add signoff

Message ID 1526865655-59863-3-git-send-email-ych@panath.cn (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

chuhong yao May 21, 2018, 1:20 a.m. UTC
  Signed-off-by: yaochuhong <ych@panath.cn>
---
 drivers/net/liquidio/lio_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ferruh Yigit May 21, 2018, 10:07 a.m. UTC | #1
On 5/21/2018 2:20 AM, yaochuhong wrote:
> Signed-off-by: yaochuhong <ych@panath.cn>

Hi Yao,

Thanks for contribution.

Can you please send this as a single patch, and for sign off please follow
Signed-off-by: Name Surname <e-mail@all_lower.case>

There is some documentation about how to prepare and send a patch that may help:
https://dpdk.org/doc/guides/contributing/patches.html

> ---
>  drivers/net/liquidio/lio_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
> index 0a6eb55..a6a37c8 100644
> --- a/drivers/net/liquidio/lio_ethdev.c
> +++ b/drivers/net/liquidio/lio_ethdev.c
> @@ -1405,7 +1405,7 @@ struct rte_lio_xstats_name_off {
>  	/* Configure RSS if device configured with multiple RX queues. */
>  	lio_dev_mq_rx_configure(eth_dev);
>  
> -	/* Before update the link info, must set link_status64 to 0. */
> +	/* Before update the link info, must set linfo.link.link_status64 to 0. */
>      lio_dev->linfo.link.link_status64 = 0;
>      
>  	/* start polling for lsc */
>
  
chuhong yao May 21, 2018, 10:11 a.m. UTC | #2
Ok, I see.

搜索

复制

 
 
------------------ Original ------------------
From: "Ferruh Yigit"; 

Date: 2018年5月21日(星期一) 晚上6:07
To: "yaochuhong"; "shijith.thotton"; 
Cc: "dev"; 
Subject: Re: [dpdk-dev] [PATCH 3/3] add signoff

 
On 5/21/2018 2:20 AM, yaochuhong wrote:
> Signed-off-by: yaochuhong <ych@panath.cn>


Hi Yao,

Thanks for contribution.

Can you please send this as a single patch, and for sign off please follow
Signed-off-by: Name Surname <e-mail@all_lower.case>


There is some documentation about how to prepare and send a patch that may help:
https://dpdk.org/doc/guides/contributing/patches.html

> ---

>  drivers/net/liquidio/lio_ethdev.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c

> index 0a6eb55..a6a37c8 100644

> --- a/drivers/net/liquidio/lio_ethdev.c

> +++ b/drivers/net/liquidio/lio_ethdev.c

> @@ -1405,7 +1405,7 @@ struct rte_lio_xstats_name_off {

>  	/* Configure RSS if device configured with multiple RX queues. */

>  	lio_dev_mq_rx_configure(eth_dev);

>  

> -	/* Before update the link info, must set link_status64 to 0. */

> +	/* Before update the link info, must set linfo.link.link_status64 to 0. */

>      lio_dev->linfo.link.link_status64 = 0;

>      

>  	/* start polling for lsc */

>
  

Patch

diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c
index 0a6eb55..a6a37c8 100644
--- a/drivers/net/liquidio/lio_ethdev.c
+++ b/drivers/net/liquidio/lio_ethdev.c
@@ -1405,7 +1405,7 @@  struct rte_lio_xstats_name_off {
 	/* Configure RSS if device configured with multiple RX queues. */
 	lio_dev_mq_rx_configure(eth_dev);
 
-	/* Before update the link info, must set link_status64 to 0. */
+	/* Before update the link info, must set linfo.link.link_status64 to 0. */
     lio_dev->linfo.link.link_status64 = 0;
     
 	/* start polling for lsc */