diff mbox

[dpdk-dev,v6,4/8] rte_mbuf.h: reduce temp to match uint16 types

Message ID 152686807337.58694.8171528630879404747.stgit@localhost.localdomain (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Andy Green May 21, 2018, 2:01 a.m. UTC 
  /projects/lagopus/src/dpdk/build/include/rte_mbuf.h:
    In function 'rte_pktmbuf_detach':
    /projects/lagopus/src/dpdk/build/include/rte_mbuf.h:
    1583:17: warning: conversion from 'uint32_t' {aka
    'unsigned int'} to 'uint16_t' {aka
    'short unsigned int'} may change value [-Wconversion]
      m->priv_size = priv_size;
                     ^~~~~~~~~

    The temp priv_size is declared as a uint32_t.  But it
    only deals in uint16_t.  m->priv_size is a uint16_t.
    Change it to a uint16_t.

Fixes: 355e6735b3 ("mbuf: fix cloning with private mbuf data")
Fixes: 1a60a0daa6 ("mbuf: fix segments number type increase")
Signed-off-by: Andy Green <andy@warmcat.com>
---
 lib/librte_mbuf/rte_mbuf.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Bruce Richardson May 21, 2018, 12:14 p.m. UTC | #1 
On Mon, May 21, 2018 at 10:01:13AM +0800, Andy Green wrote:
>     /projects/lagopus/src/dpdk/build/include/rte_mbuf.h:
>     In function 'rte_pktmbuf_detach':
>     /projects/lagopus/src/dpdk/build/include/rte_mbuf.h:
>     1583:17: warning: conversion from 'uint32_t' {aka
>     'unsigned int'} to 'uint16_t' {aka
>     'short unsigned int'} may change value [-Wconversion]
>       m->priv_size = priv_size;
>                      ^~~~~~~~~
> 
>     The temp priv_size is declared as a uint32_t.  But it
>     only deals in uint16_t.  m->priv_size is a uint16_t.
>     Change it to a uint16_t.
> 
> Fixes: 355e6735b3 ("mbuf: fix cloning with private mbuf data")
> Fixes: 1a60a0daa6 ("mbuf: fix segments number type increase")
> Signed-off-by: Andy Green <andy@warmcat.com>
> ---
>  lib/librte_mbuf/rte_mbuf.h |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
diff mbox

Patch

diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 28fd4ad52..76e37a2f8 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -1571,7 +1571,8 @@  __rte_pktmbuf_free_direct(struct rte_mbuf *m)
 static inline void rte_pktmbuf_detach(struct rte_mbuf *m)
 {
 	struct rte_mempool *mp = m->pool;
-	uint32_t mbuf_size, buf_len, priv_size;
+	uint32_t mbuf_size, buf_len;
+	uint16_t priv_size;
 
 	if (RTE_MBUF_HAS_EXTBUF(m))
 		__rte_pktmbuf_free_extbuf(m);