diff mbox

[dpdk-dev] examples/bond: add header to support freebsd compilation

Message ID 1448474637-4232-1-git-send-email-danielx.t.mrzyglod@intel.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Daniel Mrzyglod Nov. 25, 2015, 6:03 p.m. UTC 
  definition of 'AF_INET' enum was missing - is available in <sys/socket.h>

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
 examples/bond/main.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Monjalon Nov. 25, 2015, 6:08 p.m. UTC | #1 
2015-11-25 19:03, Daniel Mrzyglod:
> definition of 'AF_INET' enum was missing - is available in <sys/socket.h>
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>

It is definitely the right fix as Ferruh submitted the same one
less than one hour ago.
Should we understand it is an ack?

It seems Ferruh was hesitating about the line where inserting the
include. I would say I prefer your choice :)
Daniel Mrzyglod Nov. 26, 2015, 9:55 a.m. UTC | #2 
>-----Original Message-----
>From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
>Sent: Wednesday, November 25, 2015 7:08 PM
>
>2015-11-25 19:03, Daniel Mrzyglod:
>> definition of 'AF_INET' enum was missing - is available in <sys/socket.h>
>>
>> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>
>It is definitely the right fix as Ferruh submitted the same one
>less than one hour ago.
>Should we understand it is an ack?
>
>It seems Ferruh was hesitating about the line where inserting the
>include. I would say I prefer your choice :)

I acked Ferruh patch. I didn't notice he send patch first.
You can combine both patches :> He has much better description :>
Thomas Monjalon Dec. 7, 2015, 1:40 a.m. UTC | #3 
2015-12-02 10:53, Ferruh Yigit:
> On Thu, Nov 26, 2015 at 09:55:17AM +0000, Mrzyglod, DanielX T wrote:
> > 
> > 
> > >-----Original Message-----
> > >From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > >Sent: Wednesday, November 25, 2015 7:08 PM
> > >
> > >2015-11-25 19:03, Daniel Mrzyglod:
> > >> definition of 'AF_INET' enum was missing - is available in <sys/socket.h>
> > >>
> > >> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> > >
> > >It is definitely the right fix as Ferruh submitted the same one
> > >less than one hour ago.
> > >Should we understand it is an ack?
> > >
> > >It seems Ferruh was hesitating about the line where inserting the
> > >include. I would say I prefer your choice :)
> > 
> > I acked Ferruh patch. I didn't notice he send patch first.
> > You can combine both patches :> He has much better description :>
> 
> Thomas said he prefer this one, let's use this one.
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/examples/bond/main.c b/examples/bond/main.c
index 4622283..53bd044 100644
--- a/examples/bond/main.c
+++ b/examples/bond/main.c
@@ -33,6 +33,7 @@ 
 
 #include <stdint.h>
 #include <sys/queue.h>
+#include <sys/socket.h>
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>